Page MenuHomePhabricator

[web] Add dev-only button to log out secondary device
ClosedPublic

Authored by bartek on May 28 2024, 4:26 AM.
Tags
None
Referenced Files
F3368915: D12223.diff
Mon, Nov 25, 9:05 PM
Unknown Object (File)
Sun, Nov 24, 5:48 AM
Unknown Object (File)
Fri, Nov 22, 8:08 PM
Unknown Object (File)
Fri, Nov 22, 3:24 PM
Unknown Object (File)
Mon, Nov 18, 8:45 AM
Unknown Object (File)
Wed, Nov 13, 11:51 PM
Unknown Object (File)
Wed, Nov 13, 1:45 PM
Unknown Object (File)
Mon, Nov 11, 9:41 AM
Subscribers

Details

Summary

Added a dev-only button to perform secondary device logout, for test purposes.
I deliberately did not include any checks if given device is primary or secondary, to test the hook behavior from previous diff.
In the future, logout button behavior will depend on whether current device is primary.

Depends on D12222

Test Plan

Pressed the button and repeated test plan from D12221 to check hook behavior.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.May 28 2024, 5:19 AM
kamil added inline comments.
web/settings/account-settings.react.js
158 ↗(On Diff #40677)

this flag is not dev-only - but also for staff members, is it intentional?

This revision is now accepted and ready to land.Jun 6 2024, 12:35 AM
web/settings/account-settings.react.js
158 ↗(On Diff #40677)

Yeah should be dev only, I'll fix that