Page MenuHomePhabricator
Differential D12342

[commtest] Make ClientPublicKeys::device_id() return str slice
ClosedPublic
Actions

Authored by bartek on Jun 6 2024, 11:32 PM.
Tags
None
Referenced Files
F3449825: D12342.id41099.diff
Thu, Dec 12, 4:55 PM
F3449822: D12342.id41235.diff
Thu, Dec 12, 4:54 PM
F3449809: D12342.id41085.diff
Thu, Dec 12, 4:37 PM
F3449718: D12342.diff
Thu, Dec 12, 1:43 PM
Unknown Object (File)
Wed, Dec 4, 2:07 AM
Unknown Object (File)
Tue, Dec 3, 3:00 AM
Unknown Object (File)
Nov 2 2024, 5:10 AM
Unknown Object (File)
Nov 2 2024, 5:09 AM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
varun
marcin
Commits
rCOMMca2f17d8813d: [commtest] Make ClientPublicKeys::device_id() return str slice
Summary

Depends on D12341

Minor change for better reusability. It's better to have a slice and use to_string() only when needed.

Test Plan

Commtest

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
identity/
4 lines
4 lines
tests/
10 lines

Diff 41085

View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/src/identity/olm_account_infos.rs

Loading...
View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...