Page MenuHomePhabricator

[lib] Define steps in link acceptance hook
ClosedPublic

Authored by tomek on Jun 13 2024, 5:38 AM.
Tags
None
Referenced Files
F3381862: D12424.diff
Thu, Nov 28, 6:52 AM
F3380059: D12424.diff
Wed, Nov 27, 8:48 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:15 PM
Unknown Object (File)
Oct 25 2024, 12:06 AM
Unknown Object (File)
Oct 11 2024, 1:29 PM
Subscribers

Details

Summary

This makes it easier to reason about the flow and to add a new step.

https://linear.app/comm/issue/ENG-8250/join-a-thread-after-joining-a-community

Depends on D12423

Test Plan

Tested with the rest of the stack. Checked if joining communities still works. Also, added some timeouts in the auth keyserver effect and in the thread join responder and verified that the loading status was correct.

Note: didn't test the secondary keyserver invite links - they don't work currently because of https://linear.app/comm/issue/ENG-7592/invite-links-of-the-secondary-keyserver-dont-work.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage