Page MenuHomePhabricator
Differential D12450

[web] update QR login flow to use `QRAuthContext`
ClosedPublic
Actions

Authored by kamil on Jun 17 2024, 3:55 AM.
Tags
None
Referenced Files
F3384074: D12450.diff
Thu, Nov 28, 7:15 PM
Unknown Object (File)
Mon, Nov 25, 9:59 AM
Unknown Object (File)
Mon, Nov 25, 7:00 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
View All 49 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM69332152efe6: [web] update QR login flow to use `QRAuthContext`
Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Rendering context and de-duplicating logic.

Depends on D12449

Test Plan

Test QR login flow on web. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
account/
58 lines
35 lines
utils/
6 lines

Diff 41382

View Options

web/account/qr-code-login.react.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/utils/qr-code-utils.js

Loading...