Page MenuHomePhabricator
Differential D12294

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 5:05 PM
Unknown Object (File)
Thu, Apr 3, 12:12 PM
Unknown Object (File)
Wed, Apr 2, 10:59 AM
Unknown Object (File)
Wed, Apr 2, 9:36 AM
Unknown Object (File)
Mon, Mar 31, 4:46 AM
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Fri, Mar 28, 8:34 AM
Unknown Object (File)
Mar 6 2025, 7:30 AM
View All 87 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from…
Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook

Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12294_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
17 lines

Diff 41416

View Options

lib/shared/thread-utils.js

Show All 34 Linesvoid AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection); this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) { this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect"; << ", will try to reconnect";
this->amqpReady = false; this->amqpReady = false;
}); });
AMQP::Table arguments; AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL; arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL; arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout); this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments) this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName]( .onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name, const std::string &name,
uint32_t messagecount, uint32_t messagecount,
uint32_t consumercount) { uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created"; LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "") this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines