Page MenuHomePhabricator

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 5:46 PM
Unknown Object (File)
Sun, Oct 13, 3:31 PM
Unknown Object (File)
Thu, Oct 10, 10:25 PM
Unknown Object (File)
Thu, Oct 10, 10:25 PM
Unknown Object (File)
Thu, Oct 10, 10:25 PM
Unknown Object (File)
Oct 5 2024, 4:03 AM
Unknown Object (File)
Sep 28 2024, 3:18 AM
Unknown Object (File)
Sep 25 2024, 10:49 PM
Subscribers
None

Details

Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook


Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12294_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage