Page MenuHomePhabricator

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
F3354157: D12294.id40903.diff
Sat, Nov 23, 12:04 PM
F3353802: D12294.id41417.diff
Sat, Nov 23, 11:28 AM
F3353489: D12294.diff
Sat, Nov 23, 9:59 AM
Unknown Object (File)
Fri, Nov 15, 6:15 AM
Unknown Object (File)
Mon, Nov 11, 1:09 AM
Unknown Object (File)
Sun, Nov 10, 11:00 PM
Unknown Object (File)
Sun, Nov 10, 4:57 PM
Unknown Object (File)
Fri, Nov 8, 1:52 PM
Subscribers
None

Details

Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook


Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable