Page MenuHomePhabricator

[lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
ClosedPublic

Authored by atul on Jun 3 2024, 2:00 PM.
Tags
None
Referenced Files
F2832151: D12294.id41417.diff
Sat, Sep 28, 3:18 AM
Unknown Object (File)
Wed, Sep 25, 10:49 PM
Unknown Object (File)
Wed, Sep 25, 10:49 PM
Unknown Object (File)
Mon, Sep 9, 9:07 AM
Unknown Object (File)
Mon, Sep 9, 9:07 AM
Unknown Object (File)
Mon, Sep 9, 8:52 AM
Unknown Object (File)
Wed, Sep 4, 12:30 PM
Unknown Object (File)
Aug 26 2024, 4:10 PM
Subscribers
None

Details

Summary

Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook


Depends on D12293

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable