Page MenuHomePhabricator
Differential D12738

[web] Introduce getRelatedMessages to shared worker
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 8:50 AM
Unknown Object (File)
Fri, Mar 7, 5:40 AM
Unknown Object (File)
Wed, Mar 5, 6:55 PM
Unknown Object (File)
Feb 27 2025, 6:17 AM
Unknown Object (File)
Feb 26 2025, 6:02 AM
Unknown Object (File)
Feb 26 2025, 6:02 AM
Unknown Object (File)
Feb 26 2025, 6:02 AM
Unknown Object (File)
Feb 26 2025, 6:02 AM
View All Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMMba1a449ef488: [web] Introduce getRelatedMessages to shared worker
Summary

This diff introduces the code on web to interface with our new getRelatedMessages API exposed via WASM.

Depends on D12737

Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:11 PM
ashoat added a child revision: D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Harbormaster completed remote builds in B30311: Diff 42271.Jul 14 2024, 6:28 PM
ashoat requested review of this revision.Jul 14 2024, 6:28 PM
marcin accepted this revision.Jul 15 2024, 2:53 AM
This revision is now accepted and ready to land.Jul 15 2024, 2:53 AM
ashoat retitled this revision from [web] Introduce getLatestMessageEdit to shared worker to [web] Introduce getRelatedMessages to shared worker.Jul 15 2024, 7:02 PM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat retitled this revision from [web] Introduce getRelatedMessages to shared worker to [web] Introduce getRelatedMessages to shared worker.
ashoat edited the test plan for this revision. (Show Details)
ashoat edited the summary of this revision. (Show Details)
ashoat updated this revision to Diff 42310.Jul 15 2024, 7:14 PM

Rework into getRelatedMessages, which can be reused for rendering search results

Harbormaster failed remote builds in B30348: Diff 42310!Jul 15 2024, 7:26 PM
ashoat updated this revision to Diff 42316.Jul 15 2024, 7:55 PM

ESLint fix

Harbormaster failed remote builds in B30354: Diff 42316!Jul 15 2024, 8:26 PM
ashoat updated this revision to Diff 42333.Jul 16 2024, 4:08 AM

Rebase

Harbormaster completed remote builds in B30370: Diff 42333.Jul 16 2024, 4:24 AM
Closed by commit rCOMMba1a449ef488: [web] Introduce getRelatedMessages to shared worker (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMba1a449ef488: [web] Introduce getRelatedMessages to shared worker.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
14 lines
types/
19 lines

Diff 42271

View Options

web/shared-worker/worker/shared-worker.js

// @flow // @flow
import type { PossiblyStaleNavigationState } from '@react-navigation/native'; import type { PossiblyStaleNavigationState } from '@react-navigation/native';
import { useRoute } from '@react-navigation/native';
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js'; import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';
import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js'; import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';
import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { CalendarFilter } from 'lib/types/filter-types.js'; import type { CalendarFilter } from 'lib/types/filter-types.js';
import type {
ComposableMessageInfo,
RobotextMessageInfo,
} from 'lib/types/message-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { NavContextType } from './navigation-context.js'; import type { NavContextType } from './navigation-context.js';
import { NavContext } from './navigation-context.js'; import { NavContext } from './navigation-context.js';
import { import {
getStateFromNavigatorRoute, getStateFromNavigatorRoute,
getThreadIDFromRoute, getThreadIDFromRoute,
currentLeafRoute, currentLeafRoute,
} from './navigation-utils.js'; } from './navigation-utils.js';
import { import {
AppRouteName, AppRouteName,
TabNavigatorRouteName, TabNavigatorRouteName,
MessageListRouteName, MessageListRouteName,
ChatRouteName, ChatRouteName,
CalendarRouteName, CalendarRouteName,
ThreadPickerModalRouteName, ThreadPickerModalRouteName,
ActionResultModalRouteName, ActionResultModalRouteName,
accountModals, accountModals,
scrollBlockingModals, scrollBlockingModals,
chatRootModals, chatRootModals,
threadRoutes, threadRoutes,
CommunityDrawerNavigatorRouteName, CommunityDrawerNavigatorRouteName,
MessageResultsScreenRouteName,
MessageSearchRouteName,
} from './route-names.js'; } from './route-names.js';
import type { RemoveEditMode } from '../chat/message-list-types'; import type { RemoveEditMode } from '../chat/message-list-types';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { NavPlusRedux } from '../types/selector-types.js'; import type { NavPlusRedux } from '../types/selector-types.js';
import type { GlobalTheme } from '../types/themes.js'; import type { GlobalTheme } from '../types/themes.js';
const baseCreateIsForegroundSelector = (routeName: string) => const baseCreateIsForegroundSelector = (routeName: string) =>
createSelector( createSelector(
▲ Show 20 Lines • Show All 343 Lines • ▼ Show 20 Linesfunction useCurrentLeafRouteName(): ?string {
return React.useMemo(() => { return React.useMemo(() => {
if (!navContext) { if (!navContext) {
return undefined; return undefined;
} }
return currentLeafRoute(navContext.state).name; return currentLeafRoute(navContext.state).name;
}, [navContext]); }, [navContext]);
} }
function useCanEditMessageNative(
threadInfo: ThreadInfo,
targetMessageInfo: ComposableMessageInfo | RobotextMessageInfo,
): boolean {
const route = useRoute();
const screenKey = route.key;
const threadCreationTime = threadInfo.creationTime;
const messageCreationTime = targetMessageInfo.time;
const canEditInThisScreen =
!screenKey.startsWith(MessageSearchRouteName) &&
!screenKey.startsWith(MessageResultsScreenRouteName) &&
messageCreationTime >= threadCreationTime;
return (
useCanEditMessage(threadInfo, targetMessageInfo) && canEditInThisScreen
);
}
export { export {
createIsForegroundSelector, createIsForegroundSelector,
useIsAppLoggedIn, useIsAppLoggedIn,
createActiveTabSelector, createActiveTabSelector,
scrollBlockingModalsClosedSelector, scrollBlockingModalsClosedSelector,
selectBackgroundIsDark, selectBackgroundIsDark,
activeThreadSelector, activeThreadSelector,
activeMessageListSelector, activeMessageListSelector,
useActiveThread, useActiveThread,
useActiveMessageList, useActiveMessageList,
calendarActiveSelector, calendarActiveSelector,
nativeCalendarQuery, nativeCalendarQuery,
nonThreadCalendarQuery, nonThreadCalendarQuery,
useCalendarQuery, useCalendarQuery,
drawerSwipeEnabledSelector, drawerSwipeEnabledSelector,
useCurrentLeafRouteName, useCurrentLeafRouteName,
getRemoveEditMode, getRemoveEditMode,
getTabNavState, getTabNavState,
getChatNavStateFromTabNavState, getChatNavStateFromTabNavState,
useCanEditMessageNative,
}; };
View Options

web/types/worker-types.js

// @flow // @flow
import type { PossiblyStaleNavigationState } from '@react-navigation/native'; import type { PossiblyStaleNavigationState } from '@react-navigation/native';
import { useRoute } from '@react-navigation/native';
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js'; import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';
import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js'; import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';
import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { CalendarFilter } from 'lib/types/filter-types.js'; import type { CalendarFilter } from 'lib/types/filter-types.js';
import type {
ComposableMessageInfo,
RobotextMessageInfo,
} from 'lib/types/message-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { NavContextType } from './navigation-context.js'; import type { NavContextType } from './navigation-context.js';
import { NavContext } from './navigation-context.js'; import { NavContext } from './navigation-context.js';
import { import {
getStateFromNavigatorRoute, getStateFromNavigatorRoute,
getThreadIDFromRoute, getThreadIDFromRoute,
currentLeafRoute, currentLeafRoute,
} from './navigation-utils.js'; } from './navigation-utils.js';
import { import {
AppRouteName, AppRouteName,
TabNavigatorRouteName, TabNavigatorRouteName,
MessageListRouteName, MessageListRouteName,
ChatRouteName, ChatRouteName,
CalendarRouteName, CalendarRouteName,
ThreadPickerModalRouteName, ThreadPickerModalRouteName,
ActionResultModalRouteName, ActionResultModalRouteName,
accountModals, accountModals,
scrollBlockingModals, scrollBlockingModals,
chatRootModals, chatRootModals,
threadRoutes, threadRoutes,
CommunityDrawerNavigatorRouteName, CommunityDrawerNavigatorRouteName,
MessageResultsScreenRouteName,
MessageSearchRouteName,
} from './route-names.js'; } from './route-names.js';
import type { RemoveEditMode } from '../chat/message-list-types'; import type { RemoveEditMode } from '../chat/message-list-types';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import type { NavPlusRedux } from '../types/selector-types.js'; import type { NavPlusRedux } from '../types/selector-types.js';
import type { GlobalTheme } from '../types/themes.js'; import type { GlobalTheme } from '../types/themes.js';
const baseCreateIsForegroundSelector = (routeName: string) => const baseCreateIsForegroundSelector = (routeName: string) =>
createSelector( createSelector(
▲ Show 20 Lines • Show All 343 Lines • ▼ Show 20 Linesfunction useCurrentLeafRouteName(): ?string {
return React.useMemo(() => { return React.useMemo(() => {
if (!navContext) { if (!navContext) {
return undefined; return undefined;
} }
return currentLeafRoute(navContext.state).name; return currentLeafRoute(navContext.state).name;
}, [navContext]); }, [navContext]);
} }
function useCanEditMessageNative(
threadInfo: ThreadInfo,
targetMessageInfo: ComposableMessageInfo | RobotextMessageInfo,
): boolean {
const route = useRoute();
const screenKey = route.key;
const threadCreationTime = threadInfo.creationTime;
const messageCreationTime = targetMessageInfo.time;
const canEditInThisScreen =
!screenKey.startsWith(MessageSearchRouteName) &&
!screenKey.startsWith(MessageResultsScreenRouteName) &&
messageCreationTime >= threadCreationTime;
return (
useCanEditMessage(threadInfo, targetMessageInfo) && canEditInThisScreen
);
}
export { export {
createIsForegroundSelector, createIsForegroundSelector,
useIsAppLoggedIn, useIsAppLoggedIn,
createActiveTabSelector, createActiveTabSelector,
scrollBlockingModalsClosedSelector, scrollBlockingModalsClosedSelector,
selectBackgroundIsDark, selectBackgroundIsDark,
activeThreadSelector, activeThreadSelector,
activeMessageListSelector, activeMessageListSelector,
useActiveThread, useActiveThread,
useActiveMessageList, useActiveMessageList,
calendarActiveSelector, calendarActiveSelector,
nativeCalendarQuery, nativeCalendarQuery,
nonThreadCalendarQuery, nonThreadCalendarQuery,
useCalendarQuery, useCalendarQuery,
drawerSwipeEnabledSelector, drawerSwipeEnabledSelector,
useCurrentLeafRouteName, useCurrentLeafRouteName,
getRemoveEditMode, getRemoveEditMode,
getTabNavState, getTabNavState,
getChatNavStateFromTabNavState, getChatNavStateFromTabNavState,
useCanEditMessageNative,
}; };