Page MenuHomePhabricator
Differential D12739

[native] Introduce getRelatedMessages to CommCoreModule
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:12 PM.
Tags
None
Referenced Files
F5267680: D12739.id.diff
Sun, Apr 6, 9:13 PM
F5266048: D12739.id42334.diff
Sun, Apr 6, 8:12 PM
Unknown Object (File)
Sun, Apr 6, 12:18 AM
Unknown Object (File)
Sun, Mar 30, 9:16 PM
Unknown Object (File)
Wed, Mar 12, 5:53 AM
Unknown Object (File)
Tue, Mar 11, 10:25 PM
Unknown Object (File)
Tue, Mar 11, 8:05 PM
Unknown Object (File)
Tue, Mar 11, 9:39 AM
View All Files
Subscribers
None

Details

Reviewers
kamil
tomek
marcin
Commits
rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule
Summary

This diff introduces the code on native to interface with our new getRelatedMessages API.

Depends on D12738

Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:12 PM
ashoat added a child revision: D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.
Harbormaster completed remote builds in B30312: Diff 42272.Jul 14 2024, 6:34 PM
ashoat requested review of this revision.Jul 14 2024, 6:34 PM
marcin accepted this revision.Jul 15 2024, 2:58 AM
marcin added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗(On Diff #42272)

This formatting looks strange. Did you run yarn clang-format-all? It doesn't get executed automatically during commit, Dev must execute it manually to achieve formatting.

This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM
marcin added inline comments.Jul 15 2024, 4:07 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗(On Diff #42272)

Sorry for the confusion - after talking to @kamil I found that this sentence:

It doesn't get executed automatically during commit, Dev must execute it manually to achieve formatting.

is only true if someone has commit hooks disabled.

ashoat added inline comments.Jul 15 2024, 4:59 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗(On Diff #42272)

I can confirm that running yarn clang-format-all yields no changes

ashoat retitled this revision from [native] Introduce getLatestMessageEdit to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.Jul 15 2024, 7:02 PM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat updated this revision to Diff 42311.Jul 15 2024, 7:14 PM

Rework into getRelatedMessages, which can be reused for rendering search results

ashoat retitled this revision from [native] Introduce getRelatedMessages to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.Jul 15 2024, 7:14 PM
ashoat edited the summary of this revision. (Show Details)
Harbormaster failed remote builds in B30349: Diff 42311!Jul 15 2024, 7:30 PM
ashoat updated this revision to Diff 42317.Jul 15 2024, 7:58 PM

Rebase

Harbormaster failed remote builds in B30355: Diff 42317!Jul 15 2024, 8:35 PM
ashoat updated this revision to Diff 42334.Jul 16 2024, 4:09 AM

Rebase

Harbormaster completed remote builds in B30371: Diff 42334.Jul 16 2024, 4:26 AM
Closed by commit rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
36 lines
_generated/
schema/
1 line

Diff 42317

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines RNSVG:
:path: "../node_modules/react-native-svg" :path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation: SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation" :path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga: Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga" :path: "../../node_modules/react-native/ReactCommon/yoga"
SPEC CHECKSUMS: SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234 boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9 CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903 EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8 EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415 EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6 EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80 EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 LinesSPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8 SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0 SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4 SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8 SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295 Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb
PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43 PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1
COCOAPODS: 1.12.1 COCOAPODS: 1.12.1
View Options

native/schema/CommCoreModuleSchema.js

Loading...