Details

Reviewers

kamil
tomek
marcin

Commits

rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule

Summary

This diff introduces the code on native to interface with our new getRelatedMessages API.

Depends on D12738

Test Plan

In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:12 PM

ashoat added a child revision: D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.

Harbormaster completed remote builds in B30312: Diff 42272.Jul 14 2024, 6:34 PM

ashoat requested review of this revision.Jul 14 2024, 6:34 PM

marcin accepted this revision.Jul 15 2024, 2:58 AM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗	(On Diff #42272)	This formatting looks strange. Did you run `yarn clang-format-all`? It doesn't get executed automatically during commit, Dev must execute it manually to achieve formatting.

This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM

marcin added inline comments.Jul 15 2024, 4:07 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗	(On Diff #42272)	Sorry for the confusion - after talking to @kamil I found that this sentence: It doesn't get executed automatically during commit, Dev must execute it manually to achieve formatting. is only true if someone has commit hooks disabled.

ashoat added inline comments.Jul 15 2024, 4:59 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2616–2620 ↗	(On Diff #42272)	I can confirm that running `yarn clang-format-all` yields no changes

ashoat retitled this revision from [native] Introduce getLatestMessageEdit to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.Jul 15 2024, 7:02 PM

ashoat edited the summary of this revision. (Show Details)

ashoat edited the test plan for this revision. (Show Details)

Rework into getRelatedMessages, which can be reused for rendering search results

ashoat retitled this revision from [native] Introduce getRelatedMessages to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.Jul 15 2024, 7:14 PM

ashoat edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B30349: Diff 42311!Jul 15 2024, 7:30 PM

Rebase

Harbormaster failed remote builds in B30355: Diff 42317!Jul 15 2024, 8:35 PM

Rebase

Harbormaster completed remote builds in B30371: Diff 42334.Jul 16 2024, 4:26 AM

Closed by commit rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule (authored by ashoat). · Explain WhyJul 16 2024, 6:46 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa272644bd405: [native] Introduce getRelatedMessages to CommCoreModule.