Page MenuHomePhabricator

[lib] Introduce getRelatedMessages to SQLiteAPI
ClosedPublic

Authored by ashoat on Jul 14 2024, 6:14 PM.
Tags
None
Referenced Files
F3181564: D12740.id42335.diff
Fri, Nov 8, 6:30 AM
F3180750: D12740.id42273.diff
Fri, Nov 8, 5:15 AM
Unknown Object (File)
Fri, Oct 18, 10:29 PM
Unknown Object (File)
Fri, Oct 18, 10:29 PM
Unknown Object (File)
Fri, Oct 18, 10:24 PM
Unknown Object (File)
Oct 2 2024, 11:46 PM
Unknown Object (File)
Sep 25 2024, 7:55 PM
Unknown Object (File)
Sep 25 2024, 7:55 PM
Subscribers
None

Details

Summary

This diff introduces a shared interface on SQLiteAPI so the JS code in lib can hit this API on both native and web.

Depends on D12739

Test Plan
  1. In combination with later diffs, I tested a patch on both native and web that hit getRelatedMessages with a specific message ID and confirmed that it returned the message
  2. I tested a message ID that did not exist and confirmed I got undefined back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Jul 15 2024, 2:58 AM
ashoat retitled this revision from [lib] Introduce getLatestMessageEdit to SQLiteAPI to [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 7:03 PM
ashoat edited the test plan for this revision. (Show Details)

Rework into getRelatedMessages, which can be reused for rendering search results