[keyserver][lib] Factor out joinThreadSubscription
ClosedPublic
Actions

Authored by ashoat on Jul 20 2024, 9:19 PM.

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM82b5866a1c9a: [keyserver][lib] Factor out joinThreadSubscription

Summary

This diff does two minor things:

Factors out joinThreadSubscription so it can be reused in the following diff
Redefines defaultSubscriptionString so that it uses defaultThreadSubscription instead of redefining it

Depends on D12781

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 20 2024, 9:19 PM

Harbormaster completed remote builds in B30543: Diff 42590.Jul 20 2024, 9:36 PM

ashoat requested review of this revision.Jul 20 2024, 9:36 PM

ashoat added a child revision: D12825: [lib] Turn on notifs by default for thick threads.Jul 20 2024, 9:38 PM

tomek accepted this revision.Jul 22 2024, 3:26 AM

This revision is now accepted and ready to land.Jul 22 2024, 3:26 AM

Closed by commit rCOMM82b5866a1c9a: [keyserver][lib] Factor out joinThreadSubscription (authored by ashoat). · Explain WhyJul 22 2024, 9:29 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM82b5866a1c9a: [keyserver][lib] Factor out joinThreadSubscription.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

thread-permission-updaters.js

13 lines

lib/

types/

subscription-types.js

11 lines

Diff 42590

View Options

keyserver/src/updaters/thread-permission-updaters.js