Page MenuHomePhabricator
Differential D13187

[lib] add editing DM messages
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 1:58 AM
Unknown Object (File)
Mar 6 2025, 7:06 AM
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:16 AM
Unknown Object (File)
Mar 4 2025, 7:15 AM
Unknown Object (File)
Mar 4 2025, 7:15 AM
Unknown Object (File)
Feb 24 2025, 7:08 PM
View All 65 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMa310cb1fbbbc: [lib] add editing DM messages
Summary

ENG-8976;

Update components logic.

Depends on D13186

Test Plan

Test editing in DM thread on both web and native.

Diff Detail

Repository
rCOMM Comm
Branch
logic-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 28 2024, 2:56 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 2:56 AM
Harbormaster completed remote builds in B31315: Diff 43723.Aug 28 2024, 3:18 AM
kamil published this revision for review.Aug 28 2024, 3:59 AM
tomek requested changes to this revision.Aug 28 2024, 5:39 AM
tomek added inline comments.
lib/shared/edit-messages-utils.js
58 ↗(On Diff #43723)

Thinking about it more, I'm not sure if this is correct (the same concern applies to other diffs). If someone is a member of a thread and isn't a member of its sidebar, can they see a sidebar and the messages it contains? I think that yes, which means that we should send it to all the members - for a thick thread, or all the members of the parent thread - for sidebars.

This revision now requires changes to proceed.Aug 28 2024, 5:39 AM
kamil mentioned this in D13193: [lib] make it possible to send DM ops to all thread members.Aug 28 2024, 6:23 AM
kamil updated this revision to Diff 43747.Aug 28 2024, 6:42 AM

address review

Harbormaster completed remote builds in B31337: Diff 43747.Aug 28 2024, 7:13 AM
tomek accepted this revision.Aug 28 2024, 7:56 AM
This revision is now accepted and ready to land.Aug 28 2024, 7:56 AM
Closed by commit rCOMMa310cb1fbbbc: [lib] add editing DM messages (authored by kamil). · Explain WhyAug 28 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM162fe1df034a: [lib] make it possible to send DM ops to all thread members.
kamil added a commit: rCOMMa310cb1fbbbc: [lib] add editing DM messages.
kamil mentioned this in D13201: [web][native] update text messages recipients.Aug 28 2024, 8:53 AM
kamil mentioned this in rCOMMaef6d707b904: [web][native] update text messages recipients.Aug 29 2024, 1:15 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
83 lines
native/
chat/
2 lines
web/
chat/
2 lines

Diff 43747

View Options

lib/shared/edit-messages-utils.js

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

native/chat/chat-input-bar.react.js

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

web/chat/edit-text-message.react.js

// @flow // @flow
import type { NotificationsCreationData } from './notif-types.js';
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string, +dmOpID?: string,
}
| {
+notificationsCreationData?: NotificationsCreationData,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };