Update search header in chat creation on native not to show GENESIS for thick threads
ClosedPublic
Actions

Authored by inka on Sep 10 2024, 8:44 AM.

Details

Reviewers

marcin
tomek
kamil

Commits

rCOMM1d9f1a465c67: Update search header in chat creation on native not to show GENESIS for thick…

Summary

This differential updates search header in chat creation on native not to show GENESIS for thick threads.

Test Plan

Set usingOlmViaTunnelbrokerForDMs to true.
Start creating a new thread -> "within GENESIS" is NOT displayed
Enter a list of users whit whom we have a thin chat -> "within GENESIS" IS displayed
Enter a list of users whit whom we have a thick chat -> "within GENESIS" is NOT displayed

Diff Detail

Repository

rCOMM Comm

Branch

inka/fix_marcin

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Sep 10 2024, 8:44 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 10 2024, 8:44 AM

marcin added a parent revision: D13267: [web][native] Show relationship prompt in thick PERSONAL threads.Sep 10 2024, 8:45 AM

Harbormaster completed remote builds in B31509: Diff 44010.Sep 10 2024, 9:02 AM

marcin requested review of this revision.Sep 10 2024, 9:02 AM

Thank you! Would be great if you could attach a screenshot

native/chat/message-list-container.react.js
176 ↗	(On Diff #44010)	Can you set this to true? And I will make sure this cannot be called for now during ENG-9132

This revision is now accepted and ready to land.Sep 11 2024, 2:12 AM

inka added a child revision: D13288: [lib] Fix useProcessAndSendDMOperation.Sep 11 2024, 3:10 AM

In D13275#374497, @inka wrote:

Thank you! Would be great if you could attach a screenshot

Zrzut ekranu 2024-09-11 o 13.21.52.png (1×750 px, 170 KB)

marcin attached a referenced file: F2662668: Zrzut ekranu 2024-09-11 o 13.21.52.png. (Show Details)Sep 11 2024, 4:22 AM

Set flag to true in pendingThreadID

Harbormaster completed remote builds in B31529: Diff 44035.Sep 11 2024, 4:42 AM

inka commandeered this revision.Sep 12 2024, 2:51 AM

inka edited reviewers, added: marcin; removed: inka.

This revision now requires review to proceed.Sep 12 2024, 2:51 AM

inka added reviewers: tomek, kamil.Sep 12 2024, 7:15 AM

@marcin changed a different place than I had in mind, but this made me realise that we call threadTypeIsThick check on a result of pendingThreadType. So the outcome is determined by the flag we use in this pendingThreadType. We should create a proper childThreadType depending on whether we want thick or thin and then use it in ParentThreadHeader