Page MenuHomePhabricator
Differential D13346

[lib] extend ProcessDMOperationUtilities to include entryInfos
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:27 AM.
Tags
None
Referenced Files
F4912002: D13346.diff
Sat, Mar 15, 1:04 AM
Unknown Object (File)
Fri, Mar 14, 6:13 AM
Unknown Object (File)
Fri, Mar 14, 5:49 AM
Unknown Object (File)
Tue, Mar 11, 7:13 AM
Unknown Object (File)
Fri, Mar 7, 7:30 AM
Unknown Object (File)
Mon, Mar 3, 10:22 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
View All 87 Files
Subscribers
None

Details

Reviewers
marcin
ashoat
tomek
Commits
rCOMM574b46ee991d: [lib] extend ProcessDMOperationUtilities to include entryInfos
Summary

This extends utilities to include entryInfos. I use this later when checking timestamps

Depends on D13345

Test Plan

Was able to use this later in the stack by accessing entry infos for a given entryID

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
4 lines

Diff 44252

View Options

lib/shared/dm-ops/dm-op-spec.js

// @flow // @flow
import type { DMOperation, DMOperationResult } from '../../types/dm-ops.js'; import type { DMOperation, DMOperationResult } from '../../types/dm-ops.js';
import type { RawEntryInfos } from '../../types/entry-types.js';
import type { RawMessageInfo } from '../../types/message-types.js'; import type { RawMessageInfo } from '../../types/message-types.js';
import type { NotificationsCreationData } from '../../types/notif-types.js'; import type { NotificationsCreationData } from '../../types/notif-types.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { RawThreadInfos } from '../../types/thread-types.js';
export type ProcessDMOperationUtilities = { export type ProcessDMOperationUtilities = {
// Needed to fetch sidebar source messages // Needed to fetch sidebar source messages
+fetchMessage: (messageID: string) => Promise<?RawMessageInfo>, +fetchMessage: (messageID: string) => Promise<?RawMessageInfo>,
+threadInfos: RawThreadInfos, +threadInfos: RawThreadInfos,
+entryInfos: RawEntryInfos,
}; };
export type DMOperationSpec<DMOp: DMOperation> = { export type DMOperationSpec<DMOp: DMOperation> = {
+notificationsCreationData?: ( +notificationsCreationData?: (
dmOp: DMOp, dmOp: DMOp,
utilities: ProcessDMOperationUtilities, utilities: ProcessDMOperationUtilities,
) => Promise<NotificationsCreationData>, ) => Promise<NotificationsCreationData>,
+processDMOperation: ( +processDMOperation: (
Show All 18 Lines
View Options

lib/shared/dm-ops/process-dm-ops.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines