Page MenuHomePhabricator
Differential D13346

[lib] extend ProcessDMOperationUtilities to include entryInfos
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:27 AM.
Tags
None
Referenced Files
F4930394: D13346.id44202.diff
Mon, Mar 17, 8:45 AM
Unknown Object (File)
Sat, Mar 15, 1:04 AM
Unknown Object (File)
Fri, Mar 14, 6:13 AM
Unknown Object (File)
Fri, Mar 14, 5:49 AM
Unknown Object (File)
Tue, Mar 11, 7:13 AM
Unknown Object (File)
Fri, Mar 7, 7:30 AM
Unknown Object (File)
Mon, Mar 3, 10:22 AM
Unknown Object (File)
Fri, Feb 28, 5:25 AM
View All 88 Files
Subscribers
None

Details

Reviewers
marcin
ashoat
tomek
Commits
rCOMM574b46ee991d: [lib] extend ProcessDMOperationUtilities to include entryInfos
Summary

This extends utilities to include entryInfos. I use this later when checking timestamps

Depends on D13345

Test Plan

Was able to use this later in the stack by accessing entry infos for a given entryID

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
4 lines

Diff 44252

View Options

lib/shared/dm-ops/dm-op-spec.js

Show First 20 Lines • Show All 879 Lines • ▼ Show 20 Lines): Promise<$ReadOnlyArray<RawMessageInfo>> {
if (resultRows.length === 0) { if (resultRows.length === 0) {
return []; return [];
} }
const SQLResult = await parseMessageSQLResult(resultRows, messages, viewer); const SQLResult = await parseMessageSQLResult(resultRows, messages, viewer);
return SQLResult.map(item => item.rawMessageInfo); return SQLResult.map(item => item.rawMessageInfo);
} }
async function rawMessageInfoForRowsAndRelatedMessages(
rows: $ReadOnlyArray<Object>,
viewer?: Viewer,
): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<
string,
RawComposableMessageInfo | RawRobotextMessageInfo,
>();
for (const message of parsedResults) {
const { rawMessageInfo } = message;
if (
rawMessageInfo.type === messageTypes.SIDEBAR_SOURCE ||
rawMessageInfo.type === messageTypes.REACTION ||
rawMessageInfo.type === messageTypes.EDIT_MESSAGE
) {
continue;
}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}
const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(
viewer,
rawMessageInfoMap,
);
return [...rawMessageInfos, ...rawRelatedMessageInfos];
}
export { export {
fetchCollapsableNotifs, fetchCollapsableNotifs,
fetchMessageInfos, fetchMessageInfos,
fetchMessageInfosSince, fetchMessageInfosSince,
getMessageFetchResultFromRedisMessages, getMessageFetchResultFromRedisMessages,
fetchMessageInfoForLocalID, fetchMessageInfoForLocalID,
fetchMessageInfoForEntryAction, fetchMessageInfoForEntryAction,
fetchMessageInfoByID, fetchMessageInfoByID,
fetchThreadMessagesCount, fetchThreadMessagesCount,
fetchLatestEditMessageContentByID, fetchLatestEditMessageContentByID,
fetchPinnedMessageInfos, fetchPinnedMessageInfos,
fetchRelatedMessages, fetchRelatedMessages,
rawMessageInfoForRowsAndRelatedMessages,
}; };
View Options

lib/shared/dm-ops/process-dm-ops.js

Show First 20 Lines • Show All 879 Lines • ▼ Show 20 Lines): Promise<$ReadOnlyArray<RawMessageInfo>> {
if (resultRows.length === 0) { if (resultRows.length === 0) {
return []; return [];
} }
const SQLResult = await parseMessageSQLResult(resultRows, messages, viewer); const SQLResult = await parseMessageSQLResult(resultRows, messages, viewer);
return SQLResult.map(item => item.rawMessageInfo); return SQLResult.map(item => item.rawMessageInfo);
} }
async function rawMessageInfoForRowsAndRelatedMessages(
rows: $ReadOnlyArray<Object>,
viewer?: Viewer,
): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<
string,
RawComposableMessageInfo | RawRobotextMessageInfo,
>();
for (const message of parsedResults) {
const { rawMessageInfo } = message;
if (
rawMessageInfo.type === messageTypes.SIDEBAR_SOURCE ||
rawMessageInfo.type === messageTypes.REACTION ||
rawMessageInfo.type === messageTypes.EDIT_MESSAGE
) {
continue;
}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}
const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(
viewer,
rawMessageInfoMap,
);
return [...rawMessageInfos, ...rawRelatedMessageInfos];
}
export { export {
fetchCollapsableNotifs, fetchCollapsableNotifs,
fetchMessageInfos, fetchMessageInfos,
fetchMessageInfosSince, fetchMessageInfosSince,
getMessageFetchResultFromRedisMessages, getMessageFetchResultFromRedisMessages,
fetchMessageInfoForLocalID, fetchMessageInfoForLocalID,
fetchMessageInfoForEntryAction, fetchMessageInfoForEntryAction,
fetchMessageInfoByID, fetchMessageInfoByID,
fetchThreadMessagesCount, fetchThreadMessagesCount,
fetchLatestEditMessageContentByID, fetchLatestEditMessageContentByID,
fetchPinnedMessageInfos, fetchPinnedMessageInfos,
fetchRelatedMessages, fetchRelatedMessages,
rawMessageInfoForRowsAndRelatedMessages,
}; };