Page MenuHomePhabricator

[native] get farcaster avatar selection working from profile
AbandonedPublic

Authored by varun on Aug 15 2024, 10:54 PM.
Tags
None
Referenced Files
F3197220: D13102.id43423.diff
Sat, Nov 9, 7:46 AM
F3188632: D13102.id43423.diff
Fri, Nov 8, 7:02 PM
F3188603: D13102.diff
Fri, Nov 8, 7:01 PM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Thu, Nov 7, 12:02 PM
Unknown Object (File)
Tue, Oct 22, 1:18 PM
Unknown Object (File)
Oct 8 2024, 11:06 PM
Unknown Object (File)
Oct 3 2024, 5:10 AM
Subscribers

Details

Reviewers
ashoat
tomek
Summary

Depends on D13101

Test Plan

successfully changed avatar to a farcaster avatar from profile screen. was able to reset to default after.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun held this revision as a draft.
varun published this revision for review.Aug 19 2024, 7:23 AM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
ashoat requested changes to this revision.Aug 20 2024, 12:42 PM

I don't understand this diff and what it's doing... I suspect that it has to do with one of the preceding diffs that are still in draft state.

Can you:

  1. Re-request review once the whole stack is ready
  2. Add a diff description
lib/hooks/fc-cache.js
162 ↗(On Diff #43423)

Looks like a change that should be in another diff, but the other diff appears to be in draft form still?

This revision now requires changes to proceed.Aug 20 2024, 12:42 PM