[lib] Add action type for processing holders
Needs RevisionPublic
Actions

Authored by bartek on Fri, Sep 20, 6:21 AM.

Details

Reviewers

kamil
tomek

Summary

Added action types and updated reducer for the "process holders" action.

Holders are marked as PENDING_ESTABLISHMENT or PENDING_REMOVAL, before making Blob calls
Afterwards they're either removed or marked as ESTABLISHED.
In case of failure, all of them are marked as NOT_ESTABLISHED / NOT_REMOVED. This will be then handled by a handler component (introduced later) for retrying.

Depends on D13403

Test Plan

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

bartek published this revision for review.Fri, Sep 20, 6:43 AM

lib/actions/holder-actions.js
14–23	Why aren't these types read-only?

kamil requested changes to this revision.Fri, Sep 20, 8:16 AM

kamil added inline comments.

lib/actions/holder-actions.js
3–4
7	nit: I would remove `StoreEstablishedHolderPayload` and use `BlobHashAndHolder` directly
14–23
lib/reducers/holder-reducer.js
63	I think we should change this, update `PROCESS_HOLDERS_FAILED` to have failed hashes as payload (similar as here) and only those mark as failed. Additionally wondering, if we really need `pending` states after this.