This will be handy in the next diff to avoid calling await getSigningPublicKey() for each holder. Made the function sync again
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/utils/blob-service.js | ||
---|---|---|
70–71 ↗ | (On Diff #44379) | Flow complained otherwise |
Comment Actions
Accepting but wondering, looking at the next diff, can't we just pass deviceID as a param to generateBlobHolder (it could be retrieved from getAuthMetadata)? Seems cleaner to me but not feeling strongly.
Separately, this reminds me of ENG-8192.