Page MenuHomePhabricator

[lib] Let blob holder generator take deviceID as argument
ClosedPublic

Authored by bartek on Sep 20 2024, 6:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:37 AM
Unknown Object (File)
Tue, Oct 22, 10:40 AM
Unknown Object (File)
Tue, Oct 22, 10:22 AM
Unknown Object (File)
Tue, Oct 22, 10:22 AM
Unknown Object (File)
Sun, Oct 20, 7:14 PM
Unknown Object (File)
Tue, Oct 15, 9:57 AM
Unknown Object (File)
Mon, Oct 14, 12:44 PM
Unknown Object (File)
Mon, Oct 14, 12:43 PM
Subscribers

Details

Summary

This will be handy in the next diff to avoid calling await getSigningPublicKey() for each holder. Made the function sync again

Test Plan

Repeated plan from D13401

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 20 2024, 6:51 AM
bartek added inline comments.
lib/utils/blob-service.js
70–71 ↗(On Diff #44379)

Flow complained otherwise

Accepting but wondering, looking at the next diff, can't we just pass deviceID as a param to generateBlobHolder (it could be retrieved from getAuthMetadata)? Seems cleaner to me but not feeling strongly.

Separately, this reminds me of ENG-8192.

This revision is now accepted and ready to land.Sep 20 2024, 8:25 AM

Updated function to take deviceID as argument

bartek retitled this revision from [lib] Make blob holder generator a higher order function to [lib] Let blob holder generator take deviceID as argument.Sep 23 2024, 5:04 AM
bartek edited the summary of this revision. (Show Details)