Page MenuHomePhabricator
Differential D13410

[lib] Let blob holder generator take deviceID as argument
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 6:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 7:14 AM
Unknown Object (File)
Mon, Nov 25, 10:16 PM
Unknown Object (File)
Mon, Nov 25, 9:12 PM
Unknown Object (File)
Nov 22 2024, 11:38 AM
Unknown Object (File)
Nov 22 2024, 10:24 AM
Unknown Object (File)
Nov 22 2024, 6:13 AM
Unknown Object (File)
Nov 20 2024, 10:36 AM
Unknown Object (File)
Nov 20 2024, 10:36 AM
View All 62 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMMa5b81199539a: [lib] Let blob holder generator take deviceID as argument
Summary

This will be handy in the next diff to avoid calling await getSigningPublicKey() for each holder. Made the function sync again

Test Plan

Repeated plan from D13401

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 20 2024, 6:25 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 6:25 AM
bartek added a child revision: D13411: [lib] Process blob holders in DM ops.Sep 20 2024, 6:30 AM
Harbormaster failed remote builds in B31739: Diff 44373!Sep 20 2024, 6:43 AM
bartek updated this revision to Diff 44379.Sep 20 2024, 6:47 AM

Add type annotation

bartek published this revision for review.Sep 20 2024, 6:51 AM
bartek added inline comments.
lib/utils/blob-service.js
70–71 ↗(On Diff #44379)

Flow complained otherwise

bartek updated this revision to Diff 44382.Sep 20 2024, 6:56 AM

Flow

Harbormaster failed remote builds in B31743: Diff 44379!Sep 20 2024, 7:04 AM
Harbormaster completed remote builds in B31746: Diff 44382.Sep 20 2024, 7:16 AM
kamil accepted this revision.Sep 20 2024, 8:25 AM

Accepting but wondering, looking at the next diff, can't we just pass deviceID as a param to generateBlobHolder (it could be retrieved from getAuthMetadata)? Seems cleaner to me but not feeling strongly.

Separately, this reminds me of ENG-8192.

This revision is now accepted and ready to land.Sep 20 2024, 8:25 AM
bartek updated this revision to Diff 44416.Sep 23 2024, 5:03 AM

Updated function to take deviceID as argument

bartek retitled this revision from [lib] Make blob holder generator a higher order function to [lib] Let blob holder generator take deviceID as argument.Sep 23 2024, 5:04 AM
bartek edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B31769: Diff 44416.Sep 23 2024, 5:19 AM
Closed by commit rCOMMa5b81199539a: [lib] Let blob holder generator take deviceID as argument (authored by bartek). · Explain WhySep 23 2024, 7:25 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMa5b81199539a: [lib] Let blob holder generator take deviceID as argument.

Revision Contents
Changeset List

PathSize
lib/
utils/
12 lines

Diff 44382

View Options

lib/utils/blob-service.js

Loading...