Page MenuHomePhabricator
Differential D13456

[web] display farcaster avatar when it's set
ClosedPublic
Actions

Authored by varun on Tue, Sep 24, 3:25 PM.
Tags
None
Referenced Files
F2842550: D13456.id44551.diff
Sun, Sep 29, 2:37 PM
F2842546: D13456.id44520.diff
Sun, Sep 29, 2:34 PM
F2842205: D13456.diff
Sun, Sep 29, 12:32 PM
F2842097: D13456.diff
Sun, Sep 29, 12:02 PM
F2838551: D13456.diff
Sat, Sep 28, 10:33 PM
Unknown Object (File)
Sat, Sep 28, 12:20 PM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set
Summary

in D13380 I made it possible to set a farcaster avatar from web. however after refactoring D13101, we won't actually display this avatar from the settings page when it's set without the changes in this diff

Depends on D13381

Test Plan

tested by setting and unsetting all avatar types from settings page on web

Diff Detail

Repository
rCOMM Comm
Branch
farcaster-avatgar (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Tue, Sep 24, 3:25 PM
Harbormaster completed remote builds in B31834: Diff 44520.Tue, Sep 24, 3:42 PM
varun requested review of this revision.Tue, Sep 24, 3:42 PM
ashoat accepted this revision.Tue, Sep 24, 5:39 PM

Unclear why D13101 did this for native and not for web. That diff could've probably been broken up more

This revision is now accepted and ready to land.Tue, Sep 24, 5:39 PM
Closed by commit rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set (authored by varun). · Explain WhyWed, Sep 25, 7:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set.

Revision Contents
Changeset List

PathSize
web/
avatars/
27 lines

Diff 44520

View Options

web/avatars/user-avatar.react.js

Loading...