Page MenuHomePhabricator
Differential D13550

[web] Hide members option in ThreadMenu for all private and personal threads
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 10:10 PM.
Tags
None
Referenced Files
F3311464: D13550.id44731.diff
Tue, Nov 19, 8:52 AM
Unknown Object (File)
Sun, Nov 10, 4:19 PM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 8, 3:01 AM
Unknown Object (File)
Fri, Nov 1, 4:46 PM
Unknown Object (File)
Fri, Nov 1, 12:03 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Wed, Oct 30, 11:45 PM
View All 32 Files
Subscribers
None

Details

Reviewers
tomek
kamil
inka
Commits
rCOMM068cfc52f2d2: [web] Hide members option in ThreadMenu for all private and personal threads
Summary

We currently only hide this menu option for threadTypes.GENESIS_PERSONAL. I think we should match behavior for threadTypes.PERSONAL, and I also figure we can hide the menu option for private threads too (threadTypes.PRIVATE and threadTypes.GENESIS_PRIVATE, which are for a user chatting with themselves).

Depends on D13549

Test Plan

Confirm that members options doesn't appear in ThreadMenu on web when viewing a PRIVATE thread

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
chat/
8 lines

Diff 44731

View Options

web/chat/thread-menu.react.js

Loading...