Page MenuHomePhabricator

[tunnelbroker] Add error listener for AMQP
ClosedPublic

Authored by bartek on Oct 3 2024, 8:40 AM.
Tags
None
Referenced Files
F3341121: D13593.id44871.diff
Thu, Nov 21, 10:32 PM
F3341060: D13593.id44928.diff
Thu, Nov 21, 10:30 PM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 1:09 PM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:49 PM
Unknown Object (File)
Fri, Nov 1, 2:08 AM
Unknown Object (File)
Wed, Oct 30, 6:56 PM
Subscribers

Details

Summary

By default, lapin error logs are out of our control, on a separate thread, in library internal code.
This handler lets us print them with our errorType.

NOTE: This might cause increased alarm count for TB. In the future we want to filter them here.

Depends on D13592

Test Plan

Disconnected rabbitmq while tunnelbroker running. Error log appeared about IOError

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Oct 3 2024, 8:59 AM
bartek added inline comments.
services/tunnelbroker/src/amqp.rs
28–31

This might cause increased alarm count for TB. In the future we want to filter them here.

Tunnelbroker logs have these anyways, but they're inside lapin code and have no errorType assigned so they don't trigger alarms

services/tunnelbroker/src/websockets/session.rs
687

Noticed this is about WS, not AMQP - self.tx is a Websocket transmitter

This revision is now accepted and ready to land.Oct 3 2024, 9:10 AM
This revision was automatically updated to reflect the committed changes.