[tunnelbroker] Recover AMQP before publishing messages
ClosedPublic
Actions

Authored by bartek on Oct 4 2024, 3:38 AM.

Details

Reviewers

kamil
will
varun

Commits

rCOMM51a32d2cff2a: [tunnelbroker] Recover AMQP before publishing messages

Summary

Similiar to D13607 (recover when session is closing) and D13606 (consumer is broken).
Before publishing, check channel state and recover if needed. Eventually propagate error if both fail.

Depends on D13609

Test Plan

Tested on staging with the rest of the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 4 2024, 3:38 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 4 2024, 3:38 AM

Harbormaster completed remote builds in B32066: Diff 44897.Oct 4 2024, 3:54 AM

bartek published this revision for review.Oct 4 2024, 4:10 AM

bartek edited the summary of this revision. (Show Details)Oct 4 2024, 8:21 AM

bartek edited the test plan for this revision. (Show Details)

bartek added a parent revision: D13609: [tunnelbroker] Remove legacy AMQP connect function.

bartek removed a parent revision: D13610: [tunnelbroker] Recreate closed channels in pool.

bartek added a child revision: D13621: [tunnelbroker] Implement lazy AMQP channel wrapper.Oct 6 2024, 11:51 PM

kamil accepted this revision.Oct 7 2024, 2:25 AM

This revision is now accepted and ready to land.Oct 7 2024, 2:25 AM

Closed by commit rCOMM51a32d2cff2a: [tunnelbroker] Recover AMQP before publishing messages (authored by bartek). · Explain WhyOct 7 2024, 7:29 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM51a32d2cff2a: [tunnelbroker] Recover AMQP before publishing messages.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

websockets/

session.rs

35 lines

Diff 44897

View Options

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] Recover AMQP before publishing messagesClosedPublicActions