[tunnelbroker] Add error listener for AMQP
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 8:40 AM.

Details

Reviewers

kamil
varun
will

Commits

rCOMM00711bae56c2: [tunnelbroker] Add error listener for AMQP

Summary

By default, lapin error logs are out of our control, on a separate thread, in library internal code.
This handler lets us print them with our errorType.

NOTE: This might cause increased alarm count for TB. In the future we want to filter them here.

Depends on D13592

Test Plan

Disconnected rabbitmq while tunnelbroker running. Error log appeared about IOError

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 3 2024, 8:40 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 8:40 AM

bartek added a child revision: D13594: [tunnelbroker] Add exponential backoff to AMQP connection.Oct 3 2024, 8:42 AM

Harbormaster completed remote builds in B32044: Diff 44871.Oct 3 2024, 8:56 AM

bartek published this revision for review.Oct 3 2024, 8:59 AM

bartek added inline comments.

services/tunnelbroker/src/amqp.rs
28–31 ↗	(On Diff #44871)	This might cause increased alarm count for TB. In the future we want to filter them here. Tunnelbroker logs have these anyways, but they're inside `lapin` code and have no `errorType` assigned so they don't trigger alarms
services/tunnelbroker/src/websockets/session.rs
687 ↗	(On Diff #44871)	Noticed this is about WS, not AMQP - `self.tx` is a Websocket transmitter