Page MenuHomePhabricator

[native] Update the QR login screen to mention the primary device
ClosedPublic

Authored by tomek on Nov 15 2024, 10:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:46 AM
Unknown Object (File)
Wed, Dec 18, 10:44 PM
Unknown Object (File)
Mon, Dec 16, 1:59 PM
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Mon, Dec 16, 2:04 AM
Unknown Object (File)
Sat, Dec 14, 8:24 PM
Unknown Object (File)
Sat, Dec 14, 8:21 PM
Subscribers

Details

Summary

The result of a discussion from D13906.

D13946.png (2×1 px, 143 KB)

Depends on D14052

Test Plan

Opened the QR screen and checked if it looks correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
native/qr-code/qr-code-screen.react.js
57 ↗(On Diff #45844)

I'm wondering if we should tell the user what a primary device is e.g. during the NUX. We could say something like "This is your primary device and you have to use it in order to log in on more devices".

native/qr-code/qr-code-screen.react.js
57 ↗(On Diff #45844)

Hmm... I wonder if this is too confusing to explain to most users, given most users only have a single phone.

In D13906 I suggested either "logged-in phone" or "primary device", but now I'm wondering if "other phone" would be best.

This would be extra confusing for users with 3 phones, but that has to be a tiny percentage of users...

96 ↗(On Diff #45844)

Can we add some paddingHorizontal here? I think it's a bit weird how close the text comes to the edge of the screen, and it doesn't look very good to have a second line with a single word

(As an alternative to paddingHorizontal, we could consider setting an explicit width)

kamil added a reviewer: ashoat.

There is some discussion about user-facing language so probably @ashoat should do the final review

native/qr-code/qr-code-screen.react.js
57 ↗(On Diff #45844)

For me, if I was the user, the "logged-in phone" term seems best

ashoat requested changes to this revision.Nov 19 2024, 3:58 AM

Passing to @tomek's queue

This revision now requires changes to proceed.Nov 19 2024, 3:58 AM
native/qr-code/qr-code-screen.react.js
57 ↗(On Diff #45844)

other phone might be confusing for the users who have only one phone. They might be wondering what's wrong with this phone so that they can't use it for login and why they need two phones. I think that logged-in phone is probably the best because it also explains that if they don't have a logged-in phone, they should use the other option.

native/qr-code/qr-code-screen.react.js
96 ↗(On Diff #45844)

I think it makes sense to keep it consistent with the instructionsBox and assign a fixed width

Update the copy and the width

This revision is now accepted and ready to land.Mon, Nov 25, 8:28 AM