[keyserver] remove duplicate content-type application/json header in call to assignBlobHolder
ClosedPublic
Actions

Authored by will on Fri, Dec 6, 5:46 PM.

Details

Reviewers

varun
bartek
ashoat

Commits

rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to…

Summary

Remove duplicate content type header in assign blob holder request to blob service.

In testing my farcaster bot, calls to createOrUpdatePublicLink were failing as it would eventually call assignBlobHolder with two duplicate content-type headers, resulting in a 400 Bad Request from the blob service.

We can fix this by specifying createRequestHeaders's includeContentType parameter as false

Linear Issue: https://linear.app/comm/issue/ENG-9986/running-into-an-issue-of-createorupdatepubliclink-failing-to-upload-a

Test Plan

In applying this change, the farcaster bot properly was able to upload invite link blobs without errors

Diff Detail

Repository

rCOMM Comm

Branch

fix_blob_assign_holder

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Fri, Dec 6, 5:46 PM

Herald added a subscriber: tomek. · View Herald TranscriptFri, Dec 6, 5:46 PM

will retitled this revision from [keyserver] remove duplicate content-type application/json header in call to assign blob holder to [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder.Fri, Dec 6, 5:56 PM

will retitled this revision from [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder to [keyserver] remove duplicate content-type application/json header in assignBlobHolder.

will retitled this revision from [keyserver] remove duplicate content-type application/json header in assignBlobHolder to [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder.

Harbormaster completed remote builds in B32953: Diff 46247.Fri, Dec 6, 6:05 PM

will requested review of this revision.Fri, Dec 6, 6:05 PM

will added a child revision: D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.Fri, Dec 6, 6:40 PM

will edited the summary of this revision. (Show Details)Fri, Dec 6, 6:47 PM

ashoat accepted this revision.Fri, Dec 6, 6:53 PM

This revision is now accepted and ready to land.Fri, Dec 6, 6:53 PM

Closed by commit rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to… (authored by will). · Explain WhyFri, Dec 6, 8:47 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to….