Page MenuHomePhabricator
Differential D13999

[keyserver] use default channel cover image stored on in keyserver/images in frame
ClosedPublic
Actions

Authored by will on Nov 21 2024, 11:37 PM.
Tags
None
Referenced Files
F6240542: D13999.diff
Thu, Apr 24, 11:02 PM
Unknown Object (File)
Wed, Apr 2, 11:38 AM
Unknown Object (File)
Tue, Apr 1, 9:32 AM
Unknown Object (File)
Mon, Mar 31, 4:43 AM
Unknown Object (File)
Mar 24 2025, 2:33 PM
Unknown Object (File)
Mar 23 2025, 2:42 PM
Unknown Object (File)
Mar 22 2025, 3:06 PM
Unknown Object (File)
Mar 11 2025, 3:47 PM
View All 37 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM406616992f71: [keyserver] use default channel cover image stored on in keyserver/images in…
Summary

Instead of using the link to the warpcast's default channel cover image, we store it on the keyserver and serve it at a frog hono route to be used by the frame's `<img /> JSX element as the src

Depends on D13998

Test Plan

Verified on the warpcast frame validator and confirmed that specifying a channel with no custom channel cover still resolved to the same default cover image

image.png (960×1 px, 439 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Nov 21 2024, 11:37 PM
Herald added a subscriber: tomek. · View Herald TranscriptNov 21 2024, 11:37 PM
will edited the test plan for this revision. (Show Details)Nov 21 2024, 11:37 PM
will edited the test plan for this revision. (Show Details)
will edited the summary of this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B32760: Diff 45936.Nov 21 2024, 11:53 PM
will requested review of this revision.Nov 21 2024, 11:53 PM
ashoat accepted this revision.Nov 23 2024, 6:35 AM
ashoat added inline comments.
keyserver/flow-typed/npm/hono_vx.x.x.js
11 ↗(On Diff #45936)

Weird that you're naming one parameter but not the other

12 ↗(On Diff #45936)

Are you sure it returns void? If you're just saying that because our usage doesn't care about the return value, then we should say mixed. But if you're sure it's void (eg. from TS types) that's fine

This revision is now accepted and ready to land.Nov 23 2024, 6:35 AM
will added a child revision: D14057: latest.Nov 27 2024, 6:47 AM
will added a child revision: D14086: [keyserver] setup reverse proxy from keyserver router to frog hono server.Dec 5 2024, 11:29 PM
will added inline comments.Dec 6 2024, 7:33 PM
keyserver/flow-typed/npm/hono_vx.x.x.js
12 ↗(On Diff #45936)

Took a look at the TS types and this should be mixed

will updated this revision to Diff 46252.Dec 6 2024, 7:33 PM

feedback

will marked an inline comment as done.Dec 6 2024, 7:33 PM
Harbormaster completed remote builds in B32958: Diff 46252.Dec 6 2024, 7:51 PM
will removed a child revision: D14057: latest.Dec 7 2024, 8:48 AM
Closed by commit rCOMM406616992f71: [keyserver] use default channel cover image stored on in keyserver/images in… (authored by will). · Explain WhyDec 9 2024, 4:56 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM406616992f71: [keyserver] use default channel cover image stored on in keyserver/images in….

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
@hono/
12 lines
2 lines
15 lines
images/
src/
frog/
10 lines

Diff 46252

View Options

keyserver/flow-typed/npm/@hono/node-server_vx.x.x.js

Show All 23 Linesimport {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { getConfig, registerConfig } from 'lib/utils/config.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import { getDatabaseModule } from './database/database-module-provider.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
import UpdateModalHandler from './modals/update-modal.react.js'; import UpdateModalHandler from './modals/update-modal.react.js';
import SettingsSwitcher from './navigation-panels/settings-switcher.react.js'; import SettingsSwitcher from './navigation-panels/settings-switcher.react.js';
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 LinesregisterConfig({
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 63, codeVersion: 63,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
...desktopDetails, ...desktopDetails,
}, },
}); });
const versionBroadcast = new BroadcastChannel('comm_version');
versionBroadcast.postMessage(getConfig().platformDetails.codeVersion);
versionBroadcast.onmessage = (event: MessageEvent) => {
if (event.data && event.data !== getConfig().platformDetails.codeVersion) {
location.reload();
}
};
// Start initializing the database immediately
void getDatabaseModule();
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines
View Options

keyserver/flow-typed/npm/frog_v0.18.x.js

Show All 23 Linesimport {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { getConfig, registerConfig } from 'lib/utils/config.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import { getDatabaseModule } from './database/database-module-provider.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
import UpdateModalHandler from './modals/update-modal.react.js'; import UpdateModalHandler from './modals/update-modal.react.js';
import SettingsSwitcher from './navigation-panels/settings-switcher.react.js'; import SettingsSwitcher from './navigation-panels/settings-switcher.react.js';
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 LinesregisterConfig({
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 63, codeVersion: 63,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
...desktopDetails, ...desktopDetails,
}, },
}); });
const versionBroadcast = new BroadcastChannel('comm_version');
versionBroadcast.postMessage(getConfig().platformDetails.codeVersion);
versionBroadcast.onmessage = (event: MessageEvent) => {
if (event.data && event.data !== getConfig().platformDetails.codeVersion) {
location.reload();
}
};
// Start initializing the database immediately
void getDatabaseModule();
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines
View Options

keyserver/flow-typed/npm/hono_vx.x.x.js

Show All 23 Linesimport {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { getConfig, registerConfig } from 'lib/utils/config.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import { getDatabaseModule } from './database/database-module-provider.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
import UpdateModalHandler from './modals/update-modal.react.js'; import UpdateModalHandler from './modals/update-modal.react.js';
import SettingsSwitcher from './navigation-panels/settings-switcher.react.js'; import SettingsSwitcher from './navigation-panels/settings-switcher.react.js';
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 LinesregisterConfig({
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 63, codeVersion: 63,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
...desktopDetails, ...desktopDetails,
}, },
}); });
const versionBroadcast = new BroadcastChannel('comm_version');
versionBroadcast.postMessage(getConfig().platformDetails.codeVersion);
versionBroadcast.onmessage = (event: MessageEvent) => {
if (event.data && event.data !== getConfig().platformDetails.codeVersion) {
location.reload();
}
};
// Start initializing the database immediately
void getDatabaseModule();
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines
View Options

keyserver/images/default_farcaster_channel_cover.png

Show All 23 Linesimport {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { getConfig, registerConfig } from 'lib/utils/config.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import { getDatabaseModule } from './database/database-module-provider.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
import UpdateModalHandler from './modals/update-modal.react.js'; import UpdateModalHandler from './modals/update-modal.react.js';
import SettingsSwitcher from './navigation-panels/settings-switcher.react.js'; import SettingsSwitcher from './navigation-panels/settings-switcher.react.js';
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 LinesregisterConfig({
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 63, codeVersion: 63,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
...desktopDetails, ...desktopDetails,
}, },
}); });
const versionBroadcast = new BroadcastChannel('comm_version');
versionBroadcast.postMessage(getConfig().platformDetails.codeVersion);
versionBroadcast.onmessage = (event: MessageEvent) => {
if (event.data && event.data !== getConfig().platformDetails.codeVersion) {
location.reload();
}
};
// Start initializing the database immediately
void getDatabaseModule();
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines
View Options

keyserver/src/frog/frog.js

Loading...