Page MenuHomePhabricator

[keyserver] implement invite link button to frog hono route
ClosedPublic

Authored by will on Nov 19 2024, 9:51 PM.
Tags
None
Referenced Files
F3512904: D13971.diff
Sat, Dec 21, 8:53 PM
Unknown Object (File)
Mon, Dec 16, 12:20 PM
Unknown Object (File)
Tue, Dec 10, 8:52 PM
Unknown Object (File)
Sat, Nov 30, 1:48 PM
Unknown Object (File)
Sat, Nov 30, 2:15 AM
Unknown Object (File)
Thu, Nov 28, 12:06 AM
Unknown Object (File)
Tue, Nov 26, 8:39 AM
Unknown Object (File)
Tue, Nov 26, 5:39 AM
Subscribers

Details

Summary

This implements the invite link button in the frame. We take a invite link parameter in the route. The button will redirect to this link

We also check if the invite link parameter is a valid Comm invite link by checking if it is prefixed by https://comm.app/invite/. If not, we default to https://comm.app

Depends on D13947

Test Plan

Used the warpcast frame validator https://warpcast.com/~/developers to display the frame and confirmed button redirected to invite link provided as the parameter with the following url in the warpcast frame validator: https://<keyserver url>/https%3A%2F%2Fcomm.app%2Finvite%2Fcryptoleft

Used a different link than a Comm link as a parameter and confirmed it still defaults to https://comm.app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/flow-typed/npm/frog_v0.18.x.js
12–18 ↗(On Diff #45893)

We won't actually be using a regular Button here. For our frame work, we'll end up using only variants like Button.Link

keyserver/src/frog/frog.js
18 ↗(On Diff #45893)

Had the invite link button default to the Comm homepage. We could also fail to respond with a frame or use a different default link like the Comm download page

will requested review of this revision.Nov 19 2024, 10:08 PM
ashoat added inline comments.
keyserver/flow-typed/npm/frog_v0.18.x.js
15–16 ↗(On Diff #45893)

Are you sure these are the only two props on this component? If not, use ...

18 ↗(On Diff #45893)

You should be using ... to indicate there are other properties that you haven't typed. Please make sure you grok the types you're using here... you shouldn't be putting up diffs like D13947 if there are lines (like ...) that you don't understand

This revision is now accepted and ready to land.Nov 20 2024, 4:20 AM
will marked 2 inline comments as done.Fri, Dec 6, 7:02 PM