Paths

Table of Contentst

Differential D14090

[native] Navigate to a SIWE backup screen
ClosedPublic
Actions

Authored by tomek on Dec 6 2024, 5:37 PM.

Tags

None

Referenced Files

	F3482947: full-restore-siwe.mov
	Dec 17 2024, 3:33 PM

Subscribers

Details

Reviewers

kamil
bartek

Commits

rCOMM609f9084992c: [native] Navigate to a SIWE backup screen

Summary

After successful login a user should be redirected to sign a backup

https://linear.app/comm/issue/ENG-8203/implement-navigation-flow-for-new-siwe-log-in

Depends on D14164

Test Plan

Connect the wallet using restore flow. The user should get navigated to the new screen.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Dec 6 2024, 5:37 PM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2024, 5:37 PM

Harbormaster completed remote builds in B32952: Diff 46246.Dec 6 2024, 5:55 PM

tomek requested review of this revision.Dec 6 2024, 5:55 PM

Rebase

Harbormaster completed remote builds in B32983: Diff 46289.Dec 10 2024, 3:22 PM

tomek edited the summary of this revision. (Show Details)Dec 17 2024, 3:30 PM

tomek edited the test plan for this revision. (Show Details)

tomek added a parent revision: D14164: [native] Update the SIWE backup restore screen.

tomek removed a parent revision: D14085: [native] Render SIWE restore panel.

Rebase and update the approach

tomek edited the summary of this revision. (Show Details)Dec 17 2024, 3:33 PM

tomek added a child revision: D14165: [native] Perform the backup restoration.Dec 17 2024, 3:36 PM

Harbormaster completed remote builds in B33166: Diff 46557.Dec 17 2024, 3:58 PM

Remove a button from the backup menu

kamil accepted this revision.Dec 19 2024, 11:28 AM

kamil added inline comments.

native/account/restore-prompt-screen.react.js
82 ↗	(On Diff #46557)	nit: we can remove `useCallback` now
104 ↗	(On Diff #46557)	This is something we need to update as part of removing social proof refresh during restore but for now looks good
native/profile/backup-menu.react.js
229 ↗	(On Diff #46557)	This will be removed I think

This revision is now accepted and ready to land.Dec 19 2024, 11:28 AM

tomek mentioned this in D14164: [native] Update the SIWE backup restore screen.Dec 19 2024, 11:30 AM

Shorthand

Harbormaster completed remote builds in B33181: Diff 46577.Dec 19 2024, 11:46 AM

Harbormaster completed remote builds in B33182: Diff 46578.Dec 19 2024, 11:48 AM

Closed by commit rCOMM609f9084992c: [native] Navigate to a SIWE backup screen. · Explain WhyDec 19 2024, 2:32 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM609f9084992c: [native] Navigate to a SIWE backup screen.

Revision Contents
Changeset List

Path

Size

native/

account/

restore-backup-screen.react.js

3 lines

restore-password-account-screen.react.js

2 lines

restore-prompt-screen.react.js

56 lines

backup/

restore-siwe-backup.react.js

53 lines

profile/

backup-menu.react.js

83 lines

Diff 46586

native/account/restore-backup-screen.react.js

Loading...

native/account/restore-password-account-screen.react.js

Loading...

native/account/restore-prompt-screen.react.js

Loading...

native/backup/restore-siwe-backup.react.js

Loading...

native/profile/backup-menu.react.js

Loading...