In D8648#255012, @patryk wrote:

Please note that the only place where we still use Alert, imported from react-native, is in redux-setup.js. utils/alert.js uses the redux store to determine which theme to use. Attempting to use the alert wrapper prior to store initialization results in a You may not call store.getState() while the reducer is executing error. Although we could bypass this issue by using store.subscribe(variableUpdateCallback), the following reasons underscore why it's not an optimal approach:

1. The variable updates with every redux store update, potentially leading to performance issues.
2. We face a require cycle problem.

You can emulate second reason by changing import in redux-setup.js to our alert wrapper and replacing getCurrentTheme in utils/alert.js with something like this:

// ...
let currentTheme = defaultGlobalThemeInfo.activeTheme;
store.subscribe(() => {
  const nextTheme =
    store.getState().globalThemeInfo.activeTheme ||
    defaultGlobalThemeInfo.activeTheme;
  if (nextTheme !== currentTheme) {
    currentTheme = nextTheme;
  }
});
// Remember to swap all `getCurrentTheme()` occurrences to `currentTheme`
// ...

Minor comments, but please address before landing!

Accepting since my comments are minor, but the one about a potential crash is serious. Please address comments before landing!

Going forward, please make sure I do a final review of docs diffs before they're landed. It's unfortunately the case that my review is still required to get things right...

Minor note – the filename worker-crypto-utlis.test.js has a typo

Regarding @atul's design feedback, I mostly agree with all of it. I'm not sure if it's too late to revise these designs, though... Ted is currently out, and we're trying to land this stack before the end of the month.

The point of this code:

Introduce a new function

Better to handle this in fetchServerThreadInfos, so it can't happen from any callsite

Ended up reviewing an earlier version of the diff, but my comments all apply to the current version as well

Option #2 makes sense to me. The shimmed text isn't really something we should be spending a whole ton of time on

Can you clarify what will happen on older clients when this endpoint returns a ServerError that they aren't aware of?

This code has a lot of issues

Nice!!

Love a good red diff!!

Same feedback as here... best to avoid class and interface if possible. Sometimes they are needed for inheritance reasons, but it doesn't look like it here

Interface is a weird construction in Flow... it's generally best to use type if possible. Is there a strong reason for using interface here?

I haven't reviewed this closely... just leaving some minor notes.

Excited to have this bug resolved!!

New dependency looks good!

Please address these comments before landing. They are repeats from my previous review

In D8527#253676, @tomek wrote:

In D8527#251416, @ashoat wrote:

Can you provide some more context on the selection of this package? I noticed it hasn't been updated in 3 years and has some unaddressed GitHub issues, but I'm guessing your research showed that it's the best option.

It is the most popular NPM package for profanity checks https://www.npmjs.com/search?q=keywords%3Aprofanity&ranking=popularity. Also, the issues on Github aren't serious. The implementation is so simple that it doesn't need frequent updates.

Passing back to @marcin with some requests

Only got through the first file. You still don't understand the feedback I've been repeating on every one of your keyserver diffs. You need to step back and try to understand async/await in JS. Please make sure I don't have to give you this feedback again.

Do it for both Android GitHub workflows

No context on Rust

Update

Oops, sorry about that!!

Can you provide some more context on the selection of this package? I noticed it hasn't been updated in 3 years and has some unaddressed GitHub issues, but I'm guessing your research showed that it's the best option.

Testing small images with normal aspect ratios, to make sure they don't get "zoomed in" to the size of the container, and instead stay the small size

Can you add some more things to the Test Plan?