Page MenuHomePhorge
Feed Search

Mar 25 2024

will committed rCOMM7f4bc14754de: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
Mar 25 2024, 9:10 PM
will committed rCOMM11debc765fb9: [sqlite] Adds integrity store table.
Mar 25 2024, 9:10 PM
will closed D11247: [lib] Add integrity store ops.
Mar 25 2024, 9:10 PM
will committed rCOMM99e116bb3826: [lib] Add integrity store ops.
Mar 25 2024, 9:10 PM
will updated the diff for D11349: [native] migrate integrityStore to SQLite.

rebase

Mar 25 2024, 8:16 PM
will updated the diff for D11247: [lib] Add integrity store ops.

rebase

Mar 25 2024, 8:08 PM
will updated the diff for D11359: [lib] integrity reducer tests.

review feedback

Mar 25 2024, 7:54 PM
will updated the diff for D11359: [lib] integrity reducer tests.

Remove isDefault to pass flow check

Mar 25 2024, 7:40 PM
will retitled D11349: [native] migrate integrityStore to SQLite from [web][native] migrate integrityStore to SQLite
Mar 25 2024, 7:23 PM
will updated the test plan for D11349: [native] migrate integrityStore to SQLite.
Mar 25 2024, 7:22 PM

Mar 22 2024

will accepted D11371: [terraform] use farcaster image on staging.
Mar 22 2024, 1:54 AM

Mar 21 2024

will added inline comments to D11349: [native] migrate integrityStore to SQLite.
Mar 21 2024, 3:59 PM
will updated the diff for D11349: [native] migrate integrityStore to SQLite.

remove web migration

Mar 21 2024, 3:57 PM
will added inline comments to D11349: [native] migrate integrityStore to SQLite.
Mar 21 2024, 4:30 AM

Mar 19 2024

will updated the diff for D11359: [lib] integrity reducer tests.

match style

Mar 19 2024, 10:00 PM
will updated the diff for D11359: [lib] integrity reducer tests.

consts can be moved to specific unit tests

Mar 19 2024, 9:48 PM
will updated the diff for D11247: [lib] Add integrity store ops.

rename ClientDBIntegrityThreadHashesOperation to ClientDBIntegrityStoreOperation for consistency

Mar 19 2024, 8:42 PM
will requested review of D11359: [lib] integrity reducer tests.
Mar 19 2024, 8:22 PM
will requested review of D11358: [native][web] Read integrity thread hashes from SQLite on app start.
Mar 19 2024, 8:18 PM
will requested review of D11357: [native][web] Start processing integrity store with sqlite operations.
Mar 19 2024, 8:15 PM
will updated the diff for D11247: [lib] Add integrity store ops.

add remove to process store ops

Mar 19 2024, 7:58 PM
will requested review of D11349: [native] migrate integrityStore to SQLite.
Mar 19 2024, 4:53 AM
will added inline comments to D11300: [sqlite] add methods to operate on integrity store table.
Mar 19 2024, 4:43 AM
will updated the diff for D11309: [sqlite] implement processing integrity store ops on worker.

rebase

Mar 19 2024, 4:33 AM
will updated the diff for D11307: [sqlite] Implement C++ code to get integrity store thread hashes.

rebase

Mar 19 2024, 4:32 AM
will updated the diff for D11306: [sqlite] implement C++ integrity store ops.

rebase

Mar 19 2024, 4:32 AM
will added inline comments to D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 19 2024, 4:31 AM
will updated the diff for D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.

review feedback

Mar 19 2024, 4:24 AM
will added inline comments to D11300: [sqlite] add methods to operate on integrity store table.
Mar 19 2024, 4:23 AM
will updated the diff for D11300: [sqlite] add methods to operate on integrity store table.

review feedback

Mar 19 2024, 4:19 AM
will added inline comments to D11300: [sqlite] add methods to operate on integrity store table.
Mar 19 2024, 4:18 AM

Mar 18 2024

will updated the summary of D11323: [lib] return ops from integrity store reducer.
Mar 18 2024, 1:40 PM
will updated the summary of D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.
Mar 18 2024, 1:39 PM

Mar 16 2024

will requested review of D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.
Mar 16 2024, 2:18 AM
will updated the diff for D11323: [lib] return ops from integrity store reducer.

refactor for sync state action

Mar 16 2024, 2:03 AM

Mar 15 2024

will updated the diff for D11249: [sqlite] Adds integrity store table.

convert thead hash type to text

Mar 15 2024, 4:40 AM
will updated the diff for D11247: [lib] Add integrity store ops.

review feedback. convert thread_hash to string

Mar 15 2024, 4:38 AM
will planned changes to D11300: [sqlite] add methods to operate on integrity store table.
Mar 15 2024, 4:24 AM

Mar 14 2024

will requested review of D11323: [lib] return ops from integrity store reducer.
Mar 14 2024, 6:43 AM
will requested review of D11322: refactor integrity reducer starting state to use processStoreOps.
Mar 14 2024, 6:42 AM
will updated the summary of D11300: [sqlite] add methods to operate on integrity store table.
Mar 14 2024, 6:37 AM
will updated the summary of D11300: [sqlite] add methods to operate on integrity store table.
Mar 14 2024, 6:37 AM
will planned changes to D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 14 2024, 6:32 AM
will accepted D11305: [terraform] use identity 0.12 on prod.
Mar 14 2024, 2:32 AM
will added a comment to D11305: [terraform] use identity 0.12 on prod.
  1. it's safer. assuming that devs remember to revert to master after testing local changes, we can make sure that things work on staging for a short period before we apply changes to prod. there's no good way to test landed changes for an extended period in the current process without running the risk of a) another dev undoing the changes while testing something on a custom tag or b) the changes being applied prematurely to prod
  2. we can see the delta between staging and prod clearly. before, it was possible for staging to be a few releases ahead of prod without any visibility. this is a good (albeit not perfect) forcing function to make sure we keep prod up to date with staging

lmk what you think. curious for @bartek and @will 's thoughts too

Mar 14 2024, 2:30 AM

Mar 12 2024

will added inline comments to D11247: [lib] Add integrity store ops.
Mar 12 2024, 8:13 PM
will published D11307: [sqlite] Implement C++ code to get integrity store thread hashes for review.
Mar 12 2024, 5:21 AM
will published D11309: [sqlite] implement processing integrity store ops on worker for review.
Mar 12 2024, 5:20 AM
will updated the diff for D11306: [sqlite] implement C++ integrity store ops.

rebase

Mar 12 2024, 4:56 AM

Mar 11 2024

will retitled D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops from [sqlite] [lib] Refactor integrity reducer to process threadStore ops with sqlite ops
Mar 11 2024, 10:11 PM
will retitled D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops from [sqlite] [lib] refactor integrity reducer add new thread hashes to use sqlite ops
Mar 11 2024, 10:11 PM
will retitled D11247: [lib] Add integrity store ops from [sqlite] Add integrity store ops
Mar 11 2024, 10:10 PM
will added a comment to D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.

The reduceIntegrityStore function starts with:

if (
  action.type === logInActionTypes.success ||
  action.type === siweAuthActionTypes.success ||
  action.type === keyserverRegisterActionTypes.success ||
  action.type === fullStateSyncActionType ||
  (action.type === setClientDBStoreActionType &&
    !!action.payload.threadStore &&
    state.threadHashingStatus !== 'completed')
) {
  return { threadHashes: {}, threadHashingStatus: 'starting' };
} else if (action.type === keyserverAuthActionTypes.success) {
  return { ...state, threadHashingStatus: 'starting' };
}
Mar 11 2024, 9:20 PM
will added inline comments to D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 11 2024, 9:18 PM
will updated the summary of D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
Mar 11 2024, 9:05 PM
will updated the summary of D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 11 2024, 9:05 PM
will updated the summary of D11300: [sqlite] add methods to operate on integrity store table.
Mar 11 2024, 9:04 PM
will updated the summary of D11306: [sqlite] implement C++ integrity store ops.
Mar 11 2024, 9:04 PM
will requested review of D11306: [sqlite] implement C++ integrity store ops.
Mar 11 2024, 8:05 PM
will accepted D11305: [terraform] use identity 0.12 on prod.
Mar 11 2024, 7:08 PM
will requested review of D11300: [sqlite] add methods to operate on integrity store table.
Mar 11 2024, 2:15 PM
will requested review of D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.
Mar 11 2024, 2:07 PM
will requested review of D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.
Mar 11 2024, 2:03 PM
will updated the diff for D11249: [sqlite] Adds integrity store table.

build db wasm

Mar 11 2024, 1:27 PM
will updated the diff for D11249: [sqlite] Adds integrity store table.

add _store to create_integrity_table method

Mar 11 2024, 7:38 AM
will updated the diff for D11249: [sqlite] Adds integrity store table.

Update hash to number from text and review feedback

Mar 11 2024, 7:32 AM
will updated the diff for D11247: [lib] Add integrity store ops.

review feedback and add remove operation

Mar 11 2024, 7:30 AM

Mar 7 2024

will added inline comments to D11247: [lib] Add integrity store ops.
Mar 7 2024, 7:57 PM
will updated the summary of D11249: [sqlite] Adds integrity store table.
Mar 7 2024, 7:57 PM
will accepted D11260: [terraform] return to 2 identical identity service instances.
Mar 7 2024, 3:04 AM

Mar 6 2024

will accepted D11256: [identity] replace cache calls with DB client method calls.

Looks good to me. We're removing the cache to support stateless sessions correct?

Mar 6 2024, 9:32 PM
will closed D11231: [identity] Replace elastic crate in identity.
Mar 6 2024, 5:09 AM
will committed rCOMMe5c6972837ba: [identity] Replace elastic crate in identity.
Mar 6 2024, 5:09 AM
will published D11249: [sqlite] Adds integrity store table for review.
Mar 6 2024, 5:03 AM
will published D11247: [lib] Add integrity store ops for review.
Mar 6 2024, 5:02 AM

Mar 4 2024

will updated the summary of D11231: [identity] Replace elastic crate in identity.
Mar 4 2024, 4:27 PM
will updated the summary of D11231: [identity] Replace elastic crate in identity.
Mar 4 2024, 4:27 PM
will updated the summary of D11231: [identity] Replace elastic crate in identity.
Mar 4 2024, 3:17 PM
will requested review of D11231: [identity] Replace elastic crate in identity.
Mar 4 2024, 6:59 AM

Mar 1 2024

will accepted D11193: [terraform] expose allow origin list to identity service via terraform.

Looks good to me. Might want to adjust the diff title and test plan but that's really it.

Mar 1 2024, 8:53 PM

Feb 29 2024

will closed D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 10:35 PM
will committed rCOMMb544d8c66232: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 10:35 PM
will updated the test plan for D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 10:33 PM
will added a comment to D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.

what is IdentitySearchAccessToken? do you mean IdentitySearchAuthMessage?

Feb 29 2024, 10:31 PM
will updated the summary of D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 10:31 PM
will added a comment to D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.

can we improve the test plan a little? we should check that if the user isn't logged in we don't get an error

Feb 29 2024, 9:38 PM
will accepted D11193: [terraform] expose allow origin list to identity service via terraform.
Feb 29 2024, 7:54 PM
will updated the test plan for D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 7:54 PM
will updated the diff for D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.

authMetadata to auth message in console log

Feb 29 2024, 7:46 PM
will updated the test plan for D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 7:45 PM
will requested review of D11200: [lib] Handle logged in / logged out case in useGetIdentitySearchAuthMessage.
Feb 29 2024, 5:45 PM
will closed D11198: [web/native] Return null instead of throw new error when incomplete auth metadata.
Feb 29 2024, 5:23 PM
will committed rCOMM8f609a7b84a4: [web/native] Return null instead of throw new error when incomplete auth….
Feb 29 2024, 5:23 PM
will planned changes to D11198: [web/native] Return null instead of throw new error when incomplete auth metadata.
Feb 29 2024, 4:48 PM
will added a comment to D11198: [web/native] Return null instead of throw new error when incomplete auth metadata.

Downstream the client will no longer attempt to initialize a websocket connection in the identity-search-context. The identitySearchSocketConnected variable in useSearchUsers will remain false and so the function will fallback to keyserver search.

Feb 29 2024, 2:38 PM

Feb 28 2024

will accepted D11189: [nix] remove unused nix files.
Feb 28 2024, 4:19 AM

Feb 27 2024

will closed D11179: [services] Modify lambda opensearch request to use keyword instead of text.
Feb 27 2024, 7:39 PM
will committed rCOMMe9317915d08c: [services] Modify lambda opensearch request to use keyword instead of text.
Feb 27 2024, 7:39 PM
will closed D11180: [lib] Silence incomplete auth metadata message with UsingCommServicesAccessToken conditional.
Feb 27 2024, 7:38 PM
will committed rCOMM1749b8dbe2dc: [lib] Silence incomplete auth metadata message with….
Feb 27 2024, 7:38 PM