rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 10 2024
Jun 10 2024
rebase
Jun 8 2024
Jun 8 2024
consistent newlines
review feedback
Jun 7 2024
Jun 7 2024
include web wasm
fix prior update
rebase
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
remove availability zones
will updated the diff for D12324: [terraform] Replace all config options with terraform variables and remove sops.
rebase
rebase
will updated the diff for D12324: [terraform] Replace all config options with terraform variables and remove sops.
to be removed but zones should be included in the terraform variables for this diff
will requested review of D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
will added a comment to D12337: [keyserver] Bump MariaDB --innodb-buffer-pool-size config to 14000M in docker-compose.yml.
For the AWS RDS configuration, I used 75% of DBInstanceClassMemory which I believe is just the RAM.
Jun 6 2024
Jun 6 2024
will updated the diff for D12324: [terraform] Replace all config options with terraform variables and remove sops.
review feedback
will added a comment to D12324: [terraform] Replace all config options with terraform variables and remove sops.
In D12324#350437, @bartek wrote:Two comments here:
- When using one of "default" filenames (I recall terraform.tfvars), you don't have to use the -var-file="secrets.tfvars" arg
- It's a good practice to commit terraform.tfvars.example (while gitignoring actual terraform.tfvars) with example variables (usually required ones, that don't have defaults in variables.tf). This file can be copied and renamed by individual users.
What do you think?
add comment: 256 MiB: (1024 * 1024 * 256)
will added a reviewer for D12324: [terraform] Replace all config options with terraform variables and remove sops: ashoat.
will added inline comments to D12324: [terraform] Replace all config options with terraform variables and remove sops.
will added a comment to D12324: [terraform] Replace all config options with terraform variables and remove sops.
Was thinking similar to the dev folder, we can create a simple run.sh script with:
terraform init
will updated the summary of D12324: [terraform] Replace all config options with terraform variables and remove sops.
Jun 5 2024
Jun 5 2024
additional configuration options
rebase before land
refactor with proper igw routes
Jun 4 2024
Jun 4 2024
add subnet
Jun 3 2024
Jun 3 2024
In D12253#349092, @tomek wrote:Depends on https://phab.comm.dev/D12249
Setting a dependency on the URL doesn't work - we have to use just the diff id D12249
will updated the summary of D12253: [sqlite] implement logic to get message store logic from SQLite.
May 31 2024
May 31 2024
review feedback
May 30 2024
May 30 2024
May 24 2024
May 24 2024
will updated the diff for D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
use set for constant time lookups
May 23 2024
May 23 2024
will updated the diff for D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
review feedkback
May 22 2024
May 22 2024
will planned changes to D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
Planning changes to address review feedback
will added inline comments to D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
May 21 2024
May 21 2024
May 20 2024
May 20 2024
will added inline comments to D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
will added inline comments to D12105: [lib] modify set aux user fids and replace old behavior with add aux user fids action type.
will updated the test plan for D12011: [lib] dispatch actions and populate aux user store with fids.
will removed 1 blocking reviewer(s) for D12011: [lib] dispatch actions and populate aux user store with fids: ginsu.
review feedback
May 19 2024
May 19 2024
May 16 2024
May 16 2024
The rust looks good to me