Rebase

Rebase

Run JSI codegen

Rebase

Rebase

Rebase

Rebase

Run emscripten

Add space

Rebase

Review changes: add parseInboundingMessages and change methods order

Rebase

Formatting

I probably should have explained this differently. What I meant is that we're currently forcing the useMemo in useThreadsWithPermission to be recalculated on every call from useThreadHasPermission. This diff fixes that.

Ok, it makes sense, though it's a bit weird to me. This useMemo affects how another hook is calculated. Maybe a comment would be useful?

Rebase

Rebase

Update errors in lib/hooks/input-state-container-hooks.js

In D13880#387505, @ashoat wrote:

Great find here!! Is it possible that this fixes ENG-8780 as well? I think that one is also a permissions issue.

Are you sure this improves performance? Did you measure it after making this change and compared it with before the change? Performance improvements are tricky.
As far as I understand useThreadsWithPermission will be called every time useThreadHasPermission is called, even with useMemo. This is a hook, not a component.
Here is a snack with this code but simplified: https://snack.expo.dev/@angelikaserwa/suspicious-violet-tortillas
After you press the button, the app will re-render and useThreadsWithPermission will be called, even with memo.

Review changes

Rebase

Rebase

Review changes

In D13802#386045, @ashoat wrote:

You can't update the commit message with arc diff. Instead, you should edit the revision on Phabricator, and then run arc amend locally to update the commit text based on what's on Phabricator. (I think this last step also gets run automatically as part of arc land.)

Update commit message

Update commit message

Rebase and implement requested changes

Rebase and implement requested changes

Rebase

In D13802#385659, @ashoat wrote:

Question about the test plan:

After this patch there should be less of them

Did some of errors still appear? What's your theory for why that is?

Rebase

Remove showOperationAlertToStaff