Page MenuHomePhorge
Feed Search

Jul 28 2025

bartek added a comment to D15103: [native][RN80][skip-ci] Bump react-native and expo packages.

Should I be a reviewer here?

Jul 28 2025, 7:48 AM
bartek accepted D15102: [RN80][skip-ci] Bump react@19.1.0.
Jul 28 2025, 7:47 AM
bartek accepted D15104: [native][RN80][skip-ci] Native files changes.
Jul 28 2025, 7:47 AM
bartek accepted D14963: [native][RN79][skip-ci] Update icon names due to @expo/vector-icons update.
Jul 28 2025, 7:46 AM
bartek accepted D14997: [native][RN79][skip-ci] Splashscreen migration.
Jul 28 2025, 7:44 AM
bartek accepted D14996: [native][RN79][skip-ci] Patch react-native-keyboard-input.
Jul 28 2025, 7:37 AM
bartek accepted D14990: [native][RN79][skip-ci] Update to react-native-video@6.14.0.

Also keep in mind that from now on to install pods you need to run bundle exec pod install instead of just pod install.

Jul 28 2025, 7:36 AM
bartek accepted D14991: [native][RN79][skip-ci] Update reactotron-react-native@5.1.13, reactotron-redux@3.2.0.
Jul 28 2025, 7:31 AM
bartek accepted D14992: [native][RN79][skip-ci] Update metro.config, .babelrc.cjs.
Jul 28 2025, 7:31 AM
bartek accepted D14993: [native][RN79][skip-ci] Remove babel transformer patch.
Jul 28 2025, 7:30 AM
bartek accepted D14994: [native][RN79][skip-ci] Fix props object containing `key` prop.
Jul 28 2025, 7:29 AM
bartek accepted D14995: [native][RN79][skip-ci] Migrate `BackHandler.removeEventListener`.
Jul 28 2025, 7:29 AM
bartek accepted D14989: [native][RN79][skip-ci] Remove expo-barcode-scanner and react-native-camera packages.
Jul 28 2025, 7:27 AM
bartek accepted D14988: [native][RN79][skip-ci] Add react-native-vision-camera flow types.
Jul 28 2025, 7:27 AM
bartek accepted D14981: [native][RN79][skip-ci] Add react-native-vision camera package.
Jul 28 2025, 7:23 AM
bartek accepted D14980: [native][RN79][skip-ci] Update comm-expo-package.
Jul 28 2025, 7:23 AM
bartek accepted D14979: [native][RN79][skip-ci] Remove expo-secure-store.
Jul 28 2025, 7:22 AM
bartek accepted D14977: [native][RN79][skip-ci] Migrate AppDelegate to Swift.

This looks so nice and clean now!

Jul 28 2025, 7:21 AM
bartek accepted D14976: [native][RN79][skip-ci] Update native files on iOS.
Jul 28 2025, 7:17 AM
bartek accepted D14972: [native][RN79][skip-ci] Add CommInitializerModule [android].
Jul 28 2025, 7:13 AM
bartek accepted D14971: [native][RN79][skip-ci] Add CommInitializerModule [js].
Jul 28 2025, 7:12 AM
bartek accepted D15136: [native][RN79][skip-ci] Add CommInitializerModule [ios].
Jul 28 2025, 7:11 AM
bartek accepted D14970: [native][RN79][skip-ci] Replace folly::MPMCQueue.

Nice!

Jul 28 2025, 7:09 AM
bartek accepted D14969: [native][RN79][skip-ci] Replace folly::trimWhitespace with StringUtils::trimWhitespace.
Jul 28 2025, 7:08 AM
bartek accepted D14968: [native][RN79][skip-ci] Add missing imports in cpp header files.
Jul 28 2025, 7:07 AM
bartek accepted D14967: [native][RN79][skip-ci] Update CMakeLists.txt files.
Jul 28 2025, 7:07 AM
bartek accepted D14966: [native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors.

Perhaps Java-style calls were deprecated, Kotlin favors property-style syntax for calling getters

Jul 28 2025, 7:06 AM
bartek accepted D14964: [native][RN79][skip-ci] Update Android build files.
Jul 28 2025, 7:04 AM

Jul 25 2025

bartek accepted D14962: [native][RN79][skip-ci] Rename totalByteSent -> totalBytesSent from expo-file-system.
Jul 25 2025, 11:11 AM
bartek accepted D14961: [native][RN79][skip-ci] Update @expo/cli patchfile.

I'm impressed that this old patch still works 😀

Jul 25 2025, 11:11 AM
bartek accepted D14960: [native][RN79][skip-ci] Update to @expo/react-native-action-sheet@4.1.1.
Jul 25 2025, 11:09 AM
bartek accepted D14959: [native][RN79][skip-ci] Bump Expo packages to SDK 53.
Jul 25 2025, 11:08 AM
bartek accepted D14958: [native][RN79][skip-ci] Update to lottie-react-native@7.2.2.
Jul 25 2025, 11:08 AM
bartek accepted D14957: [native][RN79][skip-ci] Update to react-native-screens@4.10.0.
Jul 25 2025, 11:08 AM
bartek accepted D14956: [native][RN79][skip-ci] Update to react-native-progress@5.0.1.
Jul 25 2025, 11:07 AM
bartek accepted D14955: [native][RN79][skip-ci] Update to react-native-svg@15.11.2.
Jul 25 2025, 11:07 AM
bartek accepted D14954: [native][RN79][skip-ci] Update to react-native-gesture-handler@2.24.0.
Jul 25 2025, 11:07 AM
bartek accepted D14953: [native][RN79][skip-ci] Update to react-native-reanimated@3.17.5.
Jul 25 2025, 11:07 AM
bartek accepted D14952: [native][RN79][skip-ci] Update React Native patchfile.
Jul 25 2025, 11:06 AM
bartek accepted D14951: [native][RN79][skip-ci] Update React Native & React versions.
Jul 25 2025, 11:06 AM
bartek published D15141: [lib] Refetch peer device list when device keys are missing for review.
Jul 25 2025, 10:42 AM
bartek published D15140: [lib] Skip Olm session creation for dead devices for review.
Jul 25 2025, 10:42 AM
bartek published D15139: [lib] Detect peer primary device changes for review.
Jul 25 2025, 9:49 AM
bartek published D15138: [lib] Broadcast device list update after restoration for review.
Jul 25 2025, 9:49 AM
bartek published D14934: [lib] Update AuxUserStore peers after restoring for review.
Jul 25 2025, 9:48 AM
bartek committed rCOMM3f746cf10d63: [lib] Removed ESLint directive from Webpack config.
Jul 25 2025, 8:33 AM

Jul 24 2025

bartek updated the summary of D15136: [native][RN79][skip-ci] Add CommInitializerModule [ios].
Jul 24 2025, 6:33 PM
bartek closed D15135: [web][lib] Add debug logs for QR generation and DB deletion.
Jul 24 2025, 3:07 PM
bartek committed rCOMM55a165cfde2c: [web][lib] Add debug logs for QR generation and DB deletion.
Jul 24 2025, 3:07 PM
bartek published D15135: [web][lib] Add debug logs for QR generation and DB deletion for review.
Jul 24 2025, 12:48 PM
bartek accepted D14984: [native] Add an option to link DCs from a profile screen.
Jul 24 2025, 6:41 AM
bartek accepted D14911: [native] Connect Farcaster DCs during registration.
Jul 24 2025, 6:38 AM
bartek accepted D15032: [lib][native][web] handle LocalMessageInfo when restoring backup.
Jul 24 2025, 6:38 AM
bartek accepted D15093: [lib] Inform other own devices about the connection update.

I'm wondering if sending this as Olm-encrypted message would make sense, but I guess not. This message type is not different from e.g. "device list updated" message.

Jul 24 2025, 6:22 AM

Jul 22 2025

bartek accepted D15031: [lib][native][web] update `UserDataRestoreProvider` to make `userID` param mandatory.
Jul 22 2025, 11:08 AM
bartek accepted D14986: [web] catch errors when persisting database.
Jul 22 2025, 7:33 AM

Jul 21 2025

bartek accepted D14983: [native] init `restoredConnectionManager` before copying content.
Jul 21 2025, 1:40 PM
bartek accepted D14950: [lib] implement handling backup keys from primary.
Jul 21 2025, 10:51 AM
bartek accepted D14949: [lib][native] implement sending backup keys to existing secondary devices.
Jul 21 2025, 10:49 AM

Jul 18 2025

bartek accepted D14931: [lib] Add info about DCs token into Identity.
Jul 18 2025, 4:10 PM
bartek accepted D14922: [identity] Allow linking Farcaster DCs.

Generally looks okay, given this diff contains multiple changes:

  • [proto] Adds new LinkFarcasterDCsAccount RPC
    • [identity] Implements the RPC
    • grpc-web changes for this seem to be applied in D14927
  • [proto] Adds new param to Registration RPCs - it's okay, this is also backwards-compatible
    • [native] Exposes it via JSI to JS
  • [identity] Adds the DCs token to the DBIdentity type, it is used in D14931
Jul 18 2025, 4:10 PM
bartek accepted D14927: [native][web] Expose linking the account through gRPC.
NOTE: This diff contains grpc-web changes for D14922's proto changes. For reference, I mentioned it in the other diff as well.
Jul 18 2025, 4:08 PM
bartek added inline comments to D14949: [lib][native] implement sending backup keys to existing secondary devices.
Jul 18 2025, 11:47 AM
bartek closed D14945: [native] Add logic to restore error screen buttons.
Jul 18 2025, 10:26 AM
bartek committed rCOMMa8641b117b5e: [native] Add logic to restore error screen buttons.
Jul 18 2025, 10:26 AM
bartek closed D14944: [web] Add logic to restore error screen buttons.
Jul 18 2025, 10:26 AM
bartek closed D14926: [lib][web] Distinguish restore errors from QR auth errors.
Jul 18 2025, 10:26 AM
bartek committed rCOMMc5e4f08c6c5e: [web] Add logic to restore error screen buttons.
Jul 18 2025, 10:26 AM
bartek closed D14925: [native] Navigate to error screen after restoration failure.
Jul 18 2025, 10:26 AM
bartek committed rCOMMbf42d4800317: [lib][web] Distinguish restore errors from QR auth errors.
Jul 18 2025, 10:26 AM
bartek committed rCOMMabd70893b7f9: [native] Navigate to error screen after restoration failure.
Jul 18 2025, 10:26 AM
bartek closed D14924: [native] Add screen for restoration error.
Jul 18 2025, 10:26 AM
bartek closed D14921: [lib] Add actions to force set restoration state.
Jul 18 2025, 10:26 AM
bartek committed rCOMMa265287f9c5a: [native] Add screen for restoration error.
Jul 18 2025, 10:26 AM
bartek closed D14920: [web] Add UI for tracking restoration progress.
Jul 18 2025, 10:26 AM
bartek committed rCOMM9b6d6b0b27e9: [lib] Add actions to force set restoration state.
Jul 18 2025, 10:26 AM
bartek committed rCOMMbfbb47f65515: [web] Add UI for tracking restoration progress.
Jul 18 2025, 10:26 AM
bartek closed D14919: [web] Display PushNotif modal after restoration has finished.
Jul 18 2025, 10:26 AM
bartek closed D14918: [web] Gate logged out screen on restoration finish.
Jul 18 2025, 10:26 AM
bartek committed rCOMM62f735c5876f: [web] Display PushNotif modal after restoration has finished.
Jul 18 2025, 10:26 AM
bartek committed rCOMMfba5523afa3b: [web] Gate logged out screen on restoration finish.
Jul 18 2025, 10:26 AM
bartek closed D14917: [native] Keep LoggedOutModal until restoration finishes.
Jul 18 2025, 10:26 AM
bartek committed rCOMM261f3d76f5f9: [native] Keep LoggedOutModal until restoration finishes.
Jul 18 2025, 10:26 AM
bartek accepted D14948: [lib] update `broadcastEphemeralMessage` to return result.
Jul 18 2025, 10:21 AM
bartek accepted D14947: [lib][native] when uploading UserData for the first time, keep track of secondary device ids.
Jul 18 2025, 9:32 AM
bartek updated the diff for D14924: [native] Add screen for restoration error.

Rebase, memoize component

Jul 18 2025, 9:29 AM

Jul 17 2025

bartek updated the diff for D14919: [web] Display PushNotif modal after restoration has finished.

Browsed the codebase for 'isLoggedIn' and found other places where it's worth doing.

Jul 17 2025, 3:06 PM
bartek updated the summary of D14920: [web] Add UI for tracking restoration progress.
Jul 17 2025, 2:55 PM
bartek accepted D14946: [native] update UserData upload conditions.
Jul 17 2025, 2:52 PM
bartek published D14945: [native] Add logic to restore error screen buttons for review.
Jul 17 2025, 1:59 PM
bartek published D14926: [lib][web] Distinguish restore errors from QR auth errors for review.
Jul 17 2025, 1:59 PM
bartek published D14944: [web] Add logic to restore error screen buttons for review.
Jul 17 2025, 1:59 PM
bartek updated the diff for D14925: [native] Navigate to error screen after restoration failure.

Rebase, add fullBackupSupport check

Jul 17 2025, 12:44 PM
bartek updated the diff for D14921: [lib] Add actions to force set restoration state.

Add 'forced' state, make types readonly

Jul 17 2025, 12:42 PM
bartek updated the diff for D14920: [web] Add UI for tracking restoration progress.
  • Removed leftovers
  • Added colors to theme.css
  • Addressed feedback for staff-only debug text
Jul 17 2025, 11:01 AM
bartek closed D14932: [web] Add x-large variant to LoadingIndicator.
Jul 17 2025, 10:01 AM
bartek closed D14916: [lib] Add hook to check if restoration finished.
Jul 17 2025, 10:01 AM
bartek committed rCOMM4288f239a102: [lib] Add hook to check if restoration finished.
Jul 17 2025, 10:01 AM
bartek committed rCOMMea05fc8b88aa: [web] Add x-large variant to LoadingIndicator.
Jul 17 2025, 10:01 AM
bartek closed D14915: [native] Show alert when DB is corrupt on app startup.
Jul 17 2025, 10:01 AM