Details

Reviewers

bartek

Commits

rCOMM442ff1b1e590: [native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors

Summary

Some trivial compilation errors, probably due to kotlin upgrade.

Depends on D14965

Test Plan

Build the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 19 2025, 8:10 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2025, 8:10 AM

Harbormaster completed remote builds in B34614: Diff 48811.Jul 19 2025, 8:13 AM

angelika added a child revision: D14967: [native][RN79][skip-ci] Update CMakeLists.txt files.Jul 19 2025, 8:15 AM

Rebase

Harbormaster completed remote builds in B34818: Diff 49025.Jul 24 2025, 4:13 PM

angelika published this revision for review.Jul 25 2025, 9:01 AM

Perhaps Java-style calls were deprecated, Kotlin favors property-style syntax for calling getters

This revision is now accepted and ready to land.Jul 28 2025, 7:06 AM

Rebase & review changes

Harbormaster completed remote builds in B35085: Diff 49336.Aug 9 2025, 12:14 PM

Rebase & review changes

Harbormaster completed remote builds in B35351: Diff 49640.Aug 21 2025, 12:33 PM

Closed by commit rCOMM442ff1b1e590: [native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors. · Explain WhyAug 21 2025, 7:30 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM442ff1b1e590: [native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors.

[native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49818

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

[native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49818

native/expo-modules/comm-expo-package/android/src/main/java/app/comm/android/lifecycle/AndroidLifecycleModule.kt

[native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors
ClosedPublic
Actions

Revision Contents
Changeset List