Details

Reviewers

bartek

Commits

rCOMMdfc88c4fa08e: [native][RN79][skip-ci] Migrate from expo-secure-store on iOS

Summary

https://linear.app/comm/issue/ENG-10284/migrate-expo-secure-store-related-code

The swift code in CommSecureStore was mostly copied from expo-secure-store source code.

Depends on D14977

Test Plan

https://linear.app/comm/issue/ENG-10985/final-testing

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 21 2025, 12:29 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2025, 12:29 PM

Harbormaster completed remote builds in B34629: Diff 48828.Jul 21 2025, 12:31 PM

angelika added a child revision: D14979: [native][RN79][skip-ci] Remove expo-secure-store.Jul 21 2025, 12:37 PM

Rebase

Harbormaster completed remote builds in B34829: Diff 49036.Jul 24 2025, 4:16 PM

Rebase & review changes

Harbormaster completed remote builds in B35096: Diff 49347.Aug 9 2025, 12:15 PM

Added comments with links to original files

bartek accepted this revision.Aug 14 2025, 9:28 AM

This revision is now accepted and ready to land.Aug 14 2025, 9:28 AM

Rebase & review changes

Harbormaster completed remote builds in B35362: Diff 49651.Aug 21 2025, 12:36 PM

Closed by commit rCOMMdfc88c4fa08e: [native][RN79][skip-ci] Migrate from expo-secure-store on iOS. · Explain WhyAug 21 2025, 7:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMdfc88c4fa08e: [native][RN79][skip-ci] Migrate from expo-secure-store on iOS.

[native][RN79][skip-ci] Migrate from expo-secure-store on iOS
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49830

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Comm/CommSecureStore.mm

native/ios/Comm/CommSecureStore/SecureFileExceptions.swift

native/ios/Comm/CommSecureStore/SecureStoreModule.h

native/ios/Comm/CommSecureStore/SecureStoreModule.swift

native/ios/Comm/CommSecureStore/SecureStoreOptions.swift

native/ios/Comm/CommSecureStoreIOSWrapper.h

native/ios/Comm/CommSecureStoreIOSWrapper.mm

[native][RN79][skip-ci] Migrate from expo-secure-store on iOSClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49830

native/ios/Comm.xcodeproj/project.pbxproj

native/ios/Comm/CommSecureStore.mm

native/ios/Comm/CommSecureStore/SecureFileExceptions.swift

native/ios/Comm/CommSecureStore/SecureStoreModule.h

native/ios/Comm/CommSecureStore/SecureStoreModule.swift

native/ios/Comm/CommSecureStore/SecureStoreOptions.swift

native/ios/Comm/CommSecureStoreIOSWrapper.h

native/ios/Comm/CommSecureStoreIOSWrapper.mm

[native][RN79][skip-ci] Migrate from expo-secure-store on iOS
ClosedPublic
Actions

Revision Contents
Changeset List