Details

Reviewers

Commits

rCOMM10934c39ed23: [Flow262][skip-ci] Fix recursivelyUpdateRoles

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

name is a string, computedRolePermissionBlobs is an object of type RolePermissionBlobs with keys 'Member' and 'Admin' so flow complains.
Checking that name is 'Admin' or 'Members' fixes the error.

Depends on D15084

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 23 2025, 3:35 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 3:35 PM

angelika added a child revision: D15086: [Flow262][skip-ci] $Partial -> Partial.Jul 23 2025, 3:37 PM

Harbormaster completed remote builds in B34742: Diff 48947.Jul 23 2025, 3:38 PM

Rebase

Harbormaster completed remote builds in B34929: Diff 49136.Jul 24 2025, 4:29 PM

angelika published this revision for review.Jul 25 2025, 9:53 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Jul 31 2025, 3:09 PM

tomek added inline comments.

lib/shared/redux/legacy-update-roles-and-permissions.js
78–82 ↗	(On Diff #49136)	In this case, we should prefer silencing the error instead of introducing a new logic. This is a part of an existing and any change to its logic could have consequences.