Differential D15043

[Flow262][skip-ci] Replace React.Config
ClosedPublic
Actions

Authored by angelika on Jul 22 2025, 10:07 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM88961a4d39b3: [Flow262][skip-ci] Replace React.Config

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15042

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 22 2025, 10:07 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 10:07 PM

Harbormaster completed remote builds in B34697: Diff 48901.Jul 22 2025, 10:10 PM

angelika added a child revision: D15044: [Flow262][skip-ci] Fix object spread issue in keyserver/dm-permissions.js.Jul 22 2025, 10:10 PM

Rebase

Harbormaster completed remote builds in B34888: Diff 49095.Jul 24 2025, 4:25 PM

angelika published this revision for review.Jul 25 2025, 9:38 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Jul 31 2025, 10:32 AM

tomek added inline comments.

native/components/tag-input.react.js
452–455 ↗	(On Diff #49095)	Is there a reason why we don't follow the docs? https://flow.org/en/docs/react/types/#toc-react-config

This revision now requires changes to proceed.Jul 31 2025, 10:32 AM

Rebase & review changes

Harbormaster completed remote builds in B35155: Diff 49406.Aug 9 2025, 12:25 PM

angelika planned changes to this revision.Aug 9 2025, 1:53 PM

angelika added inline comments.Aug 11 2025, 11:48 AM

native/components/tag-input.react.js
452–455 ↗	(On Diff #49095)	Replaced $Diff with Omit here: https://phab.comm.dev/D15110 The replacement from the docs doesn't work: flow try (although when I use it in our code I get a different error)

angelika requested review of this revision.Aug 11 2025, 11:48 AM

tomek accepted this revision.Aug 11 2025, 2:11 PM

This revision is now accepted and ready to land.Aug 11 2025, 2:11 PM

Rebase & review changes

Harbormaster completed remote builds in B35421: Diff 49710.Aug 21 2025, 12:48 PM

Closed by commit rCOMM88961a4d39b3: [Flow262][skip-ci] Replace React.Config. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM88961a4d39b3: [Flow262][skip-ci] Replace React.Config.

Revision Contents
Changeset List

Path

Size

native/

components/

tag-input.react.js

7 lines

Diff 49888

native/components/tag-input.react.js

Loading...