https://linear.app/comm/issue/ENG-10205/update-flow-to-02691
Make some properties optional so that they match validators.
Depends on D15087
Differential D15088 Authored by angelika on Jul 23 2025, 3:42 PM.
Details
Summary https://linear.app/comm/issue/ENG-10205/update-flow-to-02691 Make some properties optional so that they match validators. Depends on D15087 Test Plan Flow
Diff Detail
Event Timelineangelika held this revision as a draft. Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 3:42 PM2025-07-23 15:42:10 (UTC+0) Harbormaster completed remote builds in B34745: Diff 48950.Jul 23 2025, 3:44 PM2025-07-23 15:44:08 (UTC+0) Harbormaster completed remote builds in B34932: Diff 49139.Jul 24 2025, 4:29 PM2025-07-24 16:29:57 (UTC+0) Comment Actions Replacing prop: null with prop?: null makes sense, but could you explain why we're introducing an optional specified to properties that weren't optional? I guess that it might be due to the fact that we're not specifying them somewhere, but maybe there are some bugs? This revision now requires changes to proceed.Jul 31 2025, 3:13 PM2025-07-31 15:13:30 (UTC+0) Comment Actions
Let's see for example createRobotextInThinThread: But the type says it's just a boolean: export type RelationshipRequestUserInfo = {
+createRobotextInThinThread: boolean,
};So which one is it? It's safer to add ? to the type than to the validator. Comment Actions
You're right! The fact that they are different is probably a mistake, but replacing them with the optional type is the cheapest option to deal with the consequences. A more expensive one is to check all the usages, and replace with a mandatory type if possible, but to do it confidently, we would also need to check the older versions - quite a lot of work to do. This revision is now accepted and ready to land.Aug 4 2025, 1:37 PM2025-08-04 13:37:36 (UTC+0) Harbormaster completed remote builds in B35197: Diff 49448.Aug 9 2025, 12:32 PM2025-08-09 12:32:22 (UTC+0) Harbormaster completed remote builds in B35252: Diff 49509.Aug 11 2025, 12:47 PM2025-08-11 12:47:39 (UTC+0) Harbormaster completed remote builds in B35301: Diff 49574.Aug 18 2025, 1:16 PM2025-08-18 13:16:55 (UTC+0) Harbormaster completed remote builds in B35463: Diff 49752.Aug 21 2025, 12:55 PM2025-08-21 12:55:09 (UTC+0) Closed by commit rCOMMc3340ecd9bb5: [Flow262][skip-ci] Make some properties optional. · Explain WhyAug 21 2025, 7:34 PM2025-08-21 19:34:08 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 49930 |