Differential D15034

[Flow262][skip-ci] Fix errors caused by pop() returning undefined
ClosedPublic
Actions

Authored by angelika on Jul 22 2025, 8:12 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM35e2b598fbd5: [Flow262][skip-ci] Fix errors caused by pop() returning undefined

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

v0.239.0: Calling shift() and pop() on an Array<T> will now return T | undefined

Depends on D15033

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 22 2025, 8:12 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 22 2025, 8:12 PM

angelika added a child revision: D15035: [Flow262][skip-ci] Fix tNumEnum.Jul 22 2025, 8:16 PM

Harbormaster completed remote builds in B34688: Diff 48892.Jul 22 2025, 8:16 PM

Rebase

Harbormaster completed remote builds in B34879: Diff 49086.Jul 24 2025, 4:24 PM

angelika published this revision for review.Jul 25 2025, 9:35 AM

angelika added a reviewer: tomek.

tomek accepted this revision.Jul 30 2025, 4:32 PM

tomek added inline comments.

lib/shared/radix-tree.js
100–103 ↗	(On Diff #49086)	It could as well be an invariant, because in the while condition we're checking the length. But keeping as is is also ok.
lib/utils/cookie-utils.js
15 ↗	(On Diff #49086)	Shouldn't we throw here?
native/media/media-cache.js
22 ↗	(On Diff #49086)	Shouldn't we throw here?

This revision is now accepted and ready to land.Jul 30 2025, 4:32 PM

Rebase & review changes

Harbormaster completed remote builds in B35146: Diff 49397.Aug 9 2025, 12:23 PM

Rebase & review changes

Harbormaster completed remote builds in B35412: Diff 49701.Aug 21 2025, 12:46 PM

Closed by commit rCOMM35e2b598fbd5: [Flow262][skip-ci] Fix errors caused by pop() returning undefined. · Explain WhyAug 21 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM35e2b598fbd5: [Flow262][skip-ci] Fix errors caused by pop() returning undefined.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

3 lines

lib/

shared/

6 lines

threads/

protocols/

dm-thread-protocol.js

1 line

utils/

cookie-utils.js

3 lines

native/

media/

1 line

navigation/

modal-pruner.react.js

1 line

Diff 49879

keyserver/src/cron/backups.js

Loading...

lib/shared/radix-tree.js

Loading...

lib/shared/threads/protocols/dm-thread-protocol.js

Loading...

lib/utils/cookie-utils.js

Loading...

native/media/media-cache.js

Loading...

native/navigation/modal-pruner.react.js

Loading...