Differential D15048 Authored by angelika on Jul 23 2025, 4:23 AM.
Details
Summary https://linear.app/comm/issue/ENG-10205/update-flow-to-02691 I know we should avoid as any but here we're dealing with migrations from the old state to the new state and the old state might not match the current state type. Depends on D15047 Test Plan Flow
Diff Detail
Event Timelineangelika held this revision as a draft. Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 4:23 AM2025-07-23 04:23:33 (UTC+0) Harbormaster completed remote builds in B34702: Diff 48906.Jul 23 2025, 4:27 AM2025-07-23 04:27:28 (UTC+0) Harbormaster completed remote builds in B34893: Diff 49100.Jul 24 2025, 4:26 PM2025-07-24 16:26:19 (UTC+0) Comment Actions I think it's ok - we shouldn't modify these in the future, and they were already validated by our type system. Regarding the solution, maybe a bit cleaner one would be to only modify the LegacyMigrationManifest type? Not sure... This revision is now accepted and ready to land.Jul 31 2025, 10:57 AM2025-07-31 10:57:45 (UTC+0) Comment Actions
Modify how? Something like this? export type LegacyMigrationManifest<N: BaseNavInfo, T: BaseAppState<N>> = {
+[number | string]: (any) => any,
};it doesn't look like aa good idea Comment Actions
Yeah, something like that. Ok, so up to you - we can keep the current approach. Harbormaster completed remote builds in B35160: Diff 49411.Aug 9 2025, 12:26 PM2025-08-09 12:26:13 (UTC+0) Harbormaster completed remote builds in B35426: Diff 49715.Aug 21 2025, 12:48 PM2025-08-21 12:48:57 (UTC+0) Closed by commit rCOMM3ec0897a049c: [Flow262][skip-ci] Fix types in store migration. · Explain WhyAug 21 2025, 7:33 PM2025-08-21 19:33:07 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 49892 |