Details

Reviewers

Commits

rCOMM2293344003e9: [native][RN80][skip-ci] Fix login screen flickering on startup

Summary

https://linear.app/comm/issue/ENG-10980/login-screen-flicker-on-startup-on-android

In AppNavigator we wait for interactions before hiding the splash screen. After RN upgrade it no longer works - waitForInteractions() resolves
before navigation navigates to the main screen.
So we wait for navigation to navigate before hiding the splash screen.

Depends on D15130

Test Plan

Test in release and dev mode.
Start the app without any data.
Start the app with logged in user.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 24 2025, 8:58 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2025, 8:58 AM

Harbormaster completed remote builds in B34790: Diff 48995.Jul 24 2025, 9:00 AM

angelika added a child revision: D15132: [native][RN80][skip-ci] Fix orientation on iOS.Jul 24 2025, 9:01 AM

Rebase

Harbormaster completed remote builds in B34974: Diff 49181.Jul 24 2025, 4:38 PM

angelika published this revision for review.Jul 25 2025, 10:08 AM

bartek added inline comments.Jul 28 2025, 11:02 AM

native/root.react.js
170–171 ↗	(On Diff #49181)	Shouldn't this be outside `if (__DEV__)`?

Rebase & review changes

Harbormaster completed remote builds in B35239: Diff 49490.Aug 9 2025, 12:39 PM

angelika added inline comments.Aug 9 2025, 1:21 PM

native/root.react.js
170–171 ↗	(On Diff #49181)	No, it's correct, in dev loading initial navigation state is different. In dev we navigate to the last used screen, in release we navigate to the chats screen if user is logged in. But in order to navigate to the last used screen we need to mount navigator (as far as I remember, anyway it was breaking on dev), so we just hide splashscreen sooner on dev.

bartek accepted this revision.Aug 12 2025, 10:56 AM

bartek added inline comments.

native/root.react.js
170–171 ↗	(On Diff #49181)	Okay, this makes sense

This revision is now accepted and ready to land.Aug 12 2025, 10:56 AM

Rebase & review changes

Harbormaster completed remote builds in B35505: Diff 49794.Aug 21 2025, 1:01 PM

Closed by commit rCOMM2293344003e9: [native][RN80][skip-ci] Fix login screen flickering on startup. · Explain WhyAug 21 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM2293344003e9: [native][RN80][skip-ci] Fix login screen flickering on startup.

[native][RN80][skip-ci] Fix login screen flickering on startup
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49972

native/navigation/app-navigator.react.js

native/navigation/navigation-context.js

native/root.react.js

[native][RN80][skip-ci] Fix login screen flickering on startupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49972

native/navigation/app-navigator.react.js

native/navigation/navigation-context.js

native/root.react.js

[native][RN80][skip-ci] Fix login screen flickering on startup
ClosedPublic
Actions

Revision Contents
Changeset List