Differential D14965

[native][RN79][skip-ci] Migrate MainApplication and MainActivity to Kotlin
ClosedPublic
Actions

Authored by angelika on Jul 19 2025, 8:07 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM5d65c61c40fc: [native][RN79][skip-ci] Migrate MainApplication and MainActivity to Kotlin

Summary

https://linear.app/comm/issue/ENG-10275/apply-the-diff-from-react-native-upgrade-helper

The files are based on expo's upgrade helper.

Depends on D14964

Test Plan

https://linear.app/comm/issue/ENG-10985/final-testing

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jul 19 2025, 8:07 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2025, 8:07 AM

angelika added a child revision: D14966: [native][RN79][skip-ci] Fix AndroidLifecycleModule compilation errors.Jul 19 2025, 8:10 AM

Harbormaster completed remote builds in B34613: Diff 48810.Jul 19 2025, 8:11 AM

bartek added inline comments.Jul 22 2025, 8:10 AM

native/android/app/src/main/java/app/comm/android/MainActivity.java
75–94 ↗	(On Diff #48810)	Is this override for notif permissions no longer needed?

Rebase

Harbormaster completed remote builds in B34817: Diff 49024.Jul 24 2025, 4:13 PM

Rebase & review changes

Harbormaster completed remote builds in B35084: Diff 49335.Aug 9 2025, 12:14 PM

angelika published this revision for review.Aug 9 2025, 12:15 PM

angelika added inline comments.

native/android/app/src/main/java/app/comm/android/MainActivity.java
75–94 ↗	(On Diff #48810)	Added notif permissions

bartek accepted this revision.Aug 11 2025, 8:12 AM

This revision is now accepted and ready to land.Aug 11 2025, 8:12 AM

Rebase & review changes

Harbormaster completed remote builds in B35350: Diff 49639.Aug 21 2025, 12:33 PM

Closed by commit rCOMM5d65c61c40fc: [native][RN79][skip-ci] Migrate MainApplication and MainActivity to Kotlin. · Explain WhyAug 21 2025, 7:30 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM5d65c61c40fc: [native][RN79][skip-ci] Migrate MainApplication and MainActivity to Kotlin.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

MainActivity.java

MainActivity.kt

86 lines

MainApplication.java

MainApplication.kt

107 lines

fbjni/

4 lines

PlatformSpecificTools.java

4 lines

Diff 49817

native/android/app/src/main/java/app/comm/android/MainActivity.java

Loading...

native/android/app/src/main/java/app/comm/android/MainActivity.kt

Loading...

native/android/app/src/main/java/app/comm/android/MainApplication.java

Loading...

native/android/app/src/main/java/app/comm/android/MainApplication.kt

Loading...

native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java

Loading...

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

Loading...