rebase
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Sep 19 2022
Sep 19 2022
• karol updated the diff for D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.
rebase
rebase
rebase
rebase
rebase
rebase
rebase
rebase
• karol added inline comments to D5096: [services] Backup - Blob Get Client - Refactor put initialize.
In D5092#150546, @tomek wrote:Please update the Result type
update
• karol added inline comments to D5093: [services] Backup - Blob Get Client - Refactor put terminate.
• karol added inline comments to D5090: [services] Backup - Blob Get Client - Refactor get terminate.
remove commented code
• karol updated the diff for D5089: [services] Backup - Blob Get Client - Prepare for error handling.
rebase
• karol updated the diff for D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
rebase
• karol updated the diff for D5073: [services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id.
rebase
• karol updated the diff for D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.
rebase
• karol updated the diff for D5071: [services] Rust Integration - c++ - Implement worker in write reactor.
rebase
• karol updated the diff for D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
rebase
• karol updated the diff for D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
rebase
rebase
• karol added inline comments to D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 16 2022
Sep 16 2022
rebase
• karol updated the diff for D5038: [services] Rust Integration - Backup - c++ - Multiple get clients.
rebase
• karol updated the diff for D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
rebase
• karol updated the diff for D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.
rebase
• karol updated the diff for D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
rebase
1u
• karol retitled D5112: [services] Rust Integration - c++ - Add getNumberOfCores from [services] Rust Integration - c++ - Add getNumberOfCpus
• karol added inline comments to D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
• karol added a comment to D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
Also the CI fails for this diff.
Sep 15 2022
Sep 15 2022
In D5090#150521, @tomek wrote:It would be really helpful if you provided a context behind introducing _new functions.
• karol updated the diff for D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.
remove tools
• karol updated the diff for D5089: [services] Backup - Blob Get Client - Prepare for error handling.
fix formatting
• karol updated the diff for D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
format
• karol updated the diff for D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
format
I agree about the code formatting.
In D5089#150511, @tomek wrote:feel like the linting stuff should have been applied to the respective revisions. Also feel like the "create more revisions to apply feedback" is creating more churn for everyone, instead of applying the feedback in the original revision, then doing a rebase after applying the feedback.
Strongly agree!
• karol updated the diff for D5071: [services] Rust Integration - c++ - Implement worker in write reactor.
rebase
• karol updated the diff for D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
rebase
• karol updated the diff for D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
rebase
address feeedback
• karol planned changes to D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
• karol added inline comments to D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.