Yup, things are snappier now (specifically the first time the directory is cd'd into after a change has been made in the working copy)

In D6305#188783, @ashoat wrote:

I still think it's weird to have two buttons "Log in" and "Sign in" at the same time, but that will get addressed in DES-23

rebase before landing

rebase before landing

pull out siweMessageSigningExplanationStatements

Looks good. Both comments are super minor, feel free to ignore/land as-is.

In D6225#188803, @atul wrote:

It's part of my local stack, I'll create a Linear task anyways just since it's easier to track stuff there than on old/landed diffs.

In D6225#188791, @ashoat wrote:

Gotcha that makes sense, will put up diff with that change

Was this ever done? If not can you link a Linear task please?

There were more changes in this diff that I moved around to other commits... so at some point it made sense to be its own diff, but should've just squashed this with D6304

rebase before landing

MAJOR.MINOR instead of MAJOR.MINOR.PATCH for consistency

Gotcha will update to MAJOR.MINOR for consistency before landing

Didn't look too carefully, but looks right and trust Test Plan

Responding to @jon's comment and re-requesting review

👍🏽

and handle merge conflicts...

get rid of no longer relevant isDev check...

rebase before landing

rebase before making changes

In D6225#187560, @ashoat wrote:

Ah okay, then the best thing would be to have an effect that dispatches the generate nonce request if:

1. There's no nonce and there's no generateNonce call in progress, AND
2. EITHER
   • signer is set
   • SIWE button was pressed (React state that is set in onSIWEButtonClick)

In D6225#187552, @ashoat wrote:

Can't we just fetch the nonce in onSIWEButtonClick? The user still needs to press that button again if they refresh the page, right?

go back to useEffect approach

Hit siwe_nonce endpoint as soon as SIWE button is pressed

simplify boolean && arc amend

rebase before addressing feedback

👍🏽

Patched this into my local environment and cding into comm seems to continue working as expected (yarn cleaninstall, yarn dev in a few of the workspaces, etc)

openConnectModal truthiness check

rebase before landing

rebase before landing

rebase before landing

Let's revisit when discussing design