Page MenuHomePhorge
Feed Search

Apr 12 2023

jon committed rCOMMe58e6d7c11fc: [Tunnelbroker] Update example tunnelbroker.ini.
Apr 12 2023, 7:46 PM
jon updated the diff for D7392: [Tunnelbroker] Create websocket server.

Prefix env var with COMM_

Apr 12 2023, 7:16 PM
jon requested review of D7400: [Tunnelbroker] Add message types for existing protobuf messages.
Apr 12 2023, 6:34 PM
jon added a comment to D7392: [Tunnelbroker] Create websocket server.

added @ashoat since this is a new dependency.

Apr 12 2023, 2:33 PM
jon added a reviewer for D7392: [Tunnelbroker] Create websocket server: ashoat.
Apr 12 2023, 2:33 PM
jon added inline comments to D7392: [Tunnelbroker] Create websocket server.
Apr 12 2023, 2:33 PM

Apr 11 2023

jon requested review of D7392: [Tunnelbroker] Create websocket server.
Apr 11 2023, 11:44 PM
jon requested review of D7391: [Tunnelbroker] Update example tunnelbroker.ini.
Apr 11 2023, 11:40 PM
jon accepted D7370: [keyserver] Move update-geoip to an earlier step in Docker build.
Apr 11 2023, 10:06 PM
jon accepted D7390: [services] remove identity.proto.

otherwise looks fine

Apr 11 2023, 10:06 PM
jon added a comment to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.

COMM_JSONCONFIG variables are never file paths, they are always JSON blobs.

Apr 11 2023, 5:51 PM
jon requested changes to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.
Apr 11 2023, 5:46 PM
jon added a comment to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.

Yeah, that's what Shellcheck wanted me to do. But I think it's unsafe - doesn't that mean $COMM_JSONCONFIG_secrets_geoip_license won't be quoted? I think the open quote is actually closing the quote from line 13, and the close quote is actually opening a new quote. So that leaves $COMM_JSONCONFIG_secrets_geoip_license unquoted

Apr 11 2023, 5:29 PM
jon closed D7384: [Scripts] Ensure docker is running before starting localstack.
Apr 11 2023, 4:39 PM
jon committed rCOMM6bfd6f944723: [Scripts] Ensure docker is running before starting localstack.
Apr 11 2023, 4:39 PM
jon added a comment to D7384: [Scripts] Ensure docker is running before starting localstack.

Going to assume that we don't want to spend anymore time on this.

Apr 11 2023, 4:38 PM
jon requested changes to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.
Apr 11 2023, 4:32 PM
jon added a comment to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.

switched [[ -n to [[ -r, as I realized later that COMM_JSONCONFIG_secrets_geoip_license was a file path to a json config.

Apr 11 2023, 4:31 PM
jon updated the diff for D7384: [Scripts] Ensure docker is running before starting localstack.

Capitalize docker, revisit error message

Apr 11 2023, 4:02 PM
jon added inline comments to D7384: [Scripts] Ensure docker is running before starting localstack.
Apr 11 2023, 4:02 PM
jon closed D7362: [Comm-opaque2] Don't require mut self on register finish.
Apr 11 2023, 3:17 PM
jon committed rCOMM90976770fa32: [Comm-opaque2] Don't require mut self on register finish.
Apr 11 2023, 3:17 PM
jon closed D7299: [Identity] Support keygen and server setup for opaque 2.0.
Apr 11 2023, 3:17 PM
jon committed rCOMMd4e0a8b899ae: [Identity] Support keygen and server setup for opaque 2.0.
Apr 11 2023, 3:17 PM
jon requested changes to D7370: [keyserver] Move update-geoip to an earlier step in Docker build.
Apr 11 2023, 3:10 PM
jon added inline comments to D7384: [Scripts] Ensure docker is running before starting localstack.
Apr 11 2023, 2:59 PM
jon requested review of D7384: [Scripts] Ensure docker is running before starting localstack.
Apr 11 2023, 2:46 PM

Apr 8 2023

jon added inline comments to D7299: [Identity] Support keygen and server setup for opaque 2.0.
Apr 8 2023, 12:10 AM

Apr 7 2023

jon closed D7298: [Identity] Handle key payload.
Apr 7 2023, 9:53 PM
jon committed rCOMM68bbaa297a06: [Identity] Handle key payload.
Apr 7 2023, 9:53 PM
jon updated the diff for D7299: [Identity] Support keygen and server setup for opaque 2.0.

Address feedback: move secrets dir creation to it's own block

Apr 7 2023, 9:34 PM
jon updated the diff for D7298: [Identity] Handle key payload.

Rebase on master

Apr 7 2023, 9:18 PM
jon added inline comments to D7365: [Identity] Register user on native client.
Apr 7 2023, 8:43 PM
jon added a comment to D7298: [Identity] Handle key payload.

Address feedback

Apr 7 2023, 8:32 PM
jon requested review of D7365: [Identity] Register user on native client.
Apr 7 2023, 8:32 PM
jon updated the diff for D7298: [Identity] Handle key payload.

Address feedback

Apr 7 2023, 8:31 PM
jon added inline comments to D7298: [Identity] Handle key payload.
Apr 7 2023, 8:31 PM
jon added 1 blocking reviewer(s) for D7356: [keyserver] update registerUser function: ashoat.
Apr 7 2023, 8:30 PM
jon accepted D7356: [keyserver] update registerUser function.
Apr 7 2023, 8:30 PM
jon requested review of D7362: [Comm-opaque2] Don't require mut self on register finish.
Apr 7 2023, 8:21 PM
jon accepted D7361: [keyserver] update login_user_wallet function.

Looks fine for a transition commit, still missing the other X3DH elements.

Apr 7 2023, 8:20 PM
jon added inline comments to D7299: [Identity] Support keygen and server setup for opaque 2.0.
Apr 7 2023, 2:37 AM

Apr 6 2023

jon updated the diff for D7299: [Identity] Support keygen and server setup for opaque 2.0.

Address feedback

Apr 6 2023, 3:27 PM
jon added inline comments to D7298: [Identity] Handle key payload.
Apr 6 2023, 2:22 PM
jon updated the diff for D7298: [Identity] Handle key payload.

Address feedback

Apr 6 2023, 2:22 PM

Apr 4 2023

jon requested review of D7299: [Identity] Support keygen and server setup for opaque 2.0.
Apr 4 2023, 5:34 PM
jon requested review of D7298: [Identity] Handle key payload.
Apr 4 2023, 3:25 PM
jon accepted D7296: [nix] Set db variables in our local environments.

looks good to me from a bash perspective

Apr 4 2023, 2:26 PM

Apr 3 2023

jon added a comment to D7258: [identity] config for LocalStack.

Looks like i got distracted friday

Apr 3 2023, 1:56 PM

Mar 30 2023

jon added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 30 2023, 7:56 PM
jon closed D7241: [Identity] Add opaque2 users table.
Mar 30 2023, 6:46 PM
jon committed rCOMM65fc365ec0e5: [Identity] Add opaque2 users table.
Mar 30 2023, 6:46 PM
jon added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 30 2023, 6:45 PM
jon updated the diff for D7241: [Identity] Add opaque2 users table.

Remove primaryDevice, reference protobuf file

Mar 30 2023, 6:06 PM
jon accepted D7247: [nix] add tool to identify unused dependencies in Cargo projects.
Mar 30 2023, 2:51 PM

Mar 29 2023

jon updated the diff for D7241: [Identity] Add opaque2 users table.

Address more feedback

Mar 29 2023, 10:06 PM
jon added inline comments to D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 10:06 PM
jon updated the diff for D7241: [Identity] Add opaque2 users table.

Add device type

Mar 29 2023, 8:00 PM
jon requested review of D7241: [Identity] Add opaque2 users table.
Mar 29 2023, 6:35 PM
jon accepted D7229: [native] more one-time setup for rust-C++ integration.
Mar 29 2023, 2:15 PM

Mar 28 2023

jon accepted D7215: [native] make generateNonce callable from js.

rust looks okay to me. Just don't like that the callee has to have awareness of the promise ID.

Mar 28 2023, 10:10 PM
jon closed D7197: [Web] Package opaque-ke-wasm files.
Mar 28 2023, 5:45 PM
jon committed rCOMMac918b353479: [Web] Package opaque-ke-wasm files.
Mar 28 2023, 5:45 PM
jon accepted D7221: [native] one-time setup for rust-C++ integration.
Mar 28 2023, 5:44 PM
jon requested changes to D7215: [native] make generateNonce callable from js.
Mar 28 2023, 5:43 PM
jon added a comment to D7197: [Web] Package opaque-ke-wasm files.

address feedback

Mar 28 2023, 3:42 PM
jon updated the diff for D7197: [Web] Package opaque-ke-wasm files.

Remove index.js stub

Mar 28 2023, 3:41 PM
jon added a comment to D7212: [lib][web][native] Introduce commServicesAccessToken to Redux state.

LGTM, ill defer to react/redux people for correctness

Mar 28 2023, 3:38 PM
jon added a comment to D7215: [native] make generateNonce callable from js.

I don't feel strongly about the rust code, which is ephemeral anyway.

Mar 28 2023, 3:37 PM
jon accepted D7214: [native] introduce RustCallback.

I'm not able to comment on gradle code, but I couldn't find a better way to do this using just cmake + corrosion + cxxbridge

Mar 28 2023, 3:25 PM
jon accepted D7213: [services][identity] implement generate_nonce RPC in new client_service..
Mar 28 2023, 3:13 PM

Mar 27 2023

jon added inline comments to D7197: [Web] Package opaque-ke-wasm files.
Mar 27 2023, 9:20 PM
jon closed D7200: [Comm-opaque2] Add grpc helper for wrapped protocol error.
Mar 27 2023, 9:19 PM
jon closed D7198: [Native] Update native_rust_library ffi to reflect client gRPC.
Mar 27 2023, 9:19 PM
jon committed rCOMMd0fc17f6bff6: [Native] Update native_rust_library ffi to reflect client gRPC.
Mar 27 2023, 9:19 PM
jon committed rCOMM55cc878c6f31: [Comm-opaque2] Add grpc helper for wrapped protocol error.
Mar 27 2023, 9:19 PM
jon closed D7155: [Native] Migrate native_rust_library to use identity client stubs.
Mar 27 2023, 9:19 PM
jon committed rCOMMb36dd5c724a0: [Native] Migrate native_rust_library to use identity client stubs.
Mar 27 2023, 9:19 PM
jon added a comment to D7197: [Web] Package opaque-ke-wasm files.

After running yarn arcpatch D7197, I noticed that the commit before this one is D7155. Does this work depend on D7155? If so, can you specify the stack on Phabricator?

Mar 27 2023, 9:15 PM
jon added a comment to D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.

Nothing looks super surprising here, thanks!

Mar 27 2023, 9:11 PM
jon added inline comments to rCOMM734a1b6e6a29: [native] RustPromiseManager.
Mar 27 2023, 6:21 PM
jon added inline comments to rCOMM734a1b6e6a29: [native] RustPromiseManager.
Mar 27 2023, 6:10 PM
jon added inline comments to rCOMM734a1b6e6a29: [native] RustPromiseManager.
Mar 27 2023, 6:03 PM
jon requested review of D7200: [Comm-opaque2] Add grpc helper for wrapped protocol error.
Mar 27 2023, 5:58 PM
jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
Mar 27 2023, 4:23 PM
jon added inline comments to D7155: [Native] Migrate native_rust_library to use identity client stubs.
Mar 27 2023, 4:21 PM
jon retitled D7197: [Web] Package opaque-ke-wasm files from [Web] Package wasm files
Mar 27 2023, 4:14 PM
jon requested review of D7198: [Native] Update native_rust_library ffi to reflect client gRPC.
Mar 27 2023, 4:12 PM
jon requested review of D7155: [Native] Migrate native_rust_library to use identity client stubs.
Mar 27 2023, 3:17 PM
jon added inline comments to D7197: [Web] Package opaque-ke-wasm files.
Mar 27 2023, 2:49 PM
jon requested review of D7197: [Web] Package opaque-ke-wasm files.
Mar 27 2023, 2:49 PM

Mar 23 2023

jon accepted D7150: [web] Scaffolding for opaque-ke-wasm project.

A little out my expertise for best practcies, but looks good

Mar 23 2023, 6:59 PM
jon closed D7115: [Identity] Update X3DH protobuf to differiente key requests.
Mar 23 2023, 5:28 PM
jon committed rCOMMd57e287befb0: [Identity] Update X3DH protobuf to differiente key requests.
Mar 23 2023, 5:28 PM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Rebase on master

Mar 23 2023, 3:36 PM
jon closed D7130: [Identity] Add client device service to identity service.
Mar 23 2023, 3:06 PM
jon committed rCOMMfbcb3b1a9578: [Identity] Add client device service to identity service.
Mar 23 2023, 3:06 PM
jon closed D7116: [Comm-opaque2] Change project name to avoid name clash.
Mar 23 2023, 3:06 PM
jon committed rCOMMce0700acc32b: [Comm-opaque2] Change project name to avoid name clash.
Mar 23 2023, 3:06 PM
jon added inline comments to D7115: [Identity] Update X3DH protobuf to differiente key requests.
Mar 23 2023, 2:50 PM