address feedback

rebase before landing

address comments

address comments

In general I think small utility functions like this should be introduced alongside their callsite, to make it easier for the reviewer to understand why / how they're being introduced. A good rule of thumb (not a hard rule) is whether you have unit tests for it.

rebase before landing

rebase before landing

forgot to add !

address comments

rebase before landing

rebase before landing

rebase before landing

address ashoat's comments

addressed ashoat's comments

remove avatar specific entries and changed name of loginText => whiteText

address ashoat's comments

rubber stamping

Addressing all the feedback for the saving avatar UX made this diff very large. I will split this diff into two to make it easier to review. This diff will handle purely all the UI and frontend user interactions (visual layout, picking a new emoji, picking a new color, and resetting the avatar), and the next diff will handle all the behavior when a user hits save (displaying a loading state, saving the avatar, and showing an error or success depending on the results of the response)

Splitting this diff into two, this is part 1

You can actually just call displayActionResultModal("string") to use our existing "toast" functionality. It doesn't look like that design but it's easy to use and better than nothing

rebase before landing

looks good, but will defer to @ashoat for the final say

Separately, can you clarify where the loading indicator will be displayed?

Removing diff from my reviewers queue as I address improving the behavior after a user saves

I can't tell what the issue is in the before video

Does it make sense to just remove EDIT_THREAD_NAME permissions for threadTypes.PERSONAL now, so we don't have to run another migration for that?