Page MenuHomePhorge
Feed Search

Jun 5 2023

jon accepted D8061: [identity] validate signed message from keyserver.
Jun 5 2023, 4:36 PM
jon requested review of D8090: [Protos] Use outbound key bundle for keyserver information.
Jun 5 2023, 12:07 AM

Jun 2 2023

jon added a comment to D8066: [identity] update login_password_user_start and register_password_user_start.

Since this is just a migration code path, I'm okay with it.

Jun 2 2023, 3:41 PM
jon added a comment to D8062: [identity] register_reserved_password_user_start method.

Looks fine to me, let bartek have a look

Jun 2 2023, 3:34 PM
jon accepted D8061: [identity] validate signed message from keyserver.

rust looks fine. Not a big fan of parsing text for certain values though.

Jun 2 2023, 3:32 PM
jon accepted D8060: [identity] db methods for reserved usernames table.
Jun 2 2023, 3:13 PM
jon accepted D8059: [services] add reserved usernames table to ddb.
Jun 2 2023, 3:13 PM

Jun 1 2023

jon added a comment to D7702: [Keyserver] Introduce tunnelbroker types.

but I'm not clear on how all of them connect to the JS.

Jun 1 2023, 7:19 PM
jon requested review of D8052: [Keyserver] Use olm identity key for tunnelbroker connection.
Jun 1 2023, 2:29 PM
jon closed D7801: [Tunnelbroker] Remove usages of unwrap and expect.
Jun 1 2023, 2:15 PM
jon closed D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
Jun 1 2023, 2:15 PM
jon committed rCOMM9372f4589dfc: [Tunnelbroker] Remove usages of unwrap and expect.
Jun 1 2023, 2:15 PM
jon committed rCOMMe9209308664f: [Tunnelbroker] Refactor connection lifetimes into session object.
Jun 1 2023, 2:15 PM
jon closed D7799: [Tunnelbroker] Initial message persistence.
Jun 1 2023, 2:15 PM
jon committed rCOMMfadf7a78b5bf: [Tunnelbroker] Initial message persistence.
Jun 1 2023, 2:15 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Use SORT_KEY

Jun 1 2023, 1:17 PM

May 31 2023

jon added inline comments to D7799: [Tunnelbroker] Initial message persistence.
May 31 2023, 10:11 PM
jon updated the diff for D7801: [Tunnelbroker] Remove usages of unwrap and expect.

Rebase on master and feedback in other diffs

May 31 2023, 10:10 PM
jon updated the diff for D7800: [Tunnelbroker] Refactor connection lifetimes into session object.

Rebase on previous changes

May 31 2023, 10:09 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Rebase on master

May 31 2023, 10:08 PM
jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Address feedback

May 31 2023, 10:00 PM
jon updated the diff for D7702: [Keyserver] Introduce tunnelbroker types.

Apply feedback, rebase on master

May 31 2023, 9:51 PM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Rebase on master

May 31 2023, 9:50 PM

May 30 2023

jon requested review of D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 30 2023, 2:09 PM
jon requested review of D7801: [Tunnelbroker] Remove usages of unwrap and expect.
May 30 2023, 1:19 PM

May 25 2023

jon added inline comments to D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
May 25 2023, 5:28 PM
jon added 1 blocking reviewer(s) for D7799: [Tunnelbroker] Initial message persistence: varun.
May 25 2023, 5:19 PM
jon added inline comments to D7799: [Tunnelbroker] Initial message persistence.
May 25 2023, 5:19 PM

May 24 2023

jon closed D7768: [Tunnelbroker] Encapsulate message handling with Session object.
May 24 2023, 9:36 PM
jon closed D7767: [Nix] Add more support for localstack.
May 24 2023, 9:36 PM
jon committed rCOMM2d363478ca09: [Nix] Add more support for localstack.
May 24 2023, 9:36 PM
jon closed D7720: [Tunnelbroker] Define undelivered-messages table in rust.
May 24 2023, 9:36 PM
jon committed rCOMMff9971449268: [Tunnelbroker] Encapsulate message handling with Session object.
May 24 2023, 9:36 PM
jon closed D7717: [Tunnelbroker] Remove existing tunnelbroker tables.
May 24 2023, 9:36 PM
jon closed D7718: [Tunnelbroker] Create undelivered messages table.
May 24 2023, 9:36 PM
jon committed rCOMMb76141925bbf: [Tunnelbroker] Define undelivered-messages table in rust.
May 24 2023, 9:36 PM
jon committed rCOMM0ca7602266d2: [Tunnelbroker] Remove existing tunnelbroker tables.
May 24 2023, 9:36 PM
jon committed rCOMMfa4a6ccb98f6: [Tunnelbroker] Create undelivered messages table.
May 24 2023, 9:36 PM
jon closed D7715: [Tunnelbroker] Add aws-sdk support, and cli configuration.
May 24 2023, 9:36 PM
jon closed D7734: [Tunnelbroker] Add initial dynamodb client.
May 24 2023, 9:36 PM
jon committed rCOMMf4bd822c8982: [Tunnelbroker] Add aws-sdk support, and cli configuration.
May 24 2023, 9:36 PM
jon committed rCOMM2a76743ddaed: [Tunnelbroker] Add initial dynamodb client.
May 24 2023, 9:36 PM
jon closed D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.
May 24 2023, 9:36 PM
jon committed rCOMM2b1c93c35ba5: [Tunnelbroker] Route refreshkeys request to websocket connection.
May 24 2023, 9:36 PM

May 12 2023

jon updated the diff for D7799: [Tunnelbroker] Initial message persistence.

Rebase on master

May 12 2023, 11:33 PM
jon updated the diff for D7768: [Tunnelbroker] Encapsulate message handling with Session object.

Rebase on master

May 12 2023, 11:33 PM
jon updated the diff for D7767: [Nix] Add more support for localstack.

Rebase on master

May 12 2023, 11:33 PM
jon updated the diff for D7720: [Tunnelbroker] Define undelivered-messages table in rust.

Rebase on master

May 12 2023, 11:33 PM
jon updated the diff for D7718: [Tunnelbroker] Create undelivered messages table.

Rebase on master

May 12 2023, 11:32 PM
jon updated the diff for D7717: [Tunnelbroker] Remove existing tunnelbroker tables.

Rebase on master

May 12 2023, 11:32 PM
jon updated the diff for D7734: [Tunnelbroker] Add initial dynamodb client.

Rebase on master

May 12 2023, 11:32 PM
jon updated the diff for D7715: [Tunnelbroker] Add aws-sdk support, and cli configuration.

Rebase on master

May 12 2023, 11:32 PM
jon added inline comments to D7768: [Tunnelbroker] Encapsulate message handling with Session object.
May 12 2023, 11:29 PM
jon requested review of D7801: [Tunnelbroker] Remove usages of unwrap and expect.
May 12 2023, 10:31 PM
jon requested review of D7800: [Tunnelbroker] Refactor connection lifetimes into session object.
May 12 2023, 9:52 PM
jon updated the diff for D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.

Minor fixups, rebase on master

May 12 2023, 9:33 PM
jon requested review of D7799: [Tunnelbroker] Initial message persistence.
May 12 2023, 4:51 AM

May 10 2023

jon added inline comments to D7767: [Nix] Add more support for localstack.
May 10 2023, 2:24 PM
jon requested review of D7768: [Tunnelbroker] Encapsulate message handling with Session object.
May 10 2023, 7:15 AM
jon requested review of D7767: [Nix] Add more support for localstack.
May 10 2023, 6:40 AM
jon updated the diff for D7720: [Tunnelbroker] Define undelivered-messages table in rust.

Add SORT_KEY alias

May 10 2023, 6:31 AM
jon added inline comments to D7718: [Tunnelbroker] Create undelivered messages table.
May 10 2023, 6:17 AM
jon updated the diff for D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.

Apply feedback

May 10 2023, 6:13 AM
jon updated the diff for D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.

Address feedback

May 10 2023, 6:10 AM

May 5 2023

jon requested review of D7718: [Tunnelbroker] Create undelivered messages table.
May 5 2023, 9:03 PM
jon requested review of D7717: [Tunnelbroker] Remove existing tunnelbroker tables.
May 5 2023, 8:58 PM
jon requested review of D7734: [Tunnelbroker] Add initial dynamodb client.
May 5 2023, 8:54 PM
jon added inline comments to D7702: [Keyserver] Introduce tunnelbroker types.
May 5 2023, 8:44 PM
jon added a comment to D7702: [Keyserver] Introduce tunnelbroker types.

Just noticed that VerifyUserAccessTokenRequest requires userID – does that need to be included in TBSharedConnectionInitializationMessage too?

May 5 2023, 8:44 PM
jon updated the diff for D7715: [Tunnelbroker] Add aws-sdk support, and cli configuration.

Remove JS commits in git history to avoid CI failures

May 5 2023, 8:34 PM
jon added inline comments to D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.
May 5 2023, 8:31 PM
jon updated the diff for D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.

Address feedback

May 5 2023, 8:31 PM

May 4 2023

jon requested review of D7720: [Tunnelbroker] Define undelivered-messages table in rust.
May 4 2023, 6:09 PM
jon updated the diff for D7702: [Keyserver] Introduce tunnelbroker types.

fixup

May 4 2023, 5:26 PM
jon added inline comments to D7702: [Keyserver] Introduce tunnelbroker types.
May 4 2023, 5:22 PM
jon updated the diff for D7702: [Keyserver] Introduce tunnelbroker types.

Rename SessionRequest to ConnectionInitializationMessage

May 4 2023, 5:22 PM
jon updated the diff for D7715: [Tunnelbroker] Add aws-sdk support, and cli configuration.

Update aws_config

May 4 2023, 4:47 PM
jon requested review of D7715: [Tunnelbroker] Add aws-sdk support, and cli configuration.
May 4 2023, 4:01 PM
jon added a comment to D7702: [Keyserver] Introduce tunnelbroker types.

removed deviceOS and deviceAppVersion. As I think those were "legacy" concepts from the previous tunnelbroker paradigms. Those details should exist in the identity server, and should be available once we authenticate sessions.

May 4 2023, 4:00 PM
jon added inline comments to D7702: [Keyserver] Introduce tunnelbroker types.
May 4 2023, 3:58 PM
jon updated the diff for D7702: [Keyserver] Introduce tunnelbroker types.

Address feedback

May 4 2023, 3:58 PM
jon requested review of D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 4 2023, 3:51 PM
jon planned changes to D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 4 2023, 3:50 PM
jon updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

Address feedback

May 4 2023, 3:48 PM

May 3 2023

jon requested changes to D7705: [keyserver] rewrite getCommConfig in Rust.
May 3 2023, 2:32 AM
jon added a comment to D7705: [keyserver] rewrite getCommConfig in Rust.

I think a better solution long term would be to have a struct which reflects the values specific to the config in question:

#[derive(Serialize, Deserialize)]
pub struct KeyserverConfig {
  password: String,
  database: String,
  dbType: String,
  host: String
  user: String
}
May 3 2023, 2:32 AM
jon requested review of D7702: [Keyserver] Introduce tunnelbroker types.
May 3 2023, 12:56 AM
jon requested review of D7693: [Tunnelbroker] Route refreshkeys request to websocket connection.
May 3 2023, 12:47 AM
jon requested review of D7691: [Keyserver] Open websocket connection with tunnelbroker.
May 3 2023, 12:46 AM
jon accepted D7706: [native] login password user on native (rust changes).
May 3 2023, 12:43 AM
jon accepted D7694: [native] register user on native (rust changes).
May 3 2023, 12:40 AM

May 1 2023

jon accepted D7687: [blob-service] Set up CORS.
May 1 2023, 7:16 PM
jon requested changes to D7694: [native] register user on native (rust changes).
May 1 2023, 6:55 PM
jon closed D7661: [Tunnelbroker] Add integration tests.
May 1 2023, 5:31 AM
jon committed rCOMM2bead14e6f9c: [Tunnelbroker] Add integration tests.
May 1 2023, 5:31 AM
jon closed D7659: [Tunnelbroker] Remove references to cxx.
May 1 2023, 5:31 AM
jon committed rCOMMebb0fd5c9a2f: [Tunnelbroker] Remove references to cxx.
May 1 2023, 5:30 AM
jon added inline comments to D7661: [Tunnelbroker] Add integration tests.
May 1 2023, 5:28 AM
jon closed D7671: [Identity] Use content to describe main olm account.
May 1 2023, 5:20 AM
jon committed rCOMM3967ccade4fd: [Identity] Use content to describe main olm account.
May 1 2023, 5:20 AM