Page MenuHomePhabricator
Feed Advanced Search

Aug 25 2022

jacek committed rCOMM78415a2144f5: [native] Introduce `inlineSidebar` animation when opening message tooltip to… (authored by jacek).
[native] Introduce `inlineSidebar` animation when opening message tooltip to…
Aug 25 2022, 1:39 AM
jacek committed rCOMMa9a0c58936cc: [native] Redesign `InlineSidebar` for reactions feature (authored by jacek).
[native] Redesign `InlineSidebar` for reactions feature
Aug 25 2022, 1:39 AM
jacek closed D4823: [lib] Make `useInlineSidebarText` hook parameter optional.
Aug 25 2022, 1:39 AM
jacek committed rCOMMbb563918728b: [lib] Make `useInlineSidebarText` hook parameter optional (authored by jacek).
[lib] Make `useInlineSidebarText` hook parameter optional
Aug 25 2022, 1:39 AM

Aug 24 2022

jacek updated the diff for D4824: [native] Redesign `InlineSidebar` for reactions feature.

Address Tomek's comments

Aug 24 2022, 2:23 AM

Aug 23 2022

jacek published D4924: [web] Redesign `InlineSidebar` with reactions support for review.
Aug 23 2022, 8:07 AM
jacek published D4923: [web] Remove old tooltip components for review.
Aug 23 2022, 8:06 AM
jacek published D4922: [web] Remove timestamp tooltip from `ChatMessageList` for review.
Aug 23 2022, 8:06 AM
jacek published D4921: [web] Use new tooltip in robotext message for review.
Aug 23 2022, 8:06 AM
jacek published D4920: [web] Use new tooltip in composed message for review.
Aug 23 2022, 8:06 AM
jacek published D4919: [web] Wrap app content with `TooltipProvider` for review.
Aug 23 2022, 8:06 AM
jacek published D4918: [web] Introduce `useMessageTooltipActions` hooks for review.
Aug 23 2022, 8:06 AM
jacek published D4917: [web] Introduce `useMessageTooltipReplyAction` hook for review.
Aug 23 2022, 8:06 AM
jacek published D4916: [web] Introduce `useMessageTooltipSidebarAction` hook for review.
Aug 23 2022, 8:06 AM
jacek published D4915: [web] Introduce `getMessageActionTooltipStyle` util function for review.
Aug 23 2022, 8:06 AM
jacek published D4914: [web] Introduce `calculateTooltipSize` util function for review.
Aug 23 2022, 8:06 AM
jacek published D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic for review.
Aug 23 2022, 8:06 AM
jacek published D4912: [web] Refactor `MessageTooltip` component for review.
Aug 23 2022, 8:06 AM
jacek published D4911: [web] Introduce tooltip container with positioning in `TooltipContext` for review.
Aug 23 2022, 8:06 AM
jacek published D4910: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext` for review.
Aug 23 2022, 8:06 AM
jacek published D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext` for review.
Aug 23 2022, 8:06 AM
jacek published D4908: [web] Introduce `TooltipContext` for review.
Aug 23 2022, 8:06 AM

Aug 17 2022

jacek attached a referenced file: F141081: Screenshot_Simulator_2022-08-17_122521.mp4.
Aug 17 2022, 8:37 AM
jacek updated the diff for D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..

Address Atul's and Ashoat's comments

Aug 17 2022, 4:50 AM
jacek updated the diff for D4824: [native] Redesign `InlineSidebar` for reactions feature.

Address Atul's suggestions

Aug 17 2022, 4:27 AM
jacek updated the diff for D4823: [lib] Make `useInlineSidebarText` hook parameter optional.

optimize dependency array

Aug 17 2022, 4:26 AM
jacek added inline comments to D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..
Aug 17 2022, 3:36 AM

Aug 16 2022

jacek updated the diff for D4823: [lib] Make `useInlineSidebarText` hook parameter optional.

address Tomek's comment

Aug 16 2022, 6:03 AM
jacek closed D4806: [native] Fix message tooltip positioning for robotext with sidebar.
Aug 16 2022, 5:21 AM
jacek committed rCOMM0971b214372a: [native] Fix message tooltip positioning for robotext with sidebar (authored by jacek).
[native] Fix message tooltip positioning for robotext with sidebar
Aug 16 2022, 5:21 AM
jacek added a comment to D4824: [native] Redesign `InlineSidebar` for reactions feature.
In D4824#139635, @atul wrote:

Are values like inlineSidebarLeftTopOffset also expected to be used outside of the ComposedMessage component? If not, can we just set the values in the ComposedMessage styles object to avoid indirection?

Yes, these values will be used in TooltipInlineSidebar in next diff to correctly set its position.

Aug 16 2022, 4:03 AM
jacek added inline comments to D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..
Aug 16 2022, 3:28 AM

Aug 12 2022

jacek added inline comments to D4823: [lib] Make `useInlineSidebarText` hook parameter optional.
Aug 12 2022, 6:18 AM
jacek published D4823: [lib] Make `useInlineSidebarText` hook parameter optional for review.
Aug 12 2022, 3:15 AM
jacek published D4824: [native] Redesign `InlineSidebar` for reactions feature for review.
Aug 12 2022, 3:14 AM
jacek published D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues. for review.
Aug 12 2022, 3:13 AM
jacek accepted D4812: [web] Persist enabled apps using default storage engine.

I confirm it works!

Aug 12 2022, 1:18 AM

Aug 11 2022

jacek added a comment to D4806: [native] Fix message tooltip positioning for robotext with sidebar.

Does this have any visual effect (outside of fixing ENG-1591)?

Aug 11 2022, 7:32 AM
jacek requested review of D4806: [native] Fix message tooltip positioning for robotext with sidebar.
Aug 11 2022, 4:08 AM

Aug 8 2022

jacek closed D4711: [lib] Fix `getPotentialMemberItems` to match server logic for adding users to threads in community.
Aug 8 2022, 4:32 AM
jacek committed rCOMMa21d29460a8c: [lib] Fix `getPotentialMemberItems` to match server logic for adding users to… (authored by jacek).
[lib] Fix `getPotentialMemberItems` to match server logic for adding users to…
Aug 8 2022, 4:32 AM
jacek closed D4710: [keyserver] Fix keyserver to allow adding non-friends from the same community to thread.
Aug 8 2022, 4:32 AM
jacek committed rCOMM268140407926: [keyserver] Fix keyserver to allow adding non-friends from the same community… (authored by jacek).
[keyserver] Fix keyserver to allow adding non-friends from the same community…
Aug 8 2022, 4:32 AM
jacek updated the diff for D4711: [lib] Fix `getPotentialMemberItems` to match server logic for adding users to threads in community.

remove double negation

Aug 8 2022, 1:19 AM

Aug 4 2022

jacek updated the diff for D4711: [lib] Fix `getPotentialMemberItems` to match server logic for adding users to threads in community.

use getContainingThreadID

Aug 4 2022, 7:47 AM

Aug 3 2022

jacek closed D4681: [web] Include `Relationship` tab in thread settings modal.
Aug 3 2022, 4:27 AM
jacek closed D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.
Aug 3 2022, 4:27 AM
jacek committed rCOMM0bd92b5ec2a1: [web] Introduce `ThreadSettingsRelationshipTab` component (authored by jacek).
[web] Introduce `ThreadSettingsRelationshipTab` component
Aug 3 2022, 4:27 AM
jacek committed rCOMMd6a365cf5e30: [web] Include `Relationship` tab in thread settings modal (authored by jacek).
[web] Include `Relationship` tab in thread settings modal
Aug 3 2022, 4:27 AM
jacek closed D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
Aug 3 2022, 4:27 AM
jacek closed D4678: [lib] Introduce shared `getRelationshipActionText` function.
Aug 3 2022, 4:27 AM
jacek committed rCOMM1ac8fb7357f8: [web] Introduce `ThreadSettingsRelationshipButton` component (authored by jacek).
[web] Introduce `ThreadSettingsRelationshipButton` component
Aug 3 2022, 4:27 AM
jacek committed rCOMM8aec1c68e78f: [lib] Introduce shared `getRelationshipActionText` function (authored by jacek).
[lib] Introduce shared `getRelationshipActionText` function
Aug 3 2022, 4:27 AM
jacek closed D4677: [lib] Introduce shared `getRelationshipDispatchAction` function.
Aug 3 2022, 4:27 AM
jacek committed rCOMMe062e9755868: [lib] Introduce shared `getRelationshipDispatchAction` function (authored by jacek).
[lib] Introduce shared `getRelationshipDispatchAction` function
Aug 3 2022, 4:27 AM
jacek published D4710: [keyserver] Fix keyserver to allow adding non-friends from the same community to thread for review.
Aug 3 2022, 4:19 AM
jacek published D4711: [lib] Fix `getPotentialMemberItems` to match server logic for adding users to threads in community for review.
Aug 3 2022, 4:19 AM

Aug 2 2022

jacek added a comment to D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
In D4679#134458, @jacek wrote:
In D4679#134441, @tomek wrote:

I think we should consider having consistent relationship action colors through the app. So green when we send / accept and red when we decline / block. @ashoat what do you think?

In native, we use the same color for every action. Probably such change will require adding some "green" variant of button because we don't have such one on web.

Maybe we can create a backlog task? I agree it would be nice to be more consistent with the colors, but don't want to slow down our progress on feature work. Ultimately we'll probably end up needing to redesign most of this after a designer takes a look.

Aug 2 2022, 3:25 AM
jacek added inline comments to D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
Aug 2 2022, 3:15 AM
jacek updated the diff for D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.

Moved loading status selector, change updateRelationshipsAction callback name

Aug 2 2022, 3:05 AM
jacek updated the diff for D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.

Move createLoadingStatusSelector into Button component & simplify sintax

Aug 2 2022, 2:35 AM
jacek updated the diff for D4677: [lib] Introduce shared `getRelationshipDispatchAction` function.

Fix imports

Aug 2 2022, 2:11 AM
jacek closed D4692: [web] Render `ChatMessageList` only if `activeChatThreadID` exists.
Aug 2 2022, 1:53 AM
jacek committed rCOMM41a31588fe4f: [web] Render `ChatMessageList` only if `activeChatThreadID` exists (authored by jacek).
[web] Render `ChatMessageList` only if `activeChatThreadID` exists
Aug 2 2022, 1:53 AM
jacek accepted D4705: [web] Finish styling `MessageTimestampTooltip`.
Aug 2 2022, 1:06 AM

Aug 1 2022

jacek added inline comments to D4692: [web] Render `ChatMessageList` only if `activeChatThreadID` exists.
Aug 1 2022, 6:56 AM
jacek requested review of D4692: [web] Render `ChatMessageList` only if `activeChatThreadID` exists.
Aug 1 2022, 6:43 AM

Jul 29 2022

jacek updated the diff for D4681: [web] Include `Relationship` tab in thread settings modal.

rebase & remove unnecessary props

Jul 29 2022, 8:50 AM
jacek updated the diff for D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.

Disable buttons basing on loading status

Jul 29 2022, 8:49 AM
jacek updated the diff for D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.

improvements after Tomek's review

Jul 29 2022, 8:47 AM
jacek added inline comments to D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
Jul 29 2022, 8:22 AM
jacek attached a referenced file: F120901: Screenshot_Google Chrome_2022-07-29_153615.png.
Jul 29 2022, 6:38 AM
jacek added inline comments to D4681: [web] Include `Relationship` tab in thread settings modal.
Jul 29 2022, 6:37 AM
jacek added inline comments to D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.
Jul 29 2022, 6:35 AM
jacek added a comment to D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
In D4679#134441, @tomek wrote:

I think we should consider having consistent relationship action colors through the app. So green when we send / accept and red when we decline / block. @ashoat what do you think?

Jul 29 2022, 6:27 AM
jacek requested review of D4681: [web] Include `Relationship` tab in thread settings modal.
Jul 29 2022, 3:36 AM
jacek updated the summary of D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
Jul 29 2022, 3:26 AM
jacek updated the summary of D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.
Jul 29 2022, 3:24 AM
jacek requested review of D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.
Jul 29 2022, 3:18 AM
jacek requested review of D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.
Jul 29 2022, 3:16 AM
jacek requested review of D4678: [lib] Introduce shared `getRelationshipActionText` function.
Jul 29 2022, 3:12 AM
jacek requested review of D4677: [lib] Introduce shared `getRelationshipDispatchAction` function.
Jul 29 2022, 3:11 AM

Jul 28 2022

jacek closed D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 6:43 AM
jacek committed rCOMMa392b9af4a6e: [web] Fix: Inbox spacing regression (authored by jacek).
[web] Fix: Inbox spacing regression
Jul 28 2022, 6:43 AM
jacek closed D4665: [web] Fix: MessageList spacing regression.
Jul 28 2022, 6:43 AM
jacek committed rCOMM1350f621b767: [web] Fix: MessageList spacing regression (authored by jacek).
[web] Fix: MessageList spacing regression
Jul 28 2022, 6:43 AM
jacek added inline comments to D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 6:27 AM
jacek updated the summary of D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 6:26 AM
jacek updated the diff for D4666: [web] Fix: Inbox spacing regression.

Updated Tabs component after discussion with Tomek

Jul 28 2022, 6:18 AM
jacek planned changes to D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 5:49 AM
jacek requested review of D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 5:35 AM
jacek requested review of D4666: [web] Fix: Inbox spacing regression.
Jul 28 2022, 4:01 AM
jacek accepted D4640: [web] Remove creating a new siedebar/thread with an empty message.

Seems to work correctly now!

Jul 28 2022, 4:00 AM
jacek requested review of D4665: [web] Fix: MessageList spacing regression.
Jul 28 2022, 3:19 AM

Jul 27 2022

jacek closed D4644: [lib] Rename `locallyUnique...` to `pending...` to improve readability.
Jul 27 2022, 7:19 AM
jacek committed rCOMM12df9759f072: [lib] Rename `locallyUnique...` to `pending...` to improve readability (authored by jacek).
[lib] Rename `locallyUnique...` to `pending...` to improve readability
Jul 27 2022, 7:18 AM

Jul 26 2022

jacek closed D4611: [web] Open `SidebarsModal` instead `SidebarListModal` on web.
Jul 26 2022, 8:30 AM
jacek closed D4612: [web] Remove old `SidebarListModal` component.
Jul 26 2022, 8:30 AM
jacek committed rCOMM5b394475454f: [web] Remove old `SidebarListModal` component (authored by jacek).
[web] Remove old `SidebarListModal` component
Jul 26 2022, 8:30 AM
jacek committed rCOMM0c96ab193d41: [web] Open `SidebarsModal` instead `SidebarListModal` on web (authored by jacek).
[web] Open `SidebarsModal` instead `SidebarListModal` on web
Jul 26 2022, 8:30 AM