Page MenuHomePhabricator
Feed Advanced Search

Jul 20 2022

atul renamed jim from jimpo to jim.
Jul 20 2022, 11:34 AM

Jun 23 2022

jim accepted D4289: [services][identity] subroutine for generating token and writing it to db.
Jun 23 2022, 8:08 AM

Jun 17 2022

jim requested changes to D4289: [services][identity] subroutine for generating token and writing it to db.
Jun 17 2022, 2:13 PM
jim requested changes to D4285: [services][identity] wallet login.
Jun 17 2022, 11:53 AM

Jun 14 2022

jim accepted D4199: [services][identity] implement verify_user_token rpc.
Jun 14 2022, 2:43 PM
jim added inline comments to D4199: [services][identity] implement verify_user_token rpc.
Jun 14 2022, 7:19 AM

Jun 13 2022

jim requested changes to D4199: [services][identity] implement verify_user_token rpc.
Jun 13 2022, 9:35 AM

Jun 7 2022

jim requested changes to D4148: [services][identity] helper function to finish PAKE login.

I don't think this helper function is necessary -- logic can be inlined. Feel free to argue otherwise.

Jun 7 2022, 8:26 AM

Jun 6 2022

jim requested changes to D4147: [services][identity] helper function to start pake login.
Jun 6 2022, 9:21 AM
jim accepted D3965: [services] Tunnelbroker - Add dynamoDB tables to the Terraform.

The duplication between dynamodb and dynamodb-test is a problem. We should investigate this in a follow-up: from the localstack docs, it looks like separate databases with separate tables are created for each credential that connects https://docs.localstack.cloud/localstack/configuration/#dynamodb. So ideally terraform would just create the tables twice somehow with different credentials, one for test and one for dev.

Jun 6 2022, 9:16 AM

Jun 3 2022

jim requested changes to D4182: [services][identity] helper function to handle sign-in with ethereum.

wallet_login just doesn't seem necessary. What's wrong with the existing siwe API you're calling in this helper?

Jun 3 2022, 8:30 AM
jim requested changes to D4140: [services][identity] helper function to handle pake registration.
Jun 3 2022, 8:23 AM
jim accepted D4146: [services][identity] helper function to finish pake registration.
Jun 3 2022, 8:16 AM

May 27 2022

jim accepted D3957: [Identity] DatabaseClient method to get user token.
May 27 2022, 12:05 PM

May 24 2022

jim requested changes to D3957: [Identity] DatabaseClient method to get user token.

First, break this into subroutines for readability and reuse across DB fetchers. Like you should have functions parseTimestampAttribute, parseAuthType, etc and call parseTimestampAttribute(item.remove("created")).

May 24 2022, 12:47 PM
jim accepted D3959: [Identity] Token constructor.
May 24 2022, 12:22 PM
jim accepted D3945: [Identity] Add new types to handle tokens.
May 24 2022, 12:21 PM

May 19 2022

jim accepted D4015: [services][identity] helper function to create primary key for DynamoDB.
May 19 2022, 7:21 AM

May 17 2022

jim accepted D3921: [Identity] Implement database client method to get pake registration.
May 17 2022, 8:23 AM
jim added a comment to D4015: [services][identity] helper function to create primary key for DynamoDB.

I think this would be better as two functions create_simple_primary_key(partition_key) and create_composite_primary_key(partition_key, sort_key). Terminology from https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/HowItWorks.CoreComponents.html#HowItWorks.CoreComponents.PrimaryKey.

May 17 2022, 8:19 AM
jim requested changes to D4015: [services][identity] helper function to create primary key for DynamoDB.
May 17 2022, 8:11 AM
jim accepted D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.

Yeah looks good

May 17 2022, 8:06 AM
jim requested changes to D3959: [Identity] Token constructor.
May 17 2022, 8:04 AM

May 9 2022

jim accepted D3960: [Identity] DatabaseClient method to put pake registration data.
May 9 2022, 10:16 AM
jim requested changes to D3959: [Identity] Token constructor.
May 9 2022, 10:14 AM
jim accepted D3961: [Identity] Add new Error variant.
May 9 2022, 10:08 AM
jim accepted D3962: [Identity] DatabaseClient method to put tokens in DDB.

Just a couple ways to make things more concise and/or readable. Feel free to ignore if you don't like it.

May 9 2022, 10:07 AM

May 5 2022

jim accepted D3853: [Identity] Add a database client.
May 5 2022, 1:39 PM
jim accepted D3693: [services] Dev mode - Add terraform.
May 5 2022, 8:49 AM
jim requested changes to D3921: [Identity] Implement database client method to get pake registration.

Create a real error type

May 5 2022, 8:47 AM
jim resigned from D3920: [Identity] Set max width to 80 characters.

Resigning as reviewer b/c I don't condone 80 char line limits. :-P

May 5 2022, 8:35 AM
jim requested changes to D3853: [Identity] Add a database client.
May 5 2022, 8:30 AM
jim added a comment to D3904: [services] Backup - rename docker to scripts.

Made issue https://linear.app/comm/issue/ENG-1089/dont-copy-dockerfile-into-service-images

May 5 2022, 8:28 AM
jim accepted D3904: [services] Backup - rename docker to scripts.

Ah, interesting. So I intended for the scripts to not get copied twice by putting docker/ in the .dockerignore (see services/backup/.dockerignore). However, that is not actually working and preventing the files from getting copied because apparently the .dockerignore must be in the root of the context -- unlike gitignores, docker doesn't check every subdirectory for a .dockerignore.

May 5 2022, 8:10 AM
jim requested changes to D3693: [services] Dev mode - Add terraform.
May 5 2022, 7:25 AM

May 4 2022

jim accepted D3812: [Identity] Add config for Identity service.
May 4 2022, 10:18 AM
jim requested changes to D3693: [services] Dev mode - Add terraform.

You should add a required_providers declaration somewhere like providers.tf. See https://registry.terraform.io/providers/hashicorp/aws/latest/docs.

May 4 2022, 6:47 AM

Apr 29 2022

jim accepted D3799: [Identity] Script to generate and persist a server keypair for PAKE.

Nice!

Apr 29 2022, 6:51 AM
jim accepted D3690: [services] Dev mode - Set up Backup service.

OK

Apr 29 2022, 6:50 AM

Apr 28 2022

jim accepted D3692: [services] Dev mode - Add localstack to docker compose.
Apr 28 2022, 10:03 PM

Apr 27 2022

jim requested changes to D3692: [services] Dev mode - Add localstack to docker compose.
Apr 27 2022, 9:21 AM

Apr 26 2022

jim accepted D3695: [services] Dev mode - Fix Backup service.
Apr 26 2022, 10:42 AM
jim added a comment to D3692: [services] Dev mode - Add localstack to docker compose.

Yeah, if you're deploying to prod with docker-compose, I'd just make a separate docker-compose.prod.yml and you can do docker-compose -f docker-compose.prod.yml.

Apr 26 2022, 10:39 AM
jim requested changes to D3812: [Identity] Add config for Identity service.
Apr 26 2022, 9:57 AM
jim requested changes to D3799: [Identity] Script to generate and persist a server keypair for PAKE.

I think you should just make a proper CLI for starting the service with one subcommand "server" or something to start the server and "keygen" to run your script. Instead of having a separate binary.

Apr 26 2022, 9:48 AM
jim requested changes to D3690: [services] Dev mode - Set up Backup service.

As noted, COMM_SERVICES_DEV_MODE should not be a compile-time flag, please fix

Apr 26 2022, 9:41 AM
jim accepted D3485: [services] Backup - Remove backup base Docker image.
Apr 26 2022, 9:40 AM

Apr 19 2022

jim accepted D3747: [Identity] Implement some generic OPAQUE types.
Apr 19 2022, 2:55 AM

Apr 18 2022

jim added inline comments to D3690: [services] Dev mode - Set up Backup service.
Apr 18 2022, 11:53 PM
jim accepted D3713: yarn cleaninstall from Docker image.
Apr 18 2022, 11:51 PM
jim requested changes to D3713: yarn cleaninstall from Docker image.
Apr 18 2022, 11:51 PM
jim requested changes to D3692: [services] Dev mode - Add localstack to docker compose.
Apr 18 2022, 9:00 AM
jim accepted D3593: [services][identity] Dockerfile for the identity service.

One thing to fix before landing

Apr 18 2022, 5:45 AM
jim requested changes to D3713: yarn cleaninstall from Docker image.
Apr 18 2022, 5:15 AM

Apr 7 2022

jim accepted D3274: Add intial nix yarn dev env.
Apr 7 2022, 12:52 PM

Apr 6 2022

jim added inline comments to D3532: [services] Backup - Move Service Blob Client.
Apr 6 2022, 5:49 AM

Apr 4 2022

jim updated the diff for D3485: [services] Backup - Remove backup base Docker image.

Rebased

Apr 4 2022, 2:19 PM
jim added inline comments to D3578: [services][identity] grpc scaffolding for the identity service.
Apr 4 2022, 1:59 PM
jim accepted D3578: [services][identity] grpc scaffolding for the identity service.
Apr 4 2022, 1:56 PM
jim accepted D3590: [services][identity] add identity service port to the .env file for docker-compose.
Apr 4 2022, 1:36 PM
jim requested changes to D3497: [services] Dev Mode - Apply local cloud to the Blob service.
Apr 4 2022, 1:35 PM
jim requested changes to D3498: [services] Dev Mode - Apply local cloud to the Backup service.
Apr 4 2022, 1:33 PM
jim accepted D3579: [services][identity] add rustfmt file to the cargo project.
Apr 4 2022, 1:30 PM
jim requested changes to D3593: [services][identity] Dockerfile for the identity service.
Apr 4 2022, 1:28 PM
jim added a comment to D3593: [services][identity] Dockerfile for the identity service.
  1. This should expect the context to be the root directory, like the other services. See how in docker-compose.yml the other services specify the context is "../". Pretty sure the whole point is just to get access to the common proto definitions for now, but it's good for the service builds to be as similar as possible even though this is Rust and the others are C++.
Apr 4 2022, 1:28 PM
jim accepted D3569: [services][identity] initial commit for the identity service..
Apr 4 2022, 1:02 PM
jim updated subscribers of D3274: Add intial nix yarn dev env.

Maybe a crude approach, but we could add something like yarn nix-dev to package.json as an alias for nix develop --extra-experimental-features nix-command --extra-experimental-features flakes?

Apr 4 2022, 1:01 PM
jim requested changes to D3496: [services] Dev Mode - setup local cloud.

This doesn't seem like a good approach, see my comments on D3495. How were these tables and buckets created in the production DB? Were these commands run manually? The same script or migration system should be used in both local and production environments. This approach doesn't permit that because necessarily one database environment has to be set up to create the schema backup which is used to bootstrap the dev environment.

Apr 4 2022, 12:50 PM
jim requested changes to D3495: [services] Dev Mode - create backups for AWS S3 and dynamoDB.

First, there should probably be separate diffs for S3 and DynamoDB as these are very different use cases in my opinion.

Apr 4 2022, 12:46 PM

Mar 22 2022

jim requested review of D3485: [services] Backup - Remove backup base Docker image.
Mar 22 2022, 8:21 AM
jim closed D3481: [services] Remove blob base Docker image.
Mar 22 2022, 8:13 AM
jim committed rCOMM02198024f00d: [services] Remove blob base Docker image (authored by jim).
[services] Remove blob base Docker image
Mar 22 2022, 8:13 AM

Mar 21 2022

jim requested review of D3481: [services] Remove blob base Docker image.
Mar 21 2022, 12:43 PM
jim accepted D3462: [services] Backup - Prepare for communication with Blob.
Mar 21 2022, 8:12 AM

Mar 18 2022

jim added a comment to D3200: [services] Backup - dev mode.

I think it's much better to abandon this and use a local dynamodb service in the docker-compose like https://hub.docker.com/r/amazon/dynamodb-local or https://github.com/localstack/localstack. It's a much simpler and more maintainable solution.

Mar 18 2022, 1:56 PM
jim closed D3399: services: Remove gRPC source after installing.
Mar 18 2022, 5:58 AM
jim committed rCOMM7f17a64e3155: services: Remove gRPC source after installing (authored by jim).
services: Remove gRPC source after installing
Mar 18 2022, 5:58 AM
jim closed D3457: [tunnelbroker] Remove repeated Dockerfile instructions.
Mar 18 2022, 5:56 AM
jim committed rCOMMc6c122495d64: [tunnelbroker] Remove repeated Dockerfile instructions (authored by jim).
[tunnelbroker] Remove repeated Dockerfile instructions
Mar 18 2022, 5:56 AM

Mar 17 2022

jim requested review of D3457: [tunnelbroker] Remove repeated Dockerfile instructions.
Mar 17 2022, 4:30 PM
jim updated the diff for D3399: services: Remove gRPC source after installing.

Rebased

Mar 17 2022, 3:53 PM
jim added inline comments to D3268: [services] Move as much content as possible to the parent base image.
Mar 17 2022, 3:02 PM
jim closed D3403: [services] Remove dependency sources from Docker image.
Mar 17 2022, 2:48 PM
jim committed rCOMMddc7835a4658: [services] Remove dependency sources from Docker image (authored by jim).
[services] Remove dependency sources from Docker image
Mar 17 2022, 2:48 PM

Mar 15 2022

jim updated the diff for D3403: [services] Remove dependency sources from Docker image.
  • Rename build dir from _build to build
Mar 15 2022, 10:35 AM
jim planned changes to D3403: [services] Remove dependency sources from Docker image.
Mar 15 2022, 8:56 AM
jim added inline comments to D3403: [services] Remove dependency sources from Docker image.
Mar 15 2022, 8:01 AM
jim added a comment to D3427: [misc] Introduce `.editorconfig`.

Add a root = true at the top. From docs "root: special property that should be specified at the top of the file outside of any sections. Set to true to stop .editorconfig files search on current file."

Mar 15 2022, 7:35 AM
jim requested review of D3399: services: Remove gRPC source after installing.
In D3399#92777, @karol-bisztyga wrote:

What is the reason behind having grpc flags passed to the cmake in the bash script instead of having them directly in the cmake file?

Mar 15 2022, 7:27 AM

Mar 14 2022

jim added inline comments to D3403: [services] Remove dependency sources from Docker image.
Mar 14 2022, 7:15 AM

Mar 11 2022

jim added inline comments to D3403: [services] Remove dependency sources from Docker image.
Mar 11 2022, 5:55 AM

Mar 10 2022

jim requested review of D3403: [services] Remove dependency sources from Docker image.
Mar 10 2022, 1:42 PM
jim closed D3400: services: Fix mixed whitespace.
Mar 10 2022, 12:31 PM
jim committed rCOMM1311033ad912: services: Fix mixed whitespace (authored by jim).
services: Fix mixed whitespace
Mar 10 2022, 12:31 PM
jim added a comment to D3395: [services] Adjust tabs to be two spaces in build_base_image.sh.
In D3395#91819, @ashoat wrote:

Wonder if we should check in an .editorconfig into the repo

Mar 10 2022, 12:28 PM
jim requested review of D3400: services: Fix mixed whitespace.
Mar 10 2022, 12:19 PM
jim requested review of D3399: services: Remove gRPC source after installing.
Mar 10 2022, 12:17 PM
jim accepted D3395: [services] Adjust tabs to be two spaces in build_base_image.sh.

Oops, just updated my .editorconfig

Mar 10 2022, 11:38 AM
jim closed D3237: tunnelbroker: Use pkg-config to find dependencies.
Mar 10 2022, 8:34 AM
jim committed rCOMM5bf328ff8f1a: tunnelbroker: Use pkg-config to find dependencies (authored by jim).
tunnelbroker: Use pkg-config to find dependencies
Mar 10 2022, 8:34 AM