Please address @ashoat suggestion before landing.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 11 2024
Apr 10 2024
I have for questions for @kamil:
- What is the purpose of version column?
- Isn't the counter value extractable from the session object itself?
- When and how is it going to be updated? Is it possible that value in the version column will go out of sync with the counter value in the session object?
- Finally, is that going to be a problem the we don't have such counterID tracking for notifs sessions - in case it is should we implement it for notifs as well?
Rebase before landing
Apr 9 2024
Remove unnecessary migration function and replace it with dummy lambda that is not run inside transaction.
Check CI - last results confusing
Bring lines accidentally removed during conflict resolution
- Avoid using let instead of const.
Fix throws declaration
Avoid using let instead of const.
Remove unnecessary dispatch_semaphore_signal since it is in the finally statement.
Apr 8 2024
Address Tomek suggestions
Address Tomek suggestions
Address Tomek suggestions
Address Tomek suggestions
Add a try catch to grafecully handle the case if the user doesn't open the app after upgrading it.
Apr 5 2024
- Address Kamil feedback
- Rebase before landing
Some nits left but looks good.
Apr 4 2024
Send different holder to each recipient device
Send different holder to each recipient device
Apr 3 2024
Rebase before landing
Fix clang formaatting in SQLiteQueryExecutorBindings
Apr 2 2024
Accepting but I am of strong opinion that it would be better to create two new structs: NonSyncedKeyserverInfo and SyncedKeyserverInfo that would look exactly the same as original KeyserverInfo. In SQLiteQueryExecutor methods we would just create instances of each class and could rely on simple SQL queries without named parameters. The code would be easier to understand and maintain. It would be two small classes doing simple logic instead of one bigger doing complex logic.
Are we sure that we will never want to inspect the content of keyserver_info values stored in keyserver_synced_data in C++? I am basically asking about the risk that we will have to manually parse JSON-strings in C++ in future.
LGTM for me but please stick to the convention to use SQLiteStatementWrapper.
Mar 26 2024
Rebase before landing
Rebase before landing
Rebase before landing
Do I understand correctly that this diff makes keyserver one time keys upload match approach that is used on native - eagerly marking one time keys as published before they get uploaded to the identity?
Mar 20 2024
- Update queryNotifsUnreadCountStorage function not to rely on array ordering.
- Rebase before landing
- Update a comment about legacy IndexedDB key format.
- Rebase before landing
Rebase before landing
Rebase before landing
Mar 19 2024
Simplify blob client API and make it match the Android one.
Fix missing newline
Renew the code.
Those changes will be included in updated version of child differential.
Fix missing newline
Renew the code.