Page MenuHomePhabricator
Feed Advanced Search

Apr 11 2024

marcin accepted D11594: [lib] errors utils to distinguish between session creation issues.

Please address @ashoat suggestion before landing.

Apr 11 2024, 12:49 AM

Apr 10 2024

marcin accepted D11591: [native] update session creation code to handle versioning.
Apr 10 2024, 8:35 AM
marcin accepted D11586: [web] update session creation code to handle versioning.
Apr 10 2024, 8:27 AM
marcin accepted D11583: [web] update `WorkerCryptoStore` to handle session version.
Apr 10 2024, 6:32 AM
marcin accepted D11582: [native] update C++ crypto module to handle session version.
Apr 10 2024, 6:28 AM
marcin accepted D11580: [SQLite] update `OlmPersistSession` entity.
Apr 10 2024, 6:25 AM
marcin accepted D11577: [SQLite] add version column to session table & rename to `target_device`.
Apr 10 2024, 6:19 AM
marcin closed D11571: Turn migration 38 into a no-op.
Apr 10 2024, 1:57 AM
marcin committed rCOMMe9036e146415: Turn migration 38 into a no-op (authored by marcin).
Turn migration 38 into a no-op
Apr 10 2024, 1:57 AM
marcin added inline comments to D11582: [native] update C++ crypto module to handle session version.
Apr 10 2024, 1:34 AM
marcin added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.

I have for questions for @kamil:

  1. What is the purpose of version column?
  2. Isn't the counter value extractable from the session object itself?
  3. When and how is it going to be updated? Is it possible that value in the version column will go out of sync with the counter value in the session object?
  4. Finally, is that going to be a problem the we don't have such counterID tracking for notifs sessions - in case it is should we implement it for notifs as well?
Apr 10 2024, 1:25 AM
marcin accepted D11572: [web/native] display `userID` & `deviceID` in devtools.
Apr 10 2024, 1:20 AM
marcin updated the diff for D11571: Turn migration 38 into a no-op.

Rebase before landing

Apr 10 2024, 1:14 AM

Apr 9 2024

marcin updated the diff for D11571: Turn migration 38 into a no-op.

Update WASM

Apr 9 2024, 6:37 AM
marcin updated the diff for D11571: Turn migration 38 into a no-op.

Remove unnecessary migration function and replace it with dummy lambda that is not run inside transaction.

Apr 9 2024, 5:51 AM
marcin added inline comments to D11571: Turn migration 38 into a no-op.
Apr 9 2024, 5:35 AM
marcin closed D9069: Schedule blob deletion on Android when large notifications arrives.
Apr 9 2024, 5:28 AM
marcin committed rCOMM526917aee6dd: Schedule blob deletion on Android when large notifications arrives (authored by marcin).
Schedule blob deletion on Android when large notifications arrives
Apr 9 2024, 5:28 AM
marcin closed D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Apr 9 2024, 5:28 AM
marcin closed D9091: Schedule blob deletion on iOS.
Apr 9 2024, 5:28 AM
marcin committed rCOMMbdc32b8a88e9: Upload/download large notification payload from the keyserver/Android NSE if… (authored by marcin).
Upload/download large notification payload from the keyserver/Android NSE if…
Apr 9 2024, 5:28 AM
marcin committed rCOMM2ae576369e6b: Schedule blob deletion on iOS (authored by marcin).
Schedule blob deletion on iOS
Apr 9 2024, 5:28 AM
marcin closed D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Apr 9 2024, 5:28 AM
marcin committed rCOMM190f924e736f: Implement native iOS code to fetch data from blob service and keyserver code to… (authored by marcin).
Implement native iOS code to fetch data from blob service and keyserver code to…
Apr 9 2024, 5:28 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Check CI - last results confusing

Apr 9 2024, 5:08 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Bring lines accidentally removed during conflict resolution

Apr 9 2024, 4:27 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.
  1. Avoid using let instead of const.
Apr 9 2024, 4:19 AM
marcin updated the diff for D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.

Fix throws declaration

Apr 9 2024, 4:18 AM
marcin updated the diff for D9091: Schedule blob deletion on iOS.

Avoid using let instead of const.

Apr 9 2024, 4:16 AM
marcin updated the diff for D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.

Remove unnecessary dispatch_semaphore_signal since it is in the finally statement.

Apr 9 2024, 4:15 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Apr 9 2024, 3:29 AM

Apr 8 2024

marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Address Tomek suggestions

Apr 8 2024, 10:23 AM
marcin updated the diff for D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.

Address Tomek suggestions

Apr 8 2024, 10:23 AM
marcin updated the diff for D9091: Schedule blob deletion on iOS.

Address Tomek suggestions

Apr 8 2024, 10:22 AM
marcin updated the diff for D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.

Address Tomek suggestions

Apr 8 2024, 10:21 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Apr 8 2024, 10:18 AM
marcin added inline comments to D9091: Schedule blob deletion on iOS.
Apr 8 2024, 9:15 AM
marcin added inline comments to D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Apr 8 2024, 8:51 AM
marcin updated the diff for D11571: Turn migration 38 into a no-op.

Add a try catch to grafecully handle the case if the user doesn't open the app after upgrading it.

Apr 8 2024, 6:27 AM
marcin added inline comments to D11571: Turn migration 38 into a no-op.
Apr 8 2024, 6:23 AM
marcin requested review of D11571: Turn migration 38 into a no-op.
Apr 8 2024, 5:30 AM

Apr 5 2024

marcin closed D11541: Introduce fallback mechanism for notifications decryption if MMKV initialization hasn't been executed yet..
Apr 5 2024, 10:35 AM
marcin committed rCOMMd35aa5447d1a: Introduce fallback mechanism for notifications decryption if MMKV… (authored by marcin).
Introduce fallback mechanism for notifications decryption if MMKV…
Apr 5 2024, 10:35 AM
marcin updated the diff for D11541: Introduce fallback mechanism for notifications decryption if MMKV initialization hasn't been executed yet..
  1. Address Kamil feedback
  2. Rebase before landing
Apr 5 2024, 10:15 AM
marcin added inline comments to D11542: [keyserver] Login or register before tables are created.
Apr 5 2024, 5:55 AM
marcin accepted D11542: [keyserver] Login or register before tables are created.

Some nits left but looks good.

Apr 5 2024, 3:18 AM

Apr 4 2024

marcin updated the test plan for D9069: Schedule blob deletion on Android when large notifications arrives.
Apr 4 2024, 10:20 AM
marcin updated the test plan for D9091: Schedule blob deletion on iOS.
Apr 4 2024, 10:20 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Send different holder to each recipient device

Apr 4 2024, 10:18 AM
marcin updated the diff for D9091: Schedule blob deletion on iOS.

Send different holder to each recipient device

Apr 4 2024, 10:16 AM
marcin accepted D11540: [keyserver] Refactor registerOrLogIn to take callbacks.
Apr 4 2024, 9:36 AM
marcin accepted D11472: [native] Blocklist for backed up tables.
Apr 4 2024, 8:13 AM

Apr 3 2024

marcin requested review of D11541: Introduce fallback mechanism for notifications decryption if MMKV initialization hasn't been executed yet..
Apr 3 2024, 6:56 AM
marcin closed D11531: Reorder project.pbxproj after yarn cleaninstall.
Apr 3 2024, 6:31 AM
marcin committed rCOMM42dc0c836e3b: Reorder project.pbxproj after yarn cleaninstall (authored by marcin).
Reorder project.pbxproj after yarn cleaninstall
Apr 3 2024, 6:31 AM
marcin updated the diff for D11531: Reorder project.pbxproj after yarn cleaninstall.

Rebase before landing

Apr 3 2024, 6:29 AM
marcin updated the diff for D11531: Reorder project.pbxproj after yarn cleaninstall.

Fix clang formaatting in SQLiteQueryExecutorBindings

Apr 3 2024, 4:42 AM
marcin requested review of D11531: Reorder project.pbxproj after yarn cleaninstall.
Apr 3 2024, 2:41 AM

Apr 2 2024

marcin accepted D11482: [web/native] Migrate keyserverStore to new tables.
Apr 2 2024, 3:42 AM
marcin accepted D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.

Accepting but I am of strong opinion that it would be better to create two new structs: NonSyncedKeyserverInfo and SyncedKeyserverInfo that would look exactly the same as original KeyserverInfo. In SQLiteQueryExecutor methods we would just create instances of each class and could rely on simple SQL queries without named parameters. The code would be easier to understand and maintain. It would be two small classes doing simple logic instead of one bigger doing complex logic.

Apr 2 2024, 3:39 AM
marcin accepted D11473: [sqlite] Add keyservers_synced_data table.

Are we sure that we will never want to inspect the content of keyserver_info values stored in keyserver_synced_data in C++? I am basically asking about the risk that we will have to manually parse JSON-strings in C++ in future.

Apr 2 2024, 3:08 AM
marcin requested changes to D11472: [native] Blocklist for backed up tables.

LGTM for me but please stick to the convention to use SQLiteStatementWrapper.

Apr 2 2024, 3:03 AM
marcin accepted D11451: [native] update `olm` session creation code use `EncryptedData`.
Apr 2 2024, 2:57 AM
marcin accepted D11450: [web] update `olm` session creation code use `EncryptedData`.
Apr 2 2024, 2:53 AM
marcin accepted D11445: [web] update `encrypt` method to return `EncryptedData`.
Apr 2 2024, 2:15 AM

Mar 26 2024

marcin closed D11234: Implement notifications sessions storage on top of MMKV. Migrate existing notifs account to SQLite.
Mar 26 2024, 9:24 AM
marcin closed D11233: Introduce changes to Session.cpp that allow to decrypt with session object alone.
Mar 26 2024, 9:24 AM
marcin committed rCOMM08380a84539a: Implement notifications sessions storage on top of MMKV. Migrate existing… (authored by marcin).
Implement notifications sessions storage on top of MMKV. Migrate existing…
Mar 26 2024, 9:24 AM
marcin committed rCOMM90e5699676fb: Introduce changes to Session.cpp that allow to decrypt with session object alone (authored by marcin).
Introduce changes to Session.cpp that allow to decrypt with session object alone
Mar 26 2024, 9:24 AM
marcin closed D11232: Introduce notifications crypto module to CommCoreModule.
Mar 26 2024, 9:24 AM
marcin committed rCOMMd5b14c070cef: Introduce notifications crypto module to CommCoreModule (authored by marcin).
Introduce notifications crypto module to CommCoreModule
Mar 26 2024, 9:24 AM
marcin updated the diff for D11234: Implement notifications sessions storage on top of MMKV. Migrate existing notifs account to SQLite.

Rebase before landing

Mar 26 2024, 9:05 AM
marcin updated the diff for D11233: Introduce changes to Session.cpp that allow to decrypt with session object alone.

Rebase before landing

Mar 26 2024, 9:04 AM
marcin updated the diff for D11232: Introduce notifications crypto module to CommCoreModule.

Rebase before landing

Mar 26 2024, 9:03 AM
marcin accepted D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.

Do I understand correctly that this diff makes keyserver one time keys upload match approach that is used on native - eagerly marking one time keys as published before they get uploaded to the identity?

Mar 26 2024, 2:26 AM

Mar 20 2024

marcin closed D11328: Implement multiple keyserver unread count on web and desktop on top of IndexedDB.
Mar 20 2024, 5:37 AM
marcin committed rCOMMb38561ab2233: Implement multiple keyserver unread count on web and desktop on top of IndexedDB (authored by marcin).
Implement multiple keyserver unread count on web and desktop on top of IndexedDB
Mar 20 2024, 5:37 AM
marcin closed D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.
Mar 20 2024, 5:37 AM
marcin closed D11304: Refactor notifications sessions storage to support multiple keyservers on web and desktop.
Mar 20 2024, 5:37 AM
marcin committed rCOMM54933915b3e1: Refactor notifications sessions storage to support multiple keyservers on web… (authored by marcin).
Refactor notifications sessions storage to support multiple keyservers on web…
Mar 20 2024, 5:37 AM
marcin committed rCOMM87eab80d4fa7: Boilerplate for web and desktop to look for keyserverID during notifications… (authored by marcin).
Boilerplate for web and desktop to look for keyserverID during notifications…
Mar 20 2024, 5:37 AM
marcin closed D11302: Send keyserverID in web and desktop notifications.
Mar 20 2024, 5:37 AM
marcin committed rCOMM3fa1401d8bc9: Send keyserverID in web and desktop notifications (authored by marcin).
Send keyserverID in web and desktop notifications
Mar 20 2024, 5:37 AM
marcin updated the diff for D11328: Implement multiple keyserver unread count on web and desktop on top of IndexedDB.
  1. Update queryNotifsUnreadCountStorage function not to rely on array ordering.
  2. Rebase before landing
Mar 20 2024, 4:21 AM
marcin updated the diff for D11304: Refactor notifications sessions storage to support multiple keyservers on web and desktop.
  1. Update a comment about legacy IndexedDB key format.
  2. Rebase before landing
Mar 20 2024, 4:19 AM
marcin updated the diff for D11303: Boilerplate for web and desktop to look for keyserverID during notifications session creation and notification decryption.

Rebase before landing

Mar 20 2024, 4:17 AM
marcin updated the diff for D11302: Send keyserverID in web and desktop notifications.

Rebase before landing

Mar 20 2024, 4:16 AM
marcin accepted D11361: [lib][web] deviceKeyUpload -> newDeviceKeyUpload.
Mar 20 2024, 3:59 AM
marcin added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
Mar 20 2024, 3:58 AM
marcin updated subscribers of D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Mar 20 2024, 3:06 AM
marcin accepted D11356: [native] improve error handling in parseOLMPrekeys.
Mar 20 2024, 2:48 AM

Mar 19 2024

marcin updated the diff for D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.

Simplify blob client API and make it match the Android one.

Mar 19 2024, 10:13 AM
marcin requested review of D9069: Schedule blob deletion on Android when large notifications arrives.
Mar 19 2024, 9:37 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Fix missing newline

Mar 19 2024, 9:37 AM
marcin updated the diff for D9069: Schedule blob deletion on Android when large notifications arrives.

Renew the code.

Mar 19 2024, 9:34 AM
marcin updated the test plan for D9091: Schedule blob deletion on iOS.
Mar 19 2024, 8:31 AM
marcin abandoned D9068: Send blob holder in large notification payload.

Those changes will be included in updated version of child differential.

Mar 19 2024, 8:29 AM
marcin requested review of D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Mar 19 2024, 8:27 AM
marcin updated the diff for D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.

Fix missing newline

Mar 19 2024, 8:17 AM
marcin updated the diff for D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.

Renew the code.

Mar 19 2024, 8:12 AM