- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 12 2023
Prefix env var with COMM_
added @ashoat since this is a new dependency.
Apr 11 2023
COMM_JSONCONFIG variables are never file paths, they are always JSON blobs.
Yeah, that's what Shellcheck wanted me to do. But I think it's unsafe - doesn't that mean $COMM_JSONCONFIG_secrets_geoip_license won't be quoted? I think the open quote is actually closing the quote from line 13, and the close quote is actually opening a new quote. So that leaves $COMM_JSONCONFIG_secrets_geoip_license unquoted
Going to assume that we don't want to spend anymore time on this.
switched [[ -n to [[ -r, as I realized later that COMM_JSONCONFIG_secrets_geoip_license was a file path to a json config.
Capitalize docker, revisit error message
Apr 7 2023
Address feedback: move secrets dir creation to it's own block
Looks fine for a transition commit, still missing the other X3DH elements.
Apr 6 2023
Address feedback
Apr 4 2023
looks good to me from a bash perspective
Apr 3 2023
Looks like i got distracted friday
Mar 30 2023
Remove primaryDevice, reference protobuf file
Mar 29 2023
Address more feedback
Add device type
Mar 28 2023
rust looks okay to me. Just don't like that the callee has to have awareness of the promise ID.
address feedback
Remove index.js stub
LGTM, ill defer to react/redux people for correctness
I don't feel strongly about the rust code, which is ephemeral anyway.
I'm not able to comment on gradle code, but I couldn't find a better way to do this using just cmake + corrosion + cxxbridge
Mar 27 2023
Nothing looks super surprising here, thanks!
Mar 23 2023
A little out my expertise for best practcies, but looks good
Rebase on master